Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0056349 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Retail API | major | always | 2024-09-03 12:20 | 2024-10-01 10:28 | |||
| Reporter | kchoperena | View Status | public | |||||
| Assigned To | andrea_lopez | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0056349: [Distribution Order API]: IsAutomaticallyIssueStock parameter is kept between sessions | |||||||
| Description | If a request includes IsAutomaticallyIssueStock=Y at least one time then this configuration is randomly used for other requests that doesn't include this parameter. | |||||||
| Steps To Reproduce | 1.- Create a distribution order receipt using the back-end 2.- Book it 3.- Using Postman or any REST testing tool send to the Distribution Order API (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/api?urls.primaryName=Business%20API%20-%20Transactional%20Data#/DistributionOrder/Import_DistributionOrder [^]) an update for the previously created distribution order issue Example JSON: [ { "organization": "The White Valley Group", "documentNo": "1000112", "isIssue": true, "description": "test", "IsAutomaticallyIssueStock": true, "lines": [ { "lineNo": 10, "product": "DX58ORT-F9913", "qtyConfirmed": 3 } ] } ] 4.- Create another distribution order issue and book it 5.- Update the distribution order issue using the API: [ { "organization": "The White Valley Group", "documentNo": "1000114", "isIssue": true, "description": "test", "lines": [ { "lineNo": 10, "product": "DX58ORT-F9913", "qtyConfirmed": 3 } ] } ] RESULT: The system is trying to automatically issue the distribution order regardless the IsAutomaticallyIssueStock property is not passed in the request. Note that this might be randomly reproduced. | |||||||
| Proposed Solution | Revise how the IsAutomaticallyIssueStock is passed to ensure only this request can be seen. This might require discussing with the Platform team | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0168694) vmromanos (developer) 2024-09-03 12:35 |
For the developer fixing it: The usage of SessionInfo to save the ISSUEQTYMAP is not working as designed, because it is kept outside of the request scope. This hack was developed in a moment where the API framework was very primitive. We should check with Platform a best way to cover this feature (because I think it is now possible). |
|
(0169637) hgbot (developer) 2024-09-26 12:54 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/merge_requests/37 [^] |
|
(0169819) hgbot (developer) 2024-10-01 10:28 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api [^] Changeset: e226558ca9b30a2bffa108f5657b2ab3e4942ba0 Author: Martin Taal <martin.taal@openbravo.com> Date: 01-10-2024 08:28:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/commit/e226558ca9b30a2bffa108f5657b2ab3e4942ba0 [^] Fixes ISSUE-56349: use requestcontext to store issue qty map --- M src/org/openbravo/distributionorder/api/hook/distributionorder/ImportDOBaseOBObjectFetcher.java M src/org/openbravo/distributionorder/api/hook/distributionorder/ImportDOUtils.java --- |
|
(0169820) hgbot (developer) 2024-10-01 10:28 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/merge_requests/37 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-09-03 12:20 | kchoperena | New Issue | |
| 2024-09-03 12:20 | kchoperena | Assigned To | => Triage Platform Conn |
| 2024-09-03 12:20 | kchoperena | Triggers an Emergency Pack | => No |
| 2024-09-03 12:31 | vmromanos | Steps to Reproduce Updated | View Revisions |
| 2024-09-03 12:35 | vmromanos | Note Added: 0168694 | |
| 2024-09-03 12:53 | kchoperena | Assigned To | Triage Platform Conn => Triage Omni WMS |
| 2024-09-09 09:29 | mtaal | Assigned To | Triage Omni WMS => andrea_lopez |
| 2024-09-26 12:54 | hgbot | Note Added: 0169637 | |
| 2024-10-01 10:28 | hgbot | Resolution | open => fixed |
| 2024-10-01 10:28 | hgbot | Status | new => closed |
| 2024-10-01 10:28 | hgbot | Note Added: 0169819 | |
| 2024-10-01 10:28 | hgbot | Note Added: 0169820 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |