Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0056112
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2024-07-25 17:292024-08-13 10:54
ReporterivazquezView Statuspublic 
Assigned ToRajesh_18 
PriorityhighResolutionfixedFixed in Version24Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056112: In payment window, if the payment amount is 0, the SubtotalLines Summary field show undefined <currencySymbol>

DescriptionFound when using prepayments, including a little customization but probably replicated if the prepayment amount is set to 0.

The customization allows the user to set a custom prepayment for each ticket, including a 0% prepayment, thus setting the prepayment amount to 0.

When this happens, the subtotal summary line shows the undefined <currencySymbol> tag.

Technical details: The component SubtotalLines renders a TicketSummaryView component. This component tries to display the payment amount.

At some point, it checks if the parameter grossAmount passed from SubtotalLines to TicketSummaryView is true (in this case, 0 is falsy for js).

This causes the TicketSummaryView component to try to display the amount of lines, but SubtotalLines component passes the no lines parameter.

This makes the component calculate the amount to render as undefined, finally showing undefined in the POS2.
Steps To Reproduce-Make all the configuration to use PrePayment
-Go to the WebPOS
-Go to the Payment Section
-Select the Prepayment
-Check the undefined in the amout
Proposed SolutionIn SubtotalLines.jsx component, when returning TicketSummaryView component, add lines={lines} parameter.
TagsNo tags attached.
Attached Filespng file icon noLines.png [^] (146,844 bytes) 2024-07-25 17:29


png file icon withParameter.png [^] (154,417 bytes) 2024-07-25 17:29

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0167376)
hgbot (developer)
2024-07-26 09:04

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2821 [^]
(0168021)
hgbot (developer)
2024-08-13 10:54

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2821 [^]
(0168022)
hgbot (developer)
2024-08-13 10:54

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fde4a94d5e1d2239168fad4252a40ff8c97338a4
Author: Rajesh Senthilkumar <rajesh.senthilkumar.ext@openbravo.com>
Date: 13-08-2024 08:54:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fde4a94d5e1d2239168fad4252a40ff8c97338a4 [^]

Fixed ISSUE-56112: Add lines as parameter to calculate line total component

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalLines.jsx
---

- Issue History
Date Modified Username Field Change
2024-07-25 17:29 ivazquez New Issue
2024-07-25 17:29 ivazquez Assigned To => Retail
2024-07-25 17:29 ivazquez File Added: noLines.png
2024-07-25 17:29 ivazquez Triggers an Emergency Pack => No
2024-07-25 17:29 ivazquez File Added: withParameter.png
2024-07-26 07:57 guillermogil Status new => acknowledged
2024-07-26 08:32 Rajesh_18 Assigned To Retail => Rajesh_18
2024-07-26 08:32 Rajesh_18 Status acknowledged => scheduled
2024-07-26 09:04 hgbot Note Added: 0167376
2024-08-13 10:54 hgbot Resolution open => fixed
2024-08-13 10:54 hgbot Status scheduled => closed
2024-08-13 10:54 hgbot Note Added: 0168021
2024-08-13 10:54 hgbot Fixed in Version => 24Q4
2024-08-13 10:54 hgbot Note Added: 0168022


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker