0056064: The BATCH_CLOSE json is not sending the informations about the payments collected, if they are not counted

Description

if the payment are not counted during the cashup we are getting a batch_close websocket message without the payment data block :

{
    "terminal": {
        "ID": "0005",
        "operator": "ameftoh",
        "locale": "en_US",
        "organization": "20"
    },
    "action": "BATCH_CLOSE",
    "serviceId": "0228821976",
    "data": {
        "cacheSessionId": null,
        "timezoneOffset": -120,
        "cashupDate": "2024-07-18T13:49:02.628Z",
        "lastcashupeportdate": "2024-07-18T13:49:02.628Z",
        "grossReturns": 0,
        "grossSales": 808.41,
        "initialTicketDate": "2024-07-18T13:48:53.140Z",
        "netReturns": 0,
        "netSales": 668.11,
        "totalRetailTransactions": 808.41,
        "totalStartings": 0,
        "paymentsData": []
    }
}

Steps To Reproduce

have a payment provider using the payment API.
do a cashup without any payment as 'count in cashup'
the message sent in the payment API has no payemnt data

if we put that payment as count in csahup we have the information

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0167516) adrianromero (manager) 2024-07-31 08:59	This issue is already solved in https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment/-/commit/2e1925c23e56b12c5d91e61ef3295ab323775b33 [^] paymentsData will continue sending only payments information that is counted as it is the implemented behaviour. the new providerGroupData includes now the payment information independently whethere is counted or not. BUT only for the payments that belong ot the payment group of the event

Issue History
Date Modified	Username	Field	Change
2024-07-18 16:10	azzeddine_meftoh	New Issue
2024-07-18 16:10	azzeddine_meftoh	Assigned To	=> Retail
2024-07-18 16:10	azzeddine_meftoh	Triggers an Emergency Pack	=> No
2024-07-18 16:18	martinsdan	Assigned To	Retail => Triage Platform Conn
2024-07-18 16:24	martinsdan	Issue Monitored: martinsdan
2024-07-31 08:56	adrianromero	Status	new => scheduled
2024-07-31 08:56	adrianromero	Assigned To	Triage Platform Conn => adrianromero
2024-07-31 08:59	adrianromero	Note Added: 0167516
2024-07-31 08:59	adrianromero	Status	scheduled => resolved
2024-07-31 08:59	adrianromero	Resolution	open => fixed
2024-07-31 09:00	adrianromero	Review Assigned To	=> adrianromero
2024-07-31 09:00	adrianromero	Status	resolved => closed