Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0055872 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
feature request | [Retail Modules] Retail API Discount | minor | have not tried | 2024-07-01 03:51 | 2025-01-10 09:07 | |||
Reporter | gaboflash | View Status | public | |||||
Assigned To | gaboflash | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0055872: Add a new API similar to the currently existing Discounts API to get the discounts visibility feature | |||||||
Description | Create a new API that receive a list of products identified by the searchKey, the corresponding organization, and the list of flags that provide the configuration for the discounts Visibility feature, and then will return the results of the discounts visibility feature, including the list of candidate discounts and the identified prices for the products JIRA: https://openbravo.atlassian.net/browse/RM-15453 [^] | |||||||
Steps To Reproduce | N/A | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||
|
Notes | |
(0167200) hgbot (developer) 2024-07-22 05:22 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/23 [^] |
(0167201) hgbot (developer) 2024-07-22 05:24 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2810 [^] |
(0167202) hgbot (developer) 2024-07-22 05:26 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/merge_requests/72 [^] |
(0167203) hgbot (developer) 2024-07-22 05:28 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/286 [^] |
(0167204) hgbot (developer) 2024-07-22 05:29 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/merge_requests/36 [^] |
(0167205) hgbot (developer) 2024-07-22 05:30 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/148 [^] |
(0167818) hgbot (developer) 2024-08-08 07:31 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.jsexecutor/-/merge_requests/11 [^] |
(0168190) hgbot (developer) 2024-08-19 08:02 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/113 [^] |
(0168191) hgbot (developer) 2024-08-19 08:02 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/114 [^] |
(0168233) hgbot (developer) 2024-08-20 07:04 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/100 [^] |
(0168377) hgbot (developer) 2024-08-22 14:49 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/113 [^] |
(0168778) hgbot (developer) 2024-09-05 12:11 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 6762435c2d520bda2d549c34df1515778cc904a8 Author: Antonio Moreno <antonio.moreno@openbravo.com> Date: 05-09-2024 12:11:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/6762435c2d520bda2d549c34df1515778cc904a8 [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- A src/org/openbravo/retail/discounts/DiscountVisibilityRuleFilter.java A src/org/openbravo/retail/discounts/DiscountVisibilityRuleFilterProvider.java A web-test/model/business-logic/discounts-engine/engine/discount-visibility-base.test.js A web-test/model/business-logic/discounts-engine/engine/discount-visibility.test.js A web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-visibility.js M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src/org/openbravo/retail/discounts/DiscountsEngineAppComponentProvider.java --- |
(0168779) hgbot (developer) 2024-09-05 12:11 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/148 [^] |
(0168780) hgbot (developer) 2024-09-05 12:12 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^] Changeset: 0c8cbc2cc92ef21ebacc8d4da1cb951913462bd1 Author: Antonio Moreno <antonio.moreno@openbravo.com> Date: 05-09-2024 12:11:51 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/0c8cbc2cc92ef21ebacc8d4da1cb951913462bd1 [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- A api/org.openbravo.discounts-discounts-visibility.yml A src/org/openbravo/discounts/engine/graal/GraalDiscountsVisibilityExecutor.java A src/org/openbravo/discounts/engine/graal/GraalEngineExecutor.java A src/org/openbravo/discounts/engine/graal/GraalEngineExecutorProducer.java A src/org/openbravo/discounts/utility/DiscountsInitializationUtils.java A src/org/openbravo/discounts/utility/DiscountsVisibilityResult.java A src/org/openbravo/discounts/utility/ProductInfo.java A src/org/openbravo/discounts/ws/DiscountsVisibilityWebService.java M config/org.openbravo.discounts-provider-config.xml M src-test/org/openbravo/discounts/test/base/deploy/DiscountsJSTestProvider.java M src-test/org/openbravo/discounts/test/base/executor/DiscountsCalculator.java M src-test/org/openbravo/discounts/test/base/executor/NodeDiscountsExecutor.java M src-test/org/openbravo/discounts/test/base/executor/WebServiceDiscountsExecutor.java M src-test/org/openbravo/discounts/test/performance/PerformanceTest.java M src/org/openbravo/discounts/engine/DiscountJSExecutor.java M src/org/openbravo/discounts/engine/graal/GraalDiscountsExecutor.java --- |
(0168781) hgbot (developer) 2024-09-05 12:12 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 2f4e51a91b33260ca5e2f2afdeaf8fc60c8a26cc Author: Antonio Moreno <antonio.moreno@openbravo.com> Date: 05-09-2024 12:12:31 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2f4e51a91b33260ca5e2f2afdeaf8fc60c8a26cc [^] Fixed ISSUE-55872: Implemented Discounts Visibilitiy API --- A src/org/openbravo/pos2/discountvisibility/POS2DiscountVisibilityRuleFilterProvider.java A web-jspack/org.openbravo.pos2/src/core/discount/__test__/registerDiscountVisibilityPosFunctions.test.js A web-jspack/org.openbravo.pos2/src/core/discount/registerDiscountVisibilityPosFunctions.js M web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangeOrderLineWrapper/__test__/ExchangeOrderLineWrapper.test.jsx M web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangeProductSelectorDialog/__test__/ExchangeProductSelectorDialog.test.jsx M web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/__test__/ExchangeProductSelector.test.jsx M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContentDiscount/ProductButtonContentDiscount.jsx M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContentDiscount/__test__/ProductButtonContentDiscount.test.jsx M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductPopover/__test__/ProductPopover.test.jsx M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductPopoverDiscounts/ProductPopoverDiscounts.jsx M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/ProofOfPaymentDetailLine/__test__/ProofOfPaymentDetailLine.test.jsx M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/__test__/ProofOfPaymentDetails.test.jsx M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/__test__/SelectLines.test.jsx M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/stories/SelectLines.stories.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/__test__/TicketArea.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/stories/TicketArea.stories.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/__test__/TicketLineDiscount.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLines.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/stories/TicketLines.stories.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/__test__/TicketSummary.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/storybook/TicketSummary.stories.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/storybook/TicketSummaryView.stories.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscountLine/stories/TicketSummaryDiscountLine.stories.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscountVisibility/TicketSummaryDiscountVisibility.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscountVisibility/__test__/TicketSummaryDiscountVisibility.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscounts/stories/TicketSummaryDiscounts.stories.jsx M web-jspack/org.openbravo.pos2/src/components/TicketLineRenderCell/__test__/TicketLineRenderCell.test.jsx M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCellWrapper/__test__/TicketLineRenderCellWrapper.test.jsx M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/__test__/VerifiedReturnsGrid.test.jsx M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/stories/VerifiedReturnsGrid.stories.jsx M web-jspack/org.openbravo.pos2/src/ob-init.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/__test__/discountsVisibilityBase.test.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/__test__/discountsVisibilityCalculateInfo.test.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/__test__/discountsVisibilityChecks.test.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/__test__/getVisibleDiscountsInTicketLine.test.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/__test__/getVisibleDiscountsInTicketTotal.test.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/discountsVisibilityBase.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/discountsVisibilityCalculateInfo.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/discountsVisibilityChecks.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/getVisibleDiscountsInTicketLine.js R web-jspack/org.openbravo.pos2/src/core/discount/discountsVisibility/getVisibleDiscountsInTicketTotal.js --- |
(0168782) hgbot (developer) 2024-09-05 12:12 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2810 [^] |
(0168783) hgbot (developer) 2024-09-05 12:13 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing [^] Changeset: 85d66386f759b94fde07c0afbc20ce895f950ddb Author: Gabriel Lopez <gabriel.lopez@doceleguas.com> Date: 05-09-2024 10:13:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/commit/85d66386f759b94fde07c0afbc20ce895f950ddb [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- A src/org/openbravo/pos2/product/label/printing/provider/POS2PlpDiscountVisibilityRuleFilterProvider.java M web-jspack/org.openbravo.pos2.product.label.printing/src/components/PrintProductLabel/PrintProductLabelSelectProdStep/PrintProductLabelPrintLabelButton/PrintProductLabelPrintLabelButton.jsx --- |
(0168784) hgbot (developer) 2024-09-05 12:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/merge_requests/72 [^] |
(0168785) hgbot (developer) 2024-09-05 12:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/286 [^] |
(0168786) hgbot (developer) 2024-09-05 12:13 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.jsexecutor [^] Changeset: fbd30e570d01023016e91accc1754eae47294c2e Author: Gabriel Lopez <gabriel.lopez@doceleguas.com> Date: 05-09-2024 10:13:35 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.jsexecutor/-/commit/fbd30e570d01023016e91accc1754eae47294c2e [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- M src/org/openbravo/service/jsexecutor/utility/JSONGraalUtils.java --- |
(0168787) hgbot (developer) 2024-09-05 12:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.jsexecutor/-/merge_requests/11 [^] |
(0168788) hgbot (developer) 2024-09-05 12:13 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: 617280c1a37b5927219ae6d17905c895a5d4209d Author: Gabriel Lopez <gabriel.lopez@doceleguas.com> Date: 05-09-2024 10:13:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/617280c1a37b5927219ae6d17905c895a5d4209d [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/__test__/TicketMenuLine.test.jsx --- |
(0168789) hgbot (developer) 2024-09-05 12:13 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api [^] Changeset: fc3304fdb2c842fd77f831f726b6ce0cd7e3df0f Author: Gabriel Lopez <gabriel.lopez@doceleguas.com> Date: 05-09-2024 10:13:39 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/commit/fc3304fdb2c842fd77f831f726b6ce0cd7e3df0f [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- M examples/Retail API.postman_collection.json --- |
(0168790) hgbot (developer) 2024-09-05 12:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/114 [^] |
(0168791) hgbot (developer) 2024-09-05 12:13 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^] Changeset: 0a18ededd1d9c2be2df5fc0ec01332a676937b1e Author: Gabriel Lopez <gabriel.lopez@doceleguas.com> Date: 05-09-2024 10:13:46 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/0a18ededd1d9c2be2df5fc0ec01332a676937b1e [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- A referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml A referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml M src-db/database/sourcedata/AD_DATASET_TABLE.xml --- |
(0168792) hgbot (developer) 2024-09-05 12:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/100 [^] |
(0168793) hgbot (developer) 2024-09-05 12:13 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout [^] Changeset: 29cd31aa609b0e2d49610f3ee1b02f5b010938b1 Author: Gabriel Lopez <gabriel.lopez@doceleguas.com> Date: 05-09-2024 10:13:53 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/commit/29cd31aa609b0e2d49610f3ee1b02f5b010938b1 [^] Fixed ISSUE-55872: Implemented Discounts Visibility API --- M web-jspack/org.openbravo.pos2.selfcheckout/src/components/Ticket/SCOTicketView/SCOTicketLines/SCOTicketLine/SCOProductInfoContainer/SCOTicketLineDiscounts/SCOTicketLineDiscounts.jsx --- |
(0168794) hgbot (developer) 2024-09-05 12:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/merge_requests/36 [^] |
(0168796) hgbot (developer) 2024-09-05 12:17 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/23 [^] |
(0168817) marvintm (manager) 2024-09-05 14:06 |
This commit is also part of this development: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/d385a05e262b1354abe64081ed882dda5f99258d [^] |
(0168832) hgbot (developer) 2024-09-06 07:41 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 67e0b11d6f307158fb13c68045ab76c5487e25ce Author: Antonio Moreno <antonio.moreno@openbravo.com> Date: 06-09-2024 07:41:31 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/67e0b11d6f307158fb13c68045ab76c5487e25ce [^] Related to ISSUE-55872: Fixed eslint problem --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-visibility.js --- |
Issue History | |||
Date Modified | Username | Field | Change |
2024-07-01 03:51 | gaboflash | New Issue | |
2024-07-01 03:51 | gaboflash | Assigned To | => gaboflash |
2024-07-01 03:51 | gaboflash | Triggers an Emergency Pack | => No |
2024-07-22 05:22 | hgbot | Note Added: 0167200 | |
2024-07-22 05:24 | hgbot | Note Added: 0167201 | |
2024-07-22 05:26 | hgbot | Note Added: 0167202 | |
2024-07-22 05:28 | hgbot | Note Added: 0167203 | |
2024-07-22 05:29 | hgbot | Note Added: 0167204 | |
2024-07-22 05:30 | hgbot | Note Added: 0167205 | |
2024-08-08 07:31 | hgbot | Note Added: 0167818 | |
2024-08-19 08:02 | hgbot | Note Added: 0168190 | |
2024-08-19 08:02 | hgbot | Note Added: 0168191 | |
2024-08-20 07:04 | hgbot | Note Added: 0168233 | |
2024-08-22 14:49 | hgbot | Note Added: 0168377 | |
2024-09-05 12:11 | hgbot | Resolution | open => fixed |
2024-09-05 12:11 | hgbot | Status | new => closed |
2024-09-05 12:11 | hgbot | Fixed in Version | => RR24Q4 |
2024-09-05 12:11 | hgbot | Note Added: 0168778 | |
2024-09-05 12:11 | hgbot | Note Added: 0168779 | |
2024-09-05 12:12 | hgbot | Note Added: 0168780 | |
2024-09-05 12:12 | hgbot | Fixed in Version | RR24Q4 => 24Q4 |
2024-09-05 12:12 | hgbot | Note Added: 0168781 | |
2024-09-05 12:12 | hgbot | Note Added: 0168782 | |
2024-09-05 12:13 | hgbot | Note Added: 0168783 | |
2024-09-05 12:13 | hgbot | Note Added: 0168784 | |
2024-09-05 12:13 | hgbot | Note Added: 0168785 | |
2024-09-05 12:13 | hgbot | Note Added: 0168786 | |
2024-09-05 12:13 | hgbot | Note Added: 0168787 | |
2024-09-05 12:13 | hgbot | Note Added: 0168788 | |
2024-09-05 12:13 | hgbot | Note Added: 0168789 | |
2024-09-05 12:13 | hgbot | Note Added: 0168790 | |
2024-09-05 12:13 | hgbot | Note Added: 0168791 | |
2024-09-05 12:13 | hgbot | Note Added: 0168792 | |
2024-09-05 12:13 | hgbot | Note Added: 0168793 | |
2024-09-05 12:13 | hgbot | Note Added: 0168794 | |
2024-09-05 12:17 | hgbot | Note Added: 0168796 | |
2024-09-05 14:06 | marvintm | Note Added: 0168817 | |
2024-09-06 07:41 | hgbot | Note Added: 0168832 | |
2025-01-10 09:06 | gorka_gil | Relationship added | causes 0056692 |
2025-01-10 09:07 | gorka_gil | Fixed in Version | 24Q4 => |
2025-01-10 09:07 | gorka_gil | Description Updated | View Revisions |
Copyright © 2000 - 2009 MantisBT Group |