Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0055780
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2024-06-17 11:352024-07-16 17:34
ReporterjfvaringotView Statuspublic 
Assigned Tosreehari 
PriorityurgentResolutionfixedFixed in Version24Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0055780: POS2 - Safebox - Not amount to keep at step 2

DescriptionTESTED ON LIVEBUILDS : https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql [^]

When counting after the cash-up, it's not possible anymore to define the amount to keep.
Steps To ReproduceOn back-office :
1. On Touchpoint type 'POS2SD VBS POS2 Terminal Type', set 'Use Safe Box' to true.
2. On Touchpoint type 'POS2SD VBS POS2 Terminal Type'>'Payment Method'>'Cash' : set 'Definied in Safebox' to true
3. On Safeboxes (can be done on all already created safe boxes) : Set 'Count on Remove' to True
4. On Safeboxes (can be done on all already created safe boxes) : Payment Method > Cash > Count Safe Box : set all check boxes to true, and keep the already defined amounts.

On POS (tested on VBS-2 and VBS-3) :
1. At start, select a safebox, and do the initial counting.
2. Do sales : more than 100€.
3. Do the cash-up > after the cash-up, count the safebox
4. Step 1 : OK -> the amount to count is displayed
5. Step 2 : KO -> nothing is displayed
6. After having finished the counting, all is moved to the financial account.
TagsNo tags attached.
Attached Filespng file icon Safebox setting.png [^] (99,941 bytes) 2024-06-17 11:35


png file icon Safebox count step 1.png [^] (72,675 bytes) 2024-06-17 11:35


png file icon Safebox count step 2 - KO.png [^] (54,559 bytes) 2024-06-17 11:35


png file icon Safebox count step 3.png [^] (87,667 bytes) 2024-06-17 11:35


png file icon Safebox cash financial account - all is moved in.png [^] (169,222 bytes) 2024-06-17 11:35

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0054548 closedsreehari [Cash Up - Keep Amount] Configuration not taken into account properly 

-  Notes
(0166391)
gorka_gil (administrator)
2024-06-26 17:31

 Sreehari and me do this change to have a function that shows the needed buttons in the step of amount to keep:
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2444?commit_id=21e981cc027fa5ea7d245df461052556de303feb [^]

This could be that we haven't check a special case with safe boxes, or in safe boxes flow it is not calling to our function. Or could be any other thing, so needed to take a look to this.
(0166609)
hgbot (developer)
2024-07-02 15:08

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2771 [^]
(0166610)
hgbot (developer)
2024-07-02 15:09

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1619 [^]
(0166629)
hgbot (developer)
2024-07-03 10:02

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1619 [^]
(0167027)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 65914d71ff00919f9011adf5c4342bf16012dd57
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/65914d71ff00919f9011adf5c4342bf16012dd57 [^]

Fixes ISSUE-55780: Added condition for validating safebox cashup

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSelectedPaymentMethod.js
---
(0167028)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d51336887f12826d8b33c1064ceb6d2347435211
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d51336887f12826d8b33c1064ceb6d2347435211 [^]

Fixes ISSUE-55780: Added getSafeBoxCashToKeepConfig function for Safebox

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SelectSafeboxToCount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSelectedPaymentMethod.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/utils/getCashToKeepConfig.js
---
(0167029)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7ae9689c80a4eed52e06d6cbe5606a7b41521de2
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7ae9689c80a4eed52e06d6cbe5606a7b41521de2 [^]

Fixes ISSUE-55780: Added new config for safeBox cashup

---
A web-jspack/org.openbravo.pos2/src/components/Cashup/CountSbWithoutCashToKeep.config.json
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSelectedPaymentMethod.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0167030)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a962fb7f1783779b9dc99ff5209f0c703e15f11b
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a962fb7f1783779b9dc99ff5209f0c703e15f11b [^]

Fixes ISSUE-55780: Added test case for Safe Box Scenarios
*fixed Jest test failures

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/__test__/processPayment.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/utils/__test__/getCashToKeepConfig.test.js
---
(0167031)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: cc776761c31df1ebcb33984225fbaaaa8f817208
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cc776761c31df1ebcb33984225fbaaaa8f817208 [^]

Fixes ISSUE-55780: Added CountSbWithoutPaymentMethodsConfig case
*with this case when there are no safebox payments available we will have direct post, print, close cashup step

---
A web-jspack/org.openbravo.pos2/src/components/Cashup/CountSbWithoutPaymentMethods.config.json
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenCountSafebox.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCountSafebox.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/CountSafeboxWindowHooks.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0167032)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 89affa1cbdfc4bab76c4f039b7e0883c6083548e
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/89affa1cbdfc4bab76c4f039b7e0883c6083548e [^]

Fixes ISSUE-55780: Reverted changes related to safeboxwithoutPaymentMethods
*reverted changes related to case handled to skip step one of cashup when we have no payments

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/__test__/processPayment.test.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenCountSafebox.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCountSafebox.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/CountSafeboxWindowHooks.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
R web-jspack/org.openbravo.pos2/src/components/Cashup/CountSbWithoutPaymentMethods.config.json
---
(0167033)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f80342bb4073522f100ca4961d463983e2857ca2
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f80342bb4073522f100ca4961d463983e2857ca2 [^]

Fixes ISSUE-55780: Renamed CountSafeboxWithoutCashToKeepConfig config file

---
A web-jspack/org.openbravo.pos2/src/components/Cashup/CountSafeboxWithoutCashToKeep.config.json
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0167034)
hgbot (developer)
2024-07-16 17:34

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2771 [^]
(0167035)
hgbot (developer)
2024-07-16 17:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2758b8d322651b17b835fce1ac127ae22343e5b3
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-07-2024 15:34:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2758b8d322651b17b835fce1ac127ae22343e5b3 [^]

Fixes ISSUE-55780: Removed 'countSafebox' cashupmode logic
*since it is not required when counting the cash, we have already selected safebox
*fixed related tests

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/MatchCountedWithExpected.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetSelectedPaymentMethod.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSelectedPaymentMethod.js
---

- Issue History
Date Modified Username Field Change
2024-06-17 11:35 jfvaringot New Issue
2024-06-17 11:35 jfvaringot Assigned To => Retail
2024-06-17 11:35 jfvaringot File Added: Safebox setting.png
2024-06-17 11:35 jfvaringot Triggers an Emergency Pack => No
2024-06-17 11:35 jfvaringot File Added: Safebox count step 1.png
2024-06-17 11:35 jfvaringot File Added: Safebox count step 2 - KO.png
2024-06-17 11:35 jfvaringot File Added: Safebox count step 3.png
2024-06-17 11:35 jfvaringot File Added: Safebox cash financial account - all is moved in.png
2024-06-17 11:51 victor_perez Priority normal => urgent
2024-06-17 11:51 victor_perez Severity critical => major
2024-06-26 17:26 marvintm Status new => acknowledged
2024-06-26 17:31 gorka_gil Note Added: 0166391
2024-06-27 08:38 sreehari Assigned To Retail => sreehari
2024-06-27 11:12 sreehari Relationship added related to 0054548
2024-06-27 11:14 sreehari Status acknowledged => scheduled
2024-07-02 15:08 hgbot Note Added: 0166609
2024-07-02 15:09 hgbot Note Added: 0166610
2024-07-03 10:02 hgbot Note Added: 0166629
2024-07-16 17:34 hgbot Resolution open => fixed
2024-07-16 17:34 hgbot Status scheduled => closed
2024-07-16 17:34 hgbot Fixed in Version => 24Q4
2024-07-16 17:34 hgbot Note Added: 0167027
2024-07-16 17:34 hgbot Note Added: 0167028
2024-07-16 17:34 hgbot Note Added: 0167029
2024-07-16 17:34 hgbot Note Added: 0167030
2024-07-16 17:34 hgbot Note Added: 0167031
2024-07-16 17:34 hgbot Note Added: 0167032
2024-07-16 17:34 hgbot Note Added: 0167033
2024-07-16 17:34 hgbot Note Added: 0167034
2024-07-16 17:34 hgbot Note Added: 0167035

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker