Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0055703
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Retail APImajorhave not tried2024-06-06 11:172024-08-21 13:51
ReporterAgatheBertinView Statuspublic 
Assigned Tosreehari 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toadrianromero
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0055703: API Order - Swagger with wrong format

DescriptionThe swagger for the API Order is telling the lines.grossUnitPrice and lines.grossAmount are : NUMBER 2

I would say the 2 is wrong (should be 12 or 22)
Steps To ReproduceGenerate an order with a big amount of unitPrice, see the number is more than 2 .
Proposed SolutionChange the swagger to add the proper format
===> PLEASE review all the formats for numbers in this API, I may have miss somes.

TagsNo tags attached.
Attached Filespng file icon Screenshot from 2024-06-24 16-23-30.png [^] (47,217 bytes) 2024-06-24 16:24


png file icon 2024-06-24_16h33_42.png [^] (19,071 bytes) 2024-06-25 08:43


png file icon Screenshot 2024-08-16 at 12.53.30 PM.png [^] (50,355 bytes) 2024-08-16 09:24

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0166271)
adrianromero (manager)
2024-06-24 16:24

The length displayed by the API is correct. Is the length defined in the table.

See attached screenshot
(0166286)
AgatheBertin (developer)
2024-06-25 08:42

What is expected here is to review and modify the column definition for that field and maybe others

Because the swagger is telling length 2, but when we export the order, the length can be >2 (see attached)

Endpoint :
/org.openbravo.api.ExportService/Order
(0168133)
hgbot (developer)
2024-08-16 12:03

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1330 [^]
(0168319)
hgbot (developer)
2024-08-21 13:51

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 65478c4cd7c27ba4c317ddd56215d7bfb4ab671f
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 21-08-2024 11:51:20
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/65478c4cd7c27ba4c317ddd56215d7bfb4ab671f [^]

Fixes ISSUE-55703: Increase the Length of columns grossAmount and grossUnitPrice from 2 to 12

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0168320)
hgbot (developer)
2024-08-21 13:51

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1330 [^]

- Issue History
Date Modified Username Field Change
2024-06-06 11:17 AgatheBertin New Issue
2024-06-06 11:17 AgatheBertin Assigned To => Triage Platform Conn
2024-06-06 11:17 AgatheBertin Triggers an Emergency Pack => No
2024-06-24 16:24 adrianromero Review Assigned To => adrianromero
2024-06-24 16:24 adrianromero Note Added: 0166271
2024-06-24 16:24 adrianromero Status new => closed
2024-06-24 16:24 adrianromero Resolution open => invalid
2024-06-24 16:24 adrianromero File Added: Screenshot from 2024-06-24 16-23-30.png
2024-06-25 08:42 AgatheBertin Note Added: 0166286
2024-06-25 08:42 AgatheBertin Assigned To Triage Platform Conn => Retail
2024-06-25 08:42 AgatheBertin Status closed => new
2024-06-25 08:42 AgatheBertin Resolution invalid => open
2024-06-25 08:43 AgatheBertin File Added: 2024-06-24_16h33_42.png
2024-08-16 08:24 marvintm Status new => acknowledged
2024-08-16 08:26 sreehari Assigned To Retail => sreehari
2024-08-16 08:27 sreehari Status acknowledged => scheduled
2024-08-16 09:24 sreehari File Added: Screenshot 2024-08-16 at 12.53.30 PM.png
2024-08-16 12:03 hgbot Note Added: 0168133
2024-08-21 13:51 hgbot Resolution open => fixed
2024-08-21 13:51 hgbot Status scheduled => closed
2024-08-21 13:51 hgbot Fixed in Version => PR24Q4
2024-08-21 13:51 hgbot Note Added: 0168319
2024-08-21 13:51 hgbot Note Added: 0168320


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker