Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055703Retail ModulesRetail APIpublic2024-06-06 11:172024-08-21 13:51
ReporterAgatheBertin 
Assigned Tosreehari 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055703: API Order - Swagger with wrong format
DescriptionThe swagger for the API Order is telling the lines.grossUnitPrice and lines.grossAmount are : NUMBER 2

I would say the 2 is wrong (should be 12 or 22)
Steps To ReproduceGenerate an order with a big amount of unitPrice, see the number is more than 2 .
Proposed SolutionChange the swagger to add the proper format
===> PLEASE review all the formats for numbers in this API, I may have miss somes.

Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2024-06-24 16-23-30.png (47,217) 2024-06-24 16:24
https://issues.openbravo.com/file_download.php?file_id=19934&type=bug
png

png 2024-06-24_16h33_42.png (19,071) 2024-06-25 08:43
https://issues.openbravo.com/file_download.php?file_id=19936&type=bug
png

png Screenshot 2024-08-16 at 12.53.30 PM.png (50,355) 2024-08-16 09:24
https://issues.openbravo.com/file_download.php?file_id=20093&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-06-06 11:17AgatheBertinNew Issue
2024-06-06 11:17AgatheBertinAssigned To => Triage Platform Conn
2024-06-06 11:17AgatheBertinTriggers an Emergency Pack => No
2024-06-24 16:24adrianromeroReview Assigned To => adrianromero
2024-06-24 16:24adrianromeroNote Added: 0166271
2024-06-24 16:24adrianromeroStatusnew => closed
2024-06-24 16:24adrianromeroResolutionopen => invalid
2024-06-24 16:24adrianromeroFile Added: Screenshot from 2024-06-24 16-23-30.png
2024-06-25 08:42AgatheBertinNote Added: 0166286
2024-06-25 08:42AgatheBertinAssigned ToTriage Platform Conn => Retail
2024-06-25 08:42AgatheBertinStatusclosed => new
2024-06-25 08:42AgatheBertinResolutioninvalid => open
2024-06-25 08:43AgatheBertinFile Added: 2024-06-24_16h33_42.png
2024-08-16 08:24marvintmStatusnew => acknowledged
2024-08-16 08:26sreehariAssigned ToRetail => sreehari
2024-08-16 08:27sreehariStatusacknowledged => scheduled
2024-08-16 09:24sreehariFile Added: Screenshot 2024-08-16 at 12.53.30 PM.png
2024-08-16 12:03hgbotNote Added: 0168133
2024-08-21 13:51hgbotResolutionopen => fixed
2024-08-21 13:51hgbotStatusscheduled => closed
2024-08-21 13:51hgbotFixed in Version => PR24Q4
2024-08-21 13:51hgbotNote Added: 0168319
2024-08-21 13:51hgbotNote Added: 0168320

Notes
(0166271)
adrianromero   
2024-06-24 16:24   
The length displayed by the API is correct. Is the length defined in the table.

See attached screenshot
(0166286)
AgatheBertin   
2024-06-25 08:42   
What is expected here is to review and modify the column definition for that field and maybe others

Because the swagger is telling length 2, but when we export the order, the length can be >2 (see attached)

Endpoint :
/org.openbravo.api.ExportService/Order
(0168133)
hgbot   
2024-08-16 12:03   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1330 [^]
(0168319)
hgbot   
2024-08-21 13:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 65478c4cd7c27ba4c317ddd56215d7bfb4ab671f
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 21-08-2024 11:51:20
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/65478c4cd7c27ba4c317ddd56215d7bfb4ab671f [^]

Fixes ISSUE-55703: Increase the Length of columns grossAmount and grossUnitPrice from 2 to 12

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0168320)
hgbot   
2024-08-21 13:51   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1330 [^]