Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055258 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Retail API | major | always | 2024-04-08 11:14 | 2024-04-23 09:10 | |||
| Reporter | gorkaion | View Status | public | |||||
| Assigned To | Rajesh_18 | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR24Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055258: Consume Coupons API returns a 500 error when the coupon is consumed | |||||||
| Description | When the Coupons API is called with a coupon that it is already consumed the response has 500 status. The expected result is a 2XX status with an error message since the call has not fail technically. | |||||||
| Steps To Reproduce | 1. Create a coupon in backend for a single use. 2. Check using the API that the coupon code is available using /org.openbravo.api.ExportService/Coupon/byCouponCode 3. Consume the coupon using /ws/org.openbravo.retail.discounts.coupons.api.ConsumeCoupon the response is 2XX 4. Check again the coupon and notice the coupon is already used. 5. Try to consume again the coupon using the ConsumeCoupon api, notice that the response is a 500 error. This is wrong, status should be 2XX with a message indicating that the coupon is already expired/consumed/... | |||||||
| Proposed Solution | change the response status to 2XX | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0163559) hgbot (developer) 2024-04-23 08:46 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/merge_requests/16 [^] |
|
(0163569) hgbot (developer) 2024-04-23 09:10 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/merge_requests/16 [^] |
|
(0163570) hgbot (developer) 2024-04-23 09:10 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api [^] Changeset: e385c5c9ca1eef579e7396536d15e33de5b393b1 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 23-04-2024 12:12:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/commit/e385c5c9ca1eef579e7396536d15e33de5b393b1 [^] Fixed ISSUE-55258: Catched OBException and returned the response status as 200 --- M src/org/openbravo/retail/discounts/coupons/api/service/ConsumeCoupon.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-04-19 08:12 | marvintm | Type | defect => backport |
| 2024-04-19 08:12 | marvintm | Target Version | => RR24Q2 |
| 2024-04-23 08:46 | hgbot | Note Added: 0163559 | |
| 2024-04-23 09:10 | hgbot | Note Added: 0163569 | |
| 2024-04-23 09:10 | hgbot | Resolution | open => fixed |
| 2024-04-23 09:10 | hgbot | Status | scheduled => closed |
| 2024-04-23 09:10 | hgbot | Note Added: 0163570 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |