0055244: API Discount : Error when importing promotion "Buy X pay Y of different product"

Description

When importing json from discount API whit a promotion type Buy X pay Y of different product, the EDL request is in error with this message :

Error while importing an item: class java.lang.Integer cannot be cast to class java.lang.Long (java.lang.Integer and java.lang.Long are in module java.base of loader 'bootstrap')

Steps To Reproduce

Integrate the following json through the Promotion API

{"client":"XXXXX","organization":"*","name":"TESTABEMANTIS","discountAmount":0,"discountPercentage":5,"startingDate":"2024-02-01","includedBusinessPartners":"Y","includedBPCategories":"Y","includedProducts":"Y","includedProductCategories":"Y","includedOrganizations":"Y","includePriceLists":"Y","includedCharacteristics":"Y","includedRoles":"Y","excludedCharacteristics":"A","includedExternalBusinessPartners":"Y","discountType":"Buy X pay Y of different product","applyNextDiscount":true,"priceAdjustmentScope":"A","priceAdjustmentType":"P","priceAdjustmentAmount":0,"priceAdjustmentPercentage":0,"xUnits":10,"yUnits":9,"minX":9,"maxX":10,"distributeBetweenLines":false,"percentage":10,"approvalRequired":false,"allowMultipleInstances":false,"applyAfterAutomaticDiscounts":false,"allowInNegativeLines":false,"allowIncreaseLinePrice":true,"totalReceiptAmount":100,"totalPercentageDiscount":15,"isCoupon":false,"buyXGiftYSubtype":"BUYALLXGIFTALLY","applyOnce":false,"applicationMethod":"discretionary","verifyPriceLimit":true,"isOTFCoupon":false,"otfApplyMinCouponAmount":false,"applyToProductsUpToTheMaxQuantity":false,"applyMinCouponAmount":false,"organizations":[],"priceLists":[],"products":[],"productCategories":[],"incompatibleDiscounts":[],"availability":[],"businessPartnerCategories":[],"businessPartnerSets":[],"characteristics":[],"crmPropertyConditions":[],"freeProducts":[],"comboFamilies":[],"priceScales":[],"loyaltyPrograms":[]}

Proposed Solution

After first analysis this error seems related to the fields xUnit and yUnit

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0054806

closed

Rajesh_18

API Discount : Error when importing promotion "Buy X pay Y of different product"

Notes
(0163434) hgbot (developer) 2024-04-19 07:58	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/259 [^]

(0163436) hgbot (developer) 2024-04-19 08:11	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: c443535be8e74f6f950190807ae51b35e75d0088 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 19-04-2024 11:26:06 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/c443535be8e74f6f950190807ae51b35e75d0088 [^] Fixed ISSUE-55244: Removed xUnits as they are present in different module --- M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml ---

(0163437) hgbot (developer) 2024-04-19 08:11	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/259 [^]

Issue History
Date Modified	Username	Field	Change
2024-04-18 13:25	Rajesh_18	Type	defect => backport
2024-04-18 13:25	Rajesh_18	Target Version	=> RR24Q2
2024-04-19 07:58	hgbot	Note Added: 0163434
2024-04-19 08:11	hgbot	Resolution	open => fixed
2024-04-19 08:11	hgbot	Status	scheduled => closed
2024-04-19 08:11	hgbot	Note Added: 0163436
2024-04-19 08:11	hgbot	Note Added: 0163437