Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055168 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Discounts and Promotions | major | have not tried | 2024-04-11 12:04 | 2024-05-15 13:25 | |||
| Reporter | aferraz | View Status | public | |||||
| Assigned To | SABARINATH P | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR24Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | main | |||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/c4794102728f708c7dd22656d571c8f151a0db26 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055168: Wrong call to OB.App.State.UI.Utils.showProductSearchKey from discount engine | |||||||
| Description | Discount engine is a pure function that should work from EnyoPOS, ReactPOS and WebService. It can not use APIs that are not included in the discount engine. | |||||||
| Steps To Reproduce | * | |||||||
| Proposed Solution | The way to fix this would be as follows: 1.-A new utils function should be implemented in org.openbravo.retail.discounts. This new function should be returning the productIdentifier 2.-In POS2 module, the utils function defined in org.openbravo.retail.discounts should be overwritten to return the line that is causing the error The reason behind this approach is that the new property to activate/deactivate the functionality exists only in POS2 and thus should only be available in an environment where POS2 exists. For any doubt please contact JWE | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0163246) hgbot (developer) 2024-04-16 08:44 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/142 [^] |
|
(0163292) hgbot (developer) 2024-04-16 15:38 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2570 [^] |
|
(0164661) hgbot (developer) 2024-05-15 13:25 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: d677b335851ef7eec5943a0c60865c880c3114af Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com> Date: 15-05-2024 11:24:40 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d677b335851ef7eec5943a0c60865c880c3114af [^] Fixed ISSUE-55168: Overwritten productSearchKey() on retail.discounts --- M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js --- |
|
(0164662) hgbot (developer) 2024-05-15 13:25 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2570 [^] |
|
(0164663) hgbot (developer) 2024-05-15 13:25 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/142 [^] |
|
(0164664) hgbot (developer) 2024-05-15 13:25 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 59b2f8c0168a9e3aa794b4610cce853fd16f8801 Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com> Date: 15-05-2024 11:24:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/59b2f8c0168a9e3aa794b4610cce853fd16f8801 [^] Fixed ISSUE-55168: Created util function that returns product searchkey/name --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-free-item-discount.js M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-04-11 12:04 | aferraz | New Issue | |
| 2024-04-11 12:04 | aferraz | Assigned To | => Retail |
| 2024-04-11 12:04 | aferraz | OBNetwork customer | => No |
| 2024-04-11 12:04 | aferraz | Triggers an Emergency Pack | => No |
| 2024-04-11 12:35 | aferraz | Relationship added | caused by 0054484 |
| 2024-04-11 12:37 | aferraz | Regression introduced in release | => main |
| 2024-04-11 12:37 | aferraz | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/c4794102728f708c7dd22656d571c8f151a0db26 [^] |
| 2024-04-11 12:42 | jorgewederago | Proposed Solution updated | |
| 2024-04-11 12:42 | jorgewederago | Status | new => acknowledged |
| 2024-04-12 07:43 | SABARINATH P | Assigned To | Retail => SABARINATH P |
| 2024-04-12 07:43 | SABARINATH P | Status | acknowledged => scheduled |
| 2024-04-16 08:44 | hgbot | Merge Request Status | => open |
| 2024-04-16 08:44 | hgbot | Note Added: 0163246 | |
| 2024-04-16 15:38 | hgbot | Note Added: 0163292 | |
| 2024-05-15 13:25 | hgbot | Merge Request Status | open => approved |
| 2024-05-15 13:25 | hgbot | Resolution | open => fixed |
| 2024-05-15 13:25 | hgbot | Status | scheduled => closed |
| 2024-05-15 13:25 | hgbot | Fixed in Version | => 24Q3 |
| 2024-05-15 13:25 | hgbot | Note Added: 0164661 | |
| 2024-05-15 13:25 | hgbot | Note Added: 0164662 | |
| 2024-05-15 13:25 | hgbot | Note Added: 0164663 | |
| 2024-05-15 13:25 | hgbot | Fixed in Version | 24Q3 => RR24Q3 |
| 2024-05-15 13:25 | hgbot | Note Added: 0164664 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |