Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0055168 | Retail Modules | Discounts and Promotions | public | 2024-04-11 12:04 | 2024-05-15 13:25 |
|
| Reporter | aferraz | |
| Assigned To | SABARINATH P | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR24Q3 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | main |
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/c4794102728f708c7dd22656d571c8f151a0db26 [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0055168: Wrong call to OB.App.State.UI.Utils.showProductSearchKey from discount engine |
| Description | Discount engine is a pure function that should work from EnyoPOS, ReactPOS and WebService.
It can not use APIs that are not included in the discount engine. |
| Steps To Reproduce | * |
| Proposed Solution | The way to fix this would be as follows:
1.-A new utils function should be implemented in org.openbravo.retail.discounts. This new function should be returning the productIdentifier
2.-In POS2 module, the utils function defined in org.openbravo.retail.discounts should be overwritten to return the line that is causing the error
The reason behind this approach is that the new property to activate/deactivate the functionality exists only in POS2 and thus should only be available in an environment where POS2 exists.
For any doubt please contact JWE |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | caused by | feature request | 0054484 | | closed | inaki_luque | Web POS display Product Search key |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-04-11 12:04 | aferraz | New Issue | |
| 2024-04-11 12:04 | aferraz | Assigned To | => Retail |
| 2024-04-11 12:04 | aferraz | Triggers an Emergency Pack | => No |
| 2024-04-11 12:35 | aferraz | Relationship added | caused by 0054484 |
| 2024-04-11 12:37 | aferraz | Regression introduced in release | => main |
| 2024-04-11 12:37 | aferraz | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/c4794102728f708c7dd22656d571c8f151a0db26 [^] |
| 2024-04-11 12:42 | jorgewederago | Proposed Solution updated | |
| 2024-04-11 12:42 | jorgewederago | Status | new => acknowledged |
| 2024-04-12 07:43 | SABARINATH P | Assigned To | Retail => SABARINATH P |
| 2024-04-12 07:43 | SABARINATH P | Status | acknowledged => scheduled |
| 2024-04-16 08:44 | hgbot | Note Added: 0163246 | |
| 2024-04-16 15:38 | hgbot | Note Added: 0163292 | |
| 2024-05-15 13:25 | hgbot | Resolution | open => fixed |
| 2024-05-15 13:25 | hgbot | Status | scheduled => closed |
| 2024-05-15 13:25 | hgbot | Fixed in Version | => 24Q3 |
| 2024-05-15 13:25 | hgbot | Note Added: 0164661 | |
| 2024-05-15 13:25 | hgbot | Note Added: 0164662 | |
| 2024-05-15 13:25 | hgbot | Note Added: 0164663 | |
| 2024-05-15 13:25 | hgbot | Fixed in Version | 24Q3 => RR24Q3 |
| 2024-05-15 13:25 | hgbot | Note Added: 0164664 | |
|
Notes |
|
|
(0163246)
|
|
hgbot
|
|
2024-04-16 08:44
|
|
|
|
|
(0163292)
|
|
hgbot
|
|
2024-04-16 15:38
|
|
|
|
|
(0164661)
|
|
hgbot
|
|
2024-05-15 13:25
|
|
|
|
|
(0164662)
|
|
hgbot
|
|
2024-05-15 13:25
|
|
|
|
|
(0164663)
|
|
hgbot
|
|
2024-05-15 13:25
|
|
|
|
|
(0164664)
|
|
hgbot
|
|
2024-05-15 13:25
|
|
|