Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0005516
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2008-10-13 18:372009-10-26 05:40
ReporterelopioView Statuspublic 
Assigned Toiperdomo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisiond65c011967fe
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.40SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0005516: Two tables with same Id

DescriptionData tables on ERP have 'grid_table' as Id, but they are inside a table element that has the same id.

This happens on the grid view and on the selector popups.

<!-- FIRST -->
<table id="grid_table" class="Main_Client_TableRelation" cellspacing="0" cellpadding="0" border="0" width="100%">
<tbody>
<tr>
<td>
<div style="height: 80px; width: 964px;">
<div id="grid_container_old1" style="display: none;"/>
<div id="grid_container">
<div id="grid_viewPort" style="float: left; overflow-x: auto;
overflow-y: hidden; width: 924px; height: 120px;">
<table id="grid_table_header" class="DataGrid_Header_Table" style="width: 807px;">

</table>

<!-- SECOND -->
<table id="grid_table" class="DataGrid_Body_Table" style="width: 807px;
height: 20px;">

</table>
</div>
Steps To ReproduceLog In
Go to the grid view of any form window
---------
Log In
Go to Master Data Management || Product
click new
click Storage bin selector
Proposed SolutionChange the id of one of the tables.
Tags250MP8, main
Attached Fileslog file icon grep.log [^] (85,380 bytes) 2009-01-13 14:14
png file icon grid_table.png [^] (83,522 bytes) 2009-10-02 05:39


html file icon PeriodControl_Relation.html [^] (31,492 bytes) 2009-10-02 07:46

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0011201 closeddbaz Table in grid view has "undefined_table" as id 

-  Notes
(0009640)
psarobe (manager)
2008-10-20 10:55

It has high priority because of Automation testing
(0012145)
iperdomo (reporter)
2009-01-13 14:16

Attached you'll find a grep.log that is the number of occurrences of the line id="grid_table" in a file.

You can check it with the following command:
grep -nrH 'id=\"grid_table\"' . | awk -F : '{print $1}' | sort | uniq -c
(0012146)
iperdomo (reporter)
2009-01-13 14:20

I couldn't find a duplicated id="grid_table" in all the code base.
I tested the 'Storage Bin' with firebug:

>>> document.getElementById('grid_table')
<table id="grid_table" class="Main_Client_TableRelation" cellspacing="0" cellpadding="0" border="0" width="100%">

Only returned 1 table element

Thanks,
(0020644)
elopio (reporter)
2009-10-02 05:38

Reopened this issue because I still can reproduce it.
Firebug returns only one element, but there are two.

I'll attach the image of Financial Management || Accounting || Setup || Fiscal Calendar || Calendar >> Year >> Period >> Period Control so you can see it.

This is one yesterday's installation of 2.40 on QA servers.

thanks,
pura vida.
(0020645)
iperdomo (reporter)
2009-10-02 07:47

Hi,
Attached you'll find the html code of that tab in grid mode.

Please run the grep command (in the notes) to count the number of grid_table string per file.

I'm using 2.40:
$ hg id
70a2052426b1 tip
(0020679)
plujan (manager)
2009-10-02 17:46

Reopening the issue and raising both priority and severity since it blocks development of automated scripts.

Ivan, note that static html reading will not reveal the second table since it is filled using a dojo function. If you use Firebug, you will see that table object with class Main_Client_TableRelation and table object with class DataGridBody_Table share the same id, "grid_table"

If you are still unable to reproduce it, Leo or I could show you what is the problem.
(0020682)
hgbot (developer)
2009-10-02 20:03

Repository: erp/stable/2.40
Changeset: d65c011967fe51caf73c6549c49844ff1c43a8ed
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Oct 02 20:02:22 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/d65c011967fe51caf73c6549c49844ff1c43a8ed [^]

Fixes issue 5516: Renamed id attribute of table containing the grid

---
M src-wad/src/org/openbravo/wad/controls/WADGrid.java
---

- Issue History
Date Modified Username Field Change
2008-10-13 18:37 elopio New Issue
2008-10-13 18:37 elopio Assigned To => cromero
2008-10-13 18:37 elopio sf_bug_id 0 => 2164012
2008-10-13 18:37 elopio Regression testing => No
2008-10-20 10:55 psarobe Status new => scheduled
2008-10-20 10:55 psarobe Note Added: 0009640
2008-10-20 10:55 psarobe Assigned To cromero => alostale
2008-10-20 10:55 psarobe fix_in_branch => trunk
2008-12-10 09:56 alostale Assigned To alostale => iperdomo
2009-01-13 14:14 iperdomo File Added: grep.log
2009-01-13 14:16 iperdomo Note Added: 0012145
2009-01-13 14:20 iperdomo Status scheduled => closed
2009-01-13 14:20 iperdomo Note Added: 0012146
2009-01-13 14:20 iperdomo Resolution open => unable to reproduce
2009-10-02 05:38 elopio Status closed => new
2009-10-02 05:38 elopio Resolution unable to reproduce => open
2009-10-02 05:38 elopio Note Added: 0020644
2009-10-02 05:39 elopio File Added: grid_table.png
2009-10-02 07:46 iperdomo File Added: PeriodControl_Relation.html
2009-10-02 07:47 iperdomo Status new => closed
2009-10-02 07:47 iperdomo Note Added: 0020645
2009-10-02 07:47 iperdomo Resolution open => unable to reproduce
2009-10-02 17:46 plujan Note Added: 0020679
2009-10-02 17:46 plujan Priority high => urgent
2009-10-02 17:46 plujan Severity minor => major
2009-10-02 17:46 plujan Status closed => new
2009-10-02 17:46 plujan Resolution unable to reproduce => open
2009-10-02 17:46 plujan Category B. User interface => A. Platform
2009-10-02 17:46 plujan fix_in_branch pi =>
2009-10-02 17:46 plujan Status new => scheduled
2009-10-02 17:46 plujan fix_in_branch => pi
2009-10-02 20:03 hgbot Checkin
2009-10-02 20:03 hgbot Note Added: 0020682
2009-10-02 20:03 hgbot Status scheduled => resolved
2009-10-02 20:03 hgbot Resolution open => fixed
2009-10-02 20:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/d65c011967fe51caf73c6549c49844ff1c43a8ed [^]
2009-10-22 19:26 psarobe Tag Attached: main
2009-10-22 19:33 psarobe Tag Attached: 250MP8
2009-10-26 05:40 elopio Status resolved => closed
2009-10-31 03:01 elopio Relationship added related to 0011201


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker