Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055049 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | have not tried | 2024-03-25 17:33 | 2024-03-26 00:50 | |||
| Reporter | NaroaIriarte | View Status | public | |||||
| Assigned To | NaroaIriarte | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 24Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055049: When a field validation was done, the message was not properly handled in some situations. | |||||||
| Description | If a field was validated with the validator engine, the error message was correctly shown but when a second validation was done by the super, the message was missing. The problem was that the validators were sending two arguments, the message and the parameters that were mainly used as parameters to improve said message. The validator engine, needs to send the property name that is being validated. The needed fix is to add an extra argument to prevent from loosing information when the validations are done. | |||||||
| Steps To Reproduce | . | |||||||
| Proposed Solution | New logic has been added to the validateRequiredField function of the FormHandler.js. This way, it sends not only parameters and message, but also the field name as 'propertyName' which is needed now. Other logic has been fixed too in the validateField function of the CustomerMultiTabDialogFormHandler file to show the messages properly. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0162614) hgbot (developer) 2024-03-25 19:22 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2525 [^] |
|
(0162615) hgbot (developer) 2024-03-25 19:24 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1432 [^] |
|
(0162618) hgbot (developer) 2024-03-26 00:50 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 4fc57945a3408a92a2f11d7b93b35fed4dc50cfd Author: Naroa Iriarte <n.iriarte@orisha.com> Date: 25-03-2024 23:50:18 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4fc57945a3408a92a2f11d7b93b35fed4dc50cfd [^] related to ISSUE-55049: Respone for simple validator is adapted to work together with validation engine --- M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialogForm/CustomerMultiTabDialogFormHandler.js --- |
|
(0162619) hgbot (developer) 2024-03-26 00:50 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2525 [^] |
|
(0162620) hgbot (developer) 2024-03-26 00:50 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1432 [^] |
|
(0162621) hgbot (developer) 2024-03-26 00:50 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 7d13e15112e623898269282d266d3ec0a2d2b8fe Author: Naroa Iriarte <n.iriarte@orisha.com> Date: 25-03-2024 23:50:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/7d13e15112e623898269282d266d3ec0a2d2b8fe [^] fixed ISSUE-55049: Added property name to simple validator response --- M web-jspack/org.openbravo.core2/src/components/Form/FormHandler.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-03-25 17:33 | NaroaIriarte | New Issue | |
| 2024-03-25 17:33 | NaroaIriarte | Assigned To | => Retail |
| 2024-03-25 17:33 | NaroaIriarte | Triggers an Emergency Pack | => No |
| 2024-03-25 17:33 | NaroaIriarte | Assigned To | Retail => NaroaIriarte |
| 2024-03-25 17:33 | NaroaIriarte | Status | new => acknowledged |
| 2024-03-25 17:33 | NaroaIriarte | Status | acknowledged => scheduled |
| 2024-03-25 19:22 | hgbot | Note Added: 0162614 | |
| 2024-03-25 19:24 | hgbot | Note Added: 0162615 | |
| 2024-03-25 19:30 | NaroaIriarte | Description Updated | View Revisions |
| 2024-03-26 00:50 | hgbot | Note Added: 0162618 | |
| 2024-03-26 00:50 | hgbot | Note Added: 0162619 | |
| 2024-03-26 00:50 | hgbot | Resolution | open => fixed |
| 2024-03-26 00:50 | hgbot | Status | scheduled => closed |
| 2024-03-26 00:50 | hgbot | Fixed in Version | => 24Q2 |
| 2024-03-26 00:50 | hgbot | Note Added: 0162620 | |
| 2024-03-26 00:50 | hgbot | Note Added: 0162621 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |