Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0055041
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2024-03-22 15:172024-05-21 06:09
Reporterphilippe_muiView Statuspublic 
Assigned ToRajesh_18 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0055041: RM-11320 - [PROMO] Coupons OTF Generation Rules, validity dates can be configured wrongly without error message

DescriptionWhen configuring the validity date for an OTF Coupon, it is possible to configure the Valid from/to in Days or Month.

If we configure an ending date smaller than a starting date, we can save it when we shouldn’t.

The consequence is that a sale applying this OTF rule goes to Error While Importing

https://openbravo.atlassian.net/browse/RM-11320 [^]
Steps To Reproduce1. Go to the backoffice and create a promotion in “Discount and promotion”

2. Check the “Uses coupon code” box

3. Check the “Is OTF” box

4. Go to the OTF Generation rule window and create an OTF linked to the previously created promotion

5. In the valid from, add Days = 5. In the valid to, add Days = 3.

6. that a sale applying this OTF rule goes to Error While Importing


6. In the POS, add eligible product to trigger to OTF coupon.

7. In the ticket, the dates are as in the example in attachment.
Proposed SolutionWe must block the validation of the validity when :

Valid from/valid to in Days : starting date < ending date

Valid from/valid to in Months : starting date < ending date

Valid from (Month) > Valid to (Days)
TagsFASH
Attached Filespng file icon 2024-03-22_15h16_27.png [^] (94,852 bytes) 2024-03-22 15:17

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0054466 closedRajesh_18 Retail Modules [PROMO] Coupons OTF Generation Rules, validity dates can be configured wrongly without error message 
related to defect 0054523 closedRajesh_18 Retail Modules [PROMO] Coupons - validity dates can be excluded from the promotion dates and it generates EWI 

-  Notes
(0164795)
hgbot (developer)
2024-05-20 11:34

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/55 [^]
(0164870)
hgbot (developer)
2024-05-21 06:09

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: c51e548d14e34f8ad058804e5d8319158d940148
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 20-05-2024 12:07:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/c51e548d14e34f8ad058804e5d8319158d940148 [^]

Fixed ISSUE-55041: Added validation for valid from and to date

---
M src/org/openbravo/retail/discounts/coupons/otf/event/CouponrulesEventHandler.java
---
(0164871)
hgbot (developer)
2024-05-21 06:09

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/55 [^]

- Issue History
Date Modified Username Field Change
2024-03-22 15:17 philippe_mui New Issue
2024-03-22 15:17 philippe_mui Assigned To => Triage Omni OMS
2024-03-22 15:17 philippe_mui File Added: 2024-03-22_15h16_27.png
2024-03-22 15:17 philippe_mui Modules => Core
2024-03-22 15:17 philippe_mui Triggers an Emergency Pack => No
2024-03-22 16:08 philippe_mui Tag Attached: FASH
2024-03-24 23:08 rafaroda Description Updated View Revisions
2024-03-24 23:08 rafaroda Steps to Reproduce Updated View Revisions
2024-03-24 23:09 rafaroda Relationship added related to 0054466
2024-03-24 23:09 rafaroda Relationship added related to 0054523
2024-03-25 09:06 marvintm Assigned To Triage Omni OMS => Retail
2024-05-19 09:28 guillermogil Status new => acknowledged
2024-05-20 07:08 Rajesh_18 Assigned To Retail => Rajesh_18
2024-05-20 07:08 Rajesh_18 Status acknowledged => scheduled
2024-05-20 11:34 hgbot Note Added: 0164795
2024-05-21 06:09 hgbot Resolution open => fixed
2024-05-21 06:09 hgbot Status scheduled => closed
2024-05-21 06:09 hgbot Note Added: 0164870
2024-05-21 06:09 hgbot Note Added: 0164871


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker