Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0055041Openbravo ERP07. Sales managementpublic2024-03-22 15:172024-05-21 06:09
philippe_mui 
Rajesh_18 
highmajoralways
closedfixed 
5
 
 
Core
No
0055041: RM-11320 - [PROMO] Coupons OTF Generation Rules, validity dates can be configured wrongly without error message
When configuring the validity date for an OTF Coupon, it is possible to configure the Valid from/to in Days or Month.

If we configure an ending date smaller than a starting date, we can save it when we shouldn’t.

The consequence is that a sale applying this OTF rule goes to Error While Importing

https://openbravo.atlassian.net/browse/RM-11320 [^]
1. Go to the backoffice and create a promotion in “Discount and promotion”

2. Check the “Uses coupon code” box

3. Check the “Is OTF” box

4. Go to the OTF Generation rule window and create an OTF linked to the previously created promotion

5. In the valid from, add Days = 5. In the valid to, add Days = 3.

6. that a sale applying this OTF rule goes to Error While Importing


6. In the POS, add eligible product to trigger to OTF coupon.

7. In the ticket, the dates are as in the example in attachment.
We must block the validation of the validity when :

Valid from/valid to in Days : starting date < ending date

Valid from/valid to in Months : starting date < ending date

Valid from (Month) > Valid to (Days)
FASH
related to defect 0054466 closed Rajesh_18 Retail Modules [PROMO] Coupons OTF Generation Rules, validity dates can be configured wrongly without error message 
related to defect 0054523 closed Rajesh_18 Retail Modules [PROMO] Coupons - validity dates can be excluded from the promotion dates and it generates EWI 
png 2024-03-22_15h16_27.png (94,852) 2024-03-22 15:17
https://issues.openbravo.com/file_download.php?file_id=19582&type=bug
png
Issue History
2024-03-22 15:17philippe_muiNew Issue
2024-03-22 15:17philippe_muiAssigned To => Triage Omni OMS
2024-03-22 15:17philippe_muiFile Added: 2024-03-22_15h16_27.png
2024-03-22 15:17philippe_muiModules => Core
2024-03-22 15:17philippe_muiTriggers an Emergency Pack => No
2024-03-22 16:08philippe_muiTag Attached: FASH
2024-03-24 23:08rafarodaDescription Updatedbug_revision_view_page.php?rev_id=27729#r27729
2024-03-24 23:08rafarodaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27731#r27731
2024-03-24 23:09rafarodaRelationship addedrelated to 0054466
2024-03-24 23:09rafarodaRelationship addedrelated to 0054523
2024-03-25 09:06marvintmAssigned ToTriage Omni OMS => Retail
2024-05-19 09:28guillermogilStatusnew => acknowledged
2024-05-20 07:08Rajesh_18Assigned ToRetail => Rajesh_18
2024-05-20 07:08Rajesh_18Statusacknowledged => scheduled
2024-05-20 11:34hgbotNote Added: 0164795
2024-05-21 06:09hgbotResolutionopen => fixed
2024-05-21 06:09hgbotStatusscheduled => closed
2024-05-21 06:09hgbotNote Added: 0164870
2024-05-21 06:09hgbotNote Added: 0164871

Notes
(0164795)
hgbot   
2024-05-20 11:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/55 [^]
(0164870)
hgbot   
2024-05-21 06:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: c51e548d14e34f8ad058804e5d8319158d940148
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 20-05-2024 12:07:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/c51e548d14e34f8ad058804e5d8319158d940148 [^]

Fixed ISSUE-55041: Added validation for valid from and to date

---
M src/org/openbravo/retail/discounts/coupons/otf/event/CouponrulesEventHandler.java
---
(0164871)
hgbot   
2024-05-21 06:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/55 [^]