Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0055037
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2024-03-22 12:132024-03-27 11:54
ReportershuehnerView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0055037: mobile-test: PaymentRoundingSuiteHV does not run HighVol module => so just duplicate non-HV to remove

DescriptionThe PaymentRoundingSuiteHV from the name should run the tests from the PaymentRoundingSuite (non-HV) suite with having HighVolume mode activated.

But that's broken from it's addition in 20202 as points to the wrong suiteClasses:
- AllPaymentRoundingTests
instead of the correct
- AllPaymentRoundingTestsHV

That means that the PaymentRoundingSuiteHV is just run the non-HV a 2nd time which is not very useful
Steps To ReproduceLook at artifact suiteLikeTestList.log of a try-ret-test-pgsql-suite6 job (i.e. nightly)

Example link:
https://builds.openbravo.com/job/try-ret-test-pgsql-suite6/8387/artifact/SANDBOX/automation/mobile-test/last-results/try-ret-test-pgsql-suite6/logs/suiteLikeTestList.log [^]

Search for PaymentRounding and notice that both blocks found have each marked with noHighvolume

PaymentRoundingDecreaseTotalAmount.class, // 2024-03-21T02:06:47 pass isFirst noHighVolume
PaymentRoundingIncreaseTotalAmount.class, // 2024-03-21T02:07:18 pass noFirst noHighVolume
PaymentRoundingPartialPayment.class, // 2024-03-21T02:07:50 pass noFirst noHighVolume
PaymentRoundingReturnCardPayment.class, // 2024-03-21T02:08:26 pass noFirst noHighVolume
PaymentRoundingReturnChangePayment.class, // 2024-03-21T02:09:02 pass noFirst noHighVolume
PaymentRoundingReturnPartialPayment.class, // 2024-03-21T02:09:41 pass noFirst noHighVolume
PaymentRoundingReturnPositivePayment.class, // 2024-03-21T02:10:15 pass noFirst noHighVolume
PaymentRoundingReturnReversePayment.class, // 2024-03-21T02:10:59 pass noFirst noHighVolume
PaymentRoundingReturnReversePayment2.class, // 2024-03-21T02:11:44 pass noFirst noHighVolume
PaymentRoundingReturnTotalPayment.class, // 2024-03-21T02:12:20 pass noFirst noHighVolume
PaymentRoundingReversePayment.class, // 2024-03-21T02:12:55 pass noFirst noHighVolume
PaymentRoundingReversePayment2.class, // 2024-03-21T02:13:32 pass noFirst noHighVolume
PaymentRoundingTotalPayment.class, // 2024-03-21T02:14:00 pass noFirst noHighVolume

PaymentRoundingDecreaseTotalAmount.class, // 2024-03-21T02:15:06 pass isFirst noHighVolume
PaymentRoundingIncreaseTotalAmount.class, // 2024-03-21T02:15:37 pass noFirst noHighVolume
PaymentRoundingPartialPayment.class, // 2024-03-21T02:16:10 pass noFirst noHighVolume
PaymentRoundingReturnCardPayment.class, // 2024-03-21T02:16:52 pass noFirst noHighVolume
PaymentRoundingReturnChangePayment.class, // 2024-03-21T02:17:31 pass noFirst noHighVolume
PaymentRoundingReturnPartialPayment.class, // 2024-03-21T02:18:14 pass noFirst noHighVolume
PaymentRoundingReturnPositivePayment.class, // 2024-03-21T02:18:51 pass noFirst noHighVolume
PaymentRoundingReturnReversePayment.class, // 2024-03-21T02:19:40 pass noFirst noHighVolume
PaymentRoundingReturnReversePayment2.class, // 2024-03-21T02:20:25 pass noFirst noHighVolume
PaymentRoundingReturnTotalPayment.class, // 2024-03-21T02:21:02 pass noFirst noHighVolume
PaymentRoundingReversePayment.class, // 2024-03-21T02:21:41 pass noFirst noHighVolume
PaymentRoundingReversePayment2.class, // 2024-03-21T02:22:22 pass noFirst noHighVolume
PaymentRoundingTotalPayment.class, // 2024-03-21T02:22:52 pass noFirst noHighVolume
Proposed SolutionDelete the PaymentRoundingSuiteHV as not doing anything useful.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0162548)
hgbot (developer)
2024-03-22 12:18

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/381 [^]
(0162697)
hgbot (developer)
2024-03-27 11:54

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: e8572679af516962fa07fae75ad4df493cc599a5
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 26-03-2024 12:00:27
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/e8572679af516962fa07fae75ad4df493cc599a5 [^]

Fixed ISSUE-55037: Delete useless PaymentRoundingSuiteHV

PaymentRoundingSuiteHV suite wrongly used AllPaymentRoundingTests
(non-HV) instead of the correct AllPaymentRoundingTestsHV.
That means it just ran non-HV tests a 2nd time.
That bug existed since adding the class in 2020.

Remove the HV suite to avoid the double runtime for nothing (ca. 8min)

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/concurrent/job016/PaymentRoundingSuiteHV.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/paymentrounding/AllPaymentRoundingTestsHV.java
---
(0162698)
hgbot (developer)
2024-03-27 11:54

 Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/381 [^]

- Issue History
Date Modified Username Field Change
2024-03-22 12:13 shuehner New Issue
2024-03-22 12:13 shuehner Assigned To => Retail
2024-03-22 12:13 shuehner Triggers an Emergency Pack => No
2024-03-22 12:18 hgbot Note Added: 0162548
2024-03-27 11:54 hgbot Resolution open => fixed
2024-03-27 11:54 hgbot Status new => closed
2024-03-27 11:54 hgbot Note Added: 0162697
2024-03-27 11:54 hgbot Note Added: 0162698

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker