Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055030 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] E. Translation | major | always | 2024-03-21 17:42 | 2024-04-18 13:29 | |||
| Reporter | hector_hernaez | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | PR24Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055030: Error when opening the Message window after checking the 'Show translation tabs' checkbox in Session Preferences | |||||||
| Description | When the checkbox 'Show translation tabs' in Session Preferences window is unchecked or checked (depends on the status of the xheckbox) and a window that uses that checkbox is opened, it remains in loading and an error appears in console with this message: Uncaught TypeError: Cannot read properties of null (reading 'tabs') at _2.addChildView (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29539:26 [^]) at _2.createViewStructure (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:2:7097) at _2.buildStructure (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29047:10 [^]) at _2.initWidget (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:28862:12 [^]) at _2.isc_c_Class_invokeSuper [as invokeSuper] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:245:93 [^]) at _2.isc_c_Class_Super [as Super] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:237:170 [^]) at _2.initWidget (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:4:432) at _2.isc_Canvas_init [as init] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:1657:6 [^]) at _2.isc_Class_completeCreation [as completeCreation] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:287:6 [^]) at _2.isc_c_Class_create (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:182:1891 [^]) | |||||||
| Steps To Reproduce | Reproduced in livebuilds retail with modules and in DKT client. Steps in the video attached reproducing it in pi. Make sure no modules are in development. Clear the cache to ensure no precached window is used. As System Admin: - Uncheck checkbox 'Show Translations tab' in Session Preferences - Open Messages window. Close it - Check checkbox 'Show Translations tab' in Session Preferences - Open Messages window. It will fail with the console error mentioned above | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0162513) hector_hernaez (developer) 2024-03-21 17:43 edited on: 2024-03-21 17:43 |
Will have to be backported to https://gitlab.com/openbravo/customers/DKT/pi_19q3/-/tree/Ticket_82354?ref_type=heads [^] |
|
(0162514) AugustoMauch (manager) 2024-03-21 18:23 |
Problem: hasChildTabs is only executed once, not every time the window is open: hasChildTabs: (OB.PropertyStore.get('ShowTrl', this.windowId) === 'Y'), https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl?ref_type=heads#L163 [^] |
|
(0163189) hgbot (developer) 2024-04-15 10:57 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1199 [^] |
|
(0163384) hgbot (developer) 2024-04-18 13:29 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 93641bed9791273f828e82b25031800d01bbf0b5 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 18-04-2024 11:29:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/93641bed9791273f828e82b25031800d01bbf0b5 [^] Fixes ISSUE-55030: Prevents error when tab does not have a childTabSet Now, before adding a new child tab to a childTabSet, we check if the childTabSet is null, and if so we create it and make it visible --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0163385) hgbot (developer) 2024-04-18 13:29 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1199 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-03-21 17:42 | hector_hernaez | New Issue | |
| 2024-03-21 17:42 | hector_hernaez | Assigned To | => AugustoMauch |
| 2024-03-21 17:42 | hector_hernaez | Modules | => Core |
| 2024-03-21 17:42 | hector_hernaez | Triggers an Emergency Pack | => No |
| 2024-03-21 17:42 | hector_hernaez | Issue generated from | 0054878 |
| 2024-03-21 17:43 | hector_hernaez | Note Added: 0162513 | |
| 2024-03-21 17:43 | hector_hernaez | Note Edited: 0162513 | View Revisions |
| 2024-03-21 18:23 | AugustoMauch | Note Added: 0162514 | |
| 2024-03-21 23:19 | AugustoMauch | Status | new => acknowledged |
| 2024-04-15 10:55 | AugustoMauch | Steps to Reproduce Updated | View Revisions |
| 2024-04-15 10:57 | hgbot | Note Added: 0163189 | |
| 2024-04-15 17:39 | AugustoMauch | Status | acknowledged => scheduled |
| 2024-04-18 13:29 | hgbot | Resolution | open => fixed |
| 2024-04-18 13:29 | hgbot | Status | scheduled => closed |
| 2024-04-18 13:29 | hgbot | Fixed in Version | => PR24Q3 |
| 2024-04-18 13:29 | hgbot | Note Added: 0163384 | |
| 2024-04-18 13:29 | hgbot | Note Added: 0163385 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |