Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055030Openbravo ERPE. Translationpublic2024-03-21 17:422024-04-18 13:29
Reporterhector_hernaez 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionPR24Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Web browser
ModulesCore
Support ticket82354
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055030: Error when opening the Message window after checking the 'Show translation tabs' checkbox in Session Preferences
DescriptionWhen the checkbox 'Show translation tabs' in Session Preferences window is unchecked or checked (depends on the status of the xheckbox) and a window that uses that checkbox is opened, it remains in loading and an error appears in console with this message:

Uncaught TypeError: Cannot read properties of null (reading 'tabs')
    at _2.addChildView (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29539:26 [^])
    at _2.createViewStructure (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:2:7097)
    at _2.buildStructure (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29047:10 [^])
    at _2.initWidget (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:28862:12 [^])
    at _2.isc_c_Class_invokeSuper [as invokeSuper] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:245:93 [^])
    at _2.isc_c_Class_Super [as Super] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:237:170 [^])
    at _2.initWidget (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:4:432)
    at _2.isc_Canvas_init [as init] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:1657:6 [^])
    at _2.isc_Class_completeCreation [as completeCreation] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:287:6 [^])
    at _2.isc_c_Class_create (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:182:1891 [^])
Steps To ReproduceReproduced in livebuilds retail with modules and in DKT client.
Steps in the video attached reproducing it in pi.

Make sure no modules are in development. Clear the cache to ensure no precached window is used.

As System Admin:
- Uncheck checkbox 'Show Translations tab' in Session Preferences
- Open Messages window. Close it
- Check checkbox 'Show Translations tab' in Session Preferences
- Open Messages window. It will fail with the console error mentioned above
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-03-21 17:42hector_hernaezNew Issue
2024-03-21 17:42hector_hernaezAssigned To => AugustoMauch
2024-03-21 17:42hector_hernaezOBNetwork customer => Gold
2024-03-21 17:42hector_hernaezModules => Core
2024-03-21 17:42hector_hernaezSupport ticket => 82354
2024-03-21 17:42hector_hernaezTriggers an Emergency Pack => No
2024-03-21 17:42hector_hernaezIssue generated from0054878
2024-03-21 17:43hector_hernaezNote Added: 0162513
2024-03-21 17:43hector_hernaezNote Edited: 0162513bug_revision_view_page.php?bugnote_id=0162513#r27723
2024-03-21 18:23AugustoMauchNote Added: 0162514
2024-03-21 23:19AugustoMauchStatusnew => acknowledged
2024-04-15 10:55AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27812#r27812
2024-04-15 10:57hgbotMerge Request Status => open
2024-04-15 10:57hgbotNote Added: 0163189
2024-04-15 17:39AugustoMauchStatusacknowledged => scheduled
2024-04-18 13:28hgbotMerge Request Statusopen => approved
2024-04-18 13:29hgbotResolutionopen => fixed
2024-04-18 13:29hgbotStatusscheduled => closed
2024-04-18 13:29hgbotFixed in Version => PR24Q3
2024-04-18 13:29hgbotNote Added: 0163384
2024-04-18 13:29hgbotNote Added: 0163385

Notes
(0162513)
hector_hernaez   
2024-03-21 17:43   
Will have to be backported to https://gitlab.com/openbravo/customers/DKT/pi_19q3/-/tree/Ticket_82354?ref_type=heads [^]
(0162514)
AugustoMauch   
2024-03-21 18:23   
Problem: hasChildTabs is only executed once, not every time the window is open:

hasChildTabs: (OB.PropertyStore.get('ShowTrl', this.windowId) === 'Y'),
https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl?ref_type=heads#L163 [^]
(0163189)
hgbot   
2024-04-15 10:57   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1199 [^]
(0163384)
hgbot   
2024-04-18 13:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 93641bed9791273f828e82b25031800d01bbf0b5
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 18-04-2024 11:29:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/93641bed9791273f828e82b25031800d01bbf0b5 [^]

Fixes ISSUE-55030: Prevents error when tab does not have a childTabSet

Now, before adding a new child tab to a childTabSet, we check if the childTabSet is null,
and if so we create it and make it visible

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0163385)
hgbot   
2024-04-18 13:29   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1199 [^]