Project: 	
  | View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054925 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] POS | major | always | 2024-01-19 14:35 | 2024-03-18 09:21 | |||
| Reporter | wicherr | View Status | public | |||||
| Assigned To | Triage Omni OMS | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 24Q1.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054925: Deleting a ticket without calling the calculation of taxes makes the ticket go to EWI | |||||||
| Description | Using a pricelist with prices without tax, When you add a product on the basket and delete the ticket on the scan tab, it goes to EWI with the following error : org.openbravo.base.exception.OBException: Error in OrderLoader: No tax was found for the specified product. Please review your configuration at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:513) at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64) at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:447) at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:370) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: org.openbravo.base.exception.OBException: No tax was found for the specified product. Please review your configuration at org.openbravo.retail.posterminal.OrderLoader.verifyOrderLineTax(OrderLoader.java:2277) at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:344) ... 12 more | |||||||
| Steps To Reproduce | This defect has been obtained using the Avalara module Step to reproduce 1 : Create a new ticket Add a product DON’T click on Pay Delete the ticket Check the EWI Step to reproduce 2 : Create a new ticket Add a product Click on Pay Click on Back Delete the ticket Check the EWI | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
|  Relationships		[ Relation Graph ] 
		[ Dependency Graph ] | ||||||||
| 
 | ||||||||
|  Notes | |
| (0162201) hgbot (developer) 2024-03-14 18:15 | Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1174 [^] | 
| (0162256) hgbot (developer) 2024-03-18 09:11 | Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1174 [^] | 
| (0162257) hgbot (developer) 2024-03-18 09:11 | Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: e8458096a5ca4124fbbb11de8e9aad1e73c39886 Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com> Date: 18-03-2024 08:11:06 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e8458096a5ca4124fbbb11de8e9aad1e73c39886 [^] Fixed ISSUE-54925: Removed Null constraint for orderline tax column --- M src-db/database/model/tables/C_ORDERLINE.xml M src-db/database/sourcedata/AD_COLUMN.xml --- | 
| (0162258) aferraz (viewer) 2024-03-18 09:19 edited on: 2024-03-18 09:20 | Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] [^] Changeset: d8e59b7aaed3ef22a9e560d40bd5abd6143451ff Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com> Date: 18-03-2024 08:11:06 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d8e59b7aaed3ef22a9e560d40bd5abd6143451ff [^] [^] Fixed Issue-54925:Added condition to deleted order for verifying tax --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- | 
| (0162259) hgbot (developer) 2024-03-18 09:21 | Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: b8a4ee0422bc7947b9288c6007d7f4fc9d66644e Author: Kousalya Ramasamy <kousalya.ramasamy@openbravo.com> Date: 18-03-2024 09:21:09 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/b8a4ee0422bc7947b9288c6007d7f4fc9d66644e [^] Fixes ISSUE-54925: Orderline tax can accept null values for deleted orders --- M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml --- | 
|  Issue History | |||
| Date Modified | Username | Field | Change | 
| 2024-03-12 19:31 | aferraz | Type | defect => backport | 
| 2024-03-12 19:31 | aferraz | Target Version | => 24Q1.1 | 
| 2024-03-14 18:15 | hgbot | Note Added: 0162201 | |
| 2024-03-18 09:11 | hgbot | Note Added: 0162256 | |
| 2024-03-18 09:11 | hgbot | Resolution | open => fixed | 
| 2024-03-18 09:11 | hgbot | Status | scheduled => closed | 
| 2024-03-18 09:11 | hgbot | Fixed in Version | => PR24Q1.1 | 
| 2024-03-18 09:11 | hgbot | Note Added: 0162257 | |
| 2024-03-18 09:19 | aferraz | Note Added: 0162258 | |
| 2024-03-18 09:20 | aferraz | Note Edited: 0162258 | View Revisions | 
| 2024-03-18 09:21 | hgbot | Note Added: 0162259 | |
| Copyright © 2000 - 2009 MantisBT Group |