Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054878 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] E. Translation | major | always | 2024-03-07 12:39 | 2024-03-21 17:42 | |||
| Reporter | hector_hernaez | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 28f7cbffe1bb | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054878: Issue when the status of checkbox 'Show translation tabs' changes and a window that needs it is opened | |||||||
| Description | When the checkbox 'Show translation tabs' in Session Preferences window is unchecked or checked (depends on the status of the xheckbox) and a window that uses that checkbox is opened, it remains in loading and an error appears in console with this message: Uncaught TypeError: Cannot read properties of null (reading 'tabs') at _2.addChildView (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29539:26 [^]) at _2.createViewStructure (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:2:7097) at _2.buildStructure (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29047:10 [^]) at _2.initWidget (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:28862:12 [^]) at _2.isc_c_Class_invokeSuper [as invokeSuper] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:245:93 [^]) at _2.isc_c_Class_Super [as Super] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:237:170 [^]) at _2.initWidget (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:4:432) at _2.isc_Canvas_init [as init] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:1657:6 [^]) at _2.isc_Class_completeCreation [as completeCreation] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:287:6 [^]) at _2.isc_c_Class_create (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:182:1891 [^]) | |||||||
| Steps To Reproduce | Reproduced in livebuilds retail with modules and in DKT client. Steps in the video attached reproducing it in pi. In client White Valley Admin for example: - Uncheck checkbox 'Show Translations tab' - Open window 'Payment Provider' - The window remains in loading status and an error appears in the console To reproduce it: - Payment Provider must only have the Translation subtab. If there are other subtabs, deactivate them - No modules should be in development | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Show translation issue.webm [^] (1,123,379 bytes) 2024-03-07 12:39 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0162306) hgbot (developer) 2024-03-18 17:25 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1176 [^] |
|
(0162372) hgbot (developer) 2024-03-19 16:49 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1176 [^] |
|
(0162373) hgbot (developer) 2024-03-19 16:49 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 28f7cbffe1bb30c8236ce1e6d3aa9556e3d29779 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 19-03-2024 15:46:27 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/28f7cbffe1bb30c8236ce1e6d3aa9556e3d29779 [^] Fixes ISSUE-54878: Tab is opened even after hiding translations The problem is that the application was not supporting hiding a tab, when in the stored version of the view that tab was active. Now we detect this case, and in the case where the tab that used to be active is no longer available and there are no more subtabs, updateSubtabVisibility just does not do anything. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0162407) hector_hernaez (developer) 2024-03-20 10:41 |
After applying the fix in DKT APAC, we still have the same issue. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-03-07 12:39 | hector_hernaez | New Issue | |
| 2024-03-07 12:39 | hector_hernaez | Assigned To | => Triage Platform Base |
| 2024-03-07 12:39 | hector_hernaez | File Added: Show translation issue.webm | |
| 2024-03-07 12:39 | hector_hernaez | Modules | => Core |
| 2024-03-07 12:39 | hector_hernaez | Triggers an Emergency Pack | => No |
| 2024-03-18 17:19 | AugustoMauch | Steps to Reproduce Updated | View Revisions |
| 2024-03-18 17:21 | AugustoMauch | Assigned To | Triage Platform Base => AugustoMauch |
| 2024-03-18 17:21 | AugustoMauch | Status | new => scheduled |
| 2024-03-18 17:25 | hgbot | Note Added: 0162306 | |
| 2024-03-19 16:49 | hgbot | Note Added: 0162372 | |
| 2024-03-19 16:49 | hgbot | Resolution | open => fixed |
| 2024-03-19 16:49 | hgbot | Status | scheduled => closed |
| 2024-03-19 16:49 | hgbot | Fixed in Version | => PR24Q2 |
| 2024-03-19 16:49 | hgbot | Note Added: 0162373 | |
| 2024-03-20 10:41 | hector_hernaez | Note Added: 0162407 | |
| 2024-03-20 10:41 | hector_hernaez | Status | closed => new |
| 2024-03-20 10:41 | hector_hernaez | Resolution | fixed => open |
| 2024-03-20 10:41 | hector_hernaez | Fixed in Version | PR24Q2 => |
| 2024-03-21 17:35 | hector_hernaez | Status | new => scheduled |
| 2024-03-21 17:35 | hector_hernaez | Status | scheduled => resolved |
| 2024-03-21 17:35 | hector_hernaez | Fixed in SCM revision | => https://gitlab.com/openbravo/product/openbravo/-/commit/28f7cbffe1bb30c8236ce1e6d3aa9556e3d29779 [^] |
| 2024-03-21 17:35 | hector_hernaez | Resolution | open => fixed |
| 2024-03-21 17:35 | hector_hernaez | Status | resolved => closed |
| 2024-03-21 17:42 | hector_hernaez | Issue cloned | 0055030 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |