Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054878Openbravo ERPE. Translationpublic2024-03-07 12:392024-03-21 17:42
Reporterhector_hernaez 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054878: Issue when the status of checkbox 'Show translation tabs' changes and a window that needs it is opened
DescriptionWhen the checkbox 'Show translation tabs' in Session Preferences window is unchecked or checked (depends on the status of the xheckbox) and a window that uses that checkbox is opened, it remains in loading and an error appears in console with this message:

Uncaught TypeError: Cannot read properties of null (reading 'tabs')
    at _2.addChildView (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29539:26 [^])
    at _2.createViewStructure (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:2:7097)
    at _2.buildStructure (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:29047:10 [^])
    at _2.initWidget (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/js/gen/f5261931d24addcc6a30ec037960f398.js:28862:12 [^])
    at _2.isc_c_Class_invokeSuper [as invokeSuper] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:245:93 [^])
    at _2.isc_c_Class_Super [as Super] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:237:170 [^])
    at _2.initWidget (eval at <anonymous> (eval at isc__makeFunction (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:45:122 [^])), <anonymous>:4:432)
    at _2.isc_Canvas_init [as init] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:1657:6 [^])
    at _2.isc_Class_completeCreation [as completeCreation] (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:287:6 [^])
    at _2.isc_c_Class_create (https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js:182:1891 [^])
Steps To ReproduceReproduced in livebuilds retail with modules and in DKT client.
Steps in the video attached reproducing it in pi.

In client White Valley Admin for example:
- Uncheck checkbox 'Show Translations tab'
- Open window 'Payment Provider'
- The window remains in loading status and an error appears in the console

To reproduce it:
- Payment Provider must only have the Translation subtab. If there are other subtabs, deactivate them
- No modules should be in development
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? Show translation issue.webm (1,123,379) 2024-03-07 12:39
https://issues.openbravo.com/file_download.php?file_id=19527&type=bug
Issue History
Date ModifiedUsernameFieldChange
2024-03-07 12:39hector_hernaezNew Issue
2024-03-07 12:39hector_hernaezAssigned To => Triage Platform Base
2024-03-07 12:39hector_hernaezFile Added: Show translation issue.webm
2024-03-07 12:39hector_hernaezModules => Core
2024-03-07 12:39hector_hernaezTriggers an Emergency Pack => No
2024-03-18 17:19AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27706#r27706
2024-03-18 17:21AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2024-03-18 17:21AugustoMauchStatusnew => scheduled
2024-03-18 17:25hgbotNote Added: 0162306
2024-03-19 16:49hgbotNote Added: 0162372
2024-03-19 16:49hgbotResolutionopen => fixed
2024-03-19 16:49hgbotStatusscheduled => closed
2024-03-19 16:49hgbotFixed in Version => PR24Q2
2024-03-19 16:49hgbotNote Added: 0162373
2024-03-20 10:41hector_hernaezNote Added: 0162407
2024-03-20 10:41hector_hernaezStatusclosed => new
2024-03-20 10:41hector_hernaezResolutionfixed => open
2024-03-20 10:41hector_hernaezFixed in VersionPR24Q2 =>
2024-03-21 17:35hector_hernaezStatusnew => scheduled
2024-03-21 17:35hector_hernaezStatusscheduled => resolved
2024-03-21 17:35hector_hernaezFixed in SCM revision => https://gitlab.com/openbravo/product/openbravo/-/commit/28f7cbffe1bb30c8236ce1e6d3aa9556e3d29779 [^]
2024-03-21 17:35hector_hernaezResolutionopen => fixed
2024-03-21 17:35hector_hernaezStatusresolved => closed
2024-03-21 17:42hector_hernaezIssue cloned0055030

Notes
(0162306)
hgbot   
2024-03-18 17:25   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1176 [^]
(0162372)
hgbot   
2024-03-19 16:49   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1176 [^]
(0162373)
hgbot   
2024-03-19 16:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 28f7cbffe1bb30c8236ce1e6d3aa9556e3d29779
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 19-03-2024 15:46:27
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/28f7cbffe1bb30c8236ce1e6d3aa9556e3d29779 [^]

Fixes ISSUE-54878: Tab is opened even after hiding translations

The problem is that the application was not supporting hiding a tab, when in the stored version of the view
that tab was active. Now we detect this case, and in the case where the tab that used to be active is no
longer available and there are no more subtabs, updateSubtabVisibility just does not do anything.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0162407)
hector_hernaez   
2024-03-20 10:41   
After applying the fix in DKT APAC, we still have the same issue.