Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0054850
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Cash upmajoralways2024-03-05 16:192024-04-11 11:59
Reporterwilliam_vermerschView Statuspublic 
Assigned ToRajesh_18 
PriorityhighResolutionfixedFixed in VersionRR24Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054850: cashTaxInfo is wrong after a closed ticket is synchronized again

DescriptionHello,

When opening a closed receipt and finalizing it again, the net amount is added again in the cashTaxInfo of the cashupReportInformation object.

It is impacting the customized template using this data.
Steps To Reproduce1. Select a product (Net amount = 20€)
2. Finalize the ticket (Pay, Done)
3. Check the Order data import entry (cashTaxInfo => baseAmount = 20€)
4. Reopen the previously closed ticket
5. Finalize it (Click on payment, Done)
6. Check the new Order data import entry (cashTaxInfo => baseAmount = 40€)

The previous amount can't vary if you have already made sales that day, but I think you get the idea.

The step 6 result is obviously wrong the 20€ net amount should not have been added again. Strangely only baseAmount property amount is impacted.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0162056)
jorgewederago (developer)
2024-03-13 09:17

The bug is that when we are completing the paid ticket the taxes are being updated when they are not supposed to. This logic is already been applied to other fields related to the cashup
(0162158)
hgbot (developer)
2024-03-14 12:55

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1507 [^]
(0162176)
hgbot (developer)
2024-03-14 14:09

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1507 [^]
(0162177)
hgbot (developer)
2024-03-14 14:09

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 48177c2d79cf5c9fd529c55d2a33844c4b3efac4
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 14-03-2024 13:08:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/48177c2d79cf5c9fd529c55d2a33844c4b3efac4 [^]

Fixed ISSUE-54850: cashTaxInfo should not be updated for Completed Orders

---
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
---
(0162305)
william_vermersch (developer)
2024-03-18 17:05

Hi,

After reviewing the commit and adding it to our codebase, we can see (obviously) that the issue is remaining in case the payment is changed.

I don't understand since the quantity delivered doesn't change and only the payment, why the cashTaxInfo was not fixed in that case ?

Regards,
William
(0162546)
hgbot (developer)
2024-03-22 11:11

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1515 [^]
(0163094)
hgbot (developer)
2024-04-11 11:59

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1515 [^]
(0163095)
hgbot (developer)
2024-04-11 11:59

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1c08da3e28a976042f7a041eb564dda2ed99f169
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 11-04-2024 07:31:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1c08da3e28a976042f7a041eb564dda2ed99f169 [^]

Fixed ISSUE-54850: CashTaxInfo should not be updated for Completed Orders

---
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
---

- Issue History
Date Modified Username Field Change
2024-03-05 16:19 william_vermersch New Issue
2024-03-05 16:19 william_vermersch Assigned To => Retail
2024-03-05 16:19 william_vermersch Triggers an Emergency Pack => No
2024-03-13 09:16 jorgewederago Status new => acknowledged
2024-03-13 09:17 jorgewederago Note Added: 0162056
2024-03-13 12:25 Rajesh_18 Assigned To Retail => Rajesh_18
2024-03-13 12:25 Rajesh_18 Status acknowledged => scheduled
2024-03-14 12:55 hgbot Note Added: 0162158
2024-03-14 14:09 hgbot Note Added: 0162176
2024-03-14 14:09 hgbot Resolution open => fixed
2024-03-14 14:09 hgbot Status scheduled => closed
2024-03-14 14:09 hgbot Fixed in Version => RR24Q2
2024-03-14 14:09 hgbot Note Added: 0162177
2024-03-18 17:05 william_vermersch Note Added: 0162305
2024-03-18 17:05 william_vermersch Status closed => new
2024-03-20 11:44 jorgewederago Status new => acknowledged
2024-03-21 11:14 Rajesh_18 Status acknowledged => scheduled
2024-03-22 11:11 hgbot Note Added: 0162546
2024-04-11 11:59 hgbot Status scheduled => closed
2024-04-11 11:59 hgbot Note Added: 0163094
2024-04-11 11:59 hgbot Fixed in Version RR24Q2 => RR24Q3
2024-04-11 11:59 hgbot Note Added: 0163095


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker