Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0054848
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorhave not tried2024-03-05 15:492024-03-27 17:44
ReporterablascoView Statuspublic 
Assigned Toablasco 
PrioritynormalResolutionfixedFixed in Version24Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1377/diffs?commit_id=a7f0b37a963aadcecbaf41cdf4ca40441a26d0f3 [^]
Triggers an Emergency PackNo
Summary

0054848: ConfigurableButton label and icon wrong position caused by BaseContent alignment styling rules

DescriptionDevelopment in state-based badges in BaseContent caused a regression in alignment inside StandardButtons.

Due to a recent change, BaseContent could include Badges with icons, or Fabs in labels. This model include some changes in MultiTabBaseDialog, DrawerMenu and StandardButtons styling rules.

ConfigurableButton is using StandardButtons (maybe others too), and it should have a different styling independent from the changes applied in such generic component.
Steps To Reproduce*
Proposed SolutionReview align justify-content:center in Standard-button.

.obc2StandardButton-content.obc2BaseContent_simple.obc2StandardButton-content {
  grid-template-columns: auto;
  justify-content: center;
}
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
caused by feature request 0054728 closedablasco Add support for state-based badges and Fab Info in menu entries and multitab titles 
has duplicate defect 0055059 closedAugustoMauch text and icons centered 
causes defect 0055130 closedablasco ClassName breaks alignment CSS rule in StandardButton component 

-  Notes
(0161675)
hgbot (developer)
2024-03-05 16:44

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1400 [^]
(0162729)
hgbot (developer)
2024-03-27 17:44

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1400 [^]
(0162730)
hgbot (developer)
2024-03-27 17:44

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c34cab696709f30c58492b9f06a2c4e2d0d4756a
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 27-03-2024 12:58:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c34cab696709f30c58492b9f06a2c4e2d0d4756a [^]

Fixes ISSUE-54848: justify-content: center compatible with stateBaseContent with Fab in StandardButton

---
M web-jspack/org.openbravo.core2/src/components/StandardButton/StandardButton.jsx
M web-jspack/org.openbravo.core2/src/components/StandardButton/StandardButton.scss
---

- Issue History
Date Modified Username Field Change
2024-03-05 15:49 ablasco New Issue
2024-03-05 15:49 ablasco Assigned To => ablasco
2024-03-05 15:49 ablasco Triggers an Emergency Pack => No
2024-03-05 15:49 ablasco Relationship added caused by 0054728
2024-03-05 15:51 ablasco Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1377/diffs?commit_id=a7f0b37a963aadcecbaf41cdf4ca40441a26d0f3 [^]
2024-03-05 16:44 hgbot Note Added: 0161675
2024-03-27 13:53 AugustoMauch Relationship added has duplicate 0055059
2024-03-27 13:58 AugustoMauch Status new => scheduled
2024-03-27 17:44 hgbot Note Added: 0162729
2024-03-27 17:44 hgbot Resolution open => fixed
2024-03-27 17:44 hgbot Status scheduled => closed
2024-03-27 17:44 hgbot Fixed in Version => 24Q2
2024-03-27 17:44 hgbot Note Added: 0162730
2024-04-08 19:09 ablasco Relationship added causes 0055130


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker