Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054737 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | major | have not tried | 2024-02-21 16:09 | 2024-02-26 19:13 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 24Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054737: Build process improvement: include missing dependencies, support standalone infrastructure modules | |||||||
| Description | The current build process for core2 applications has 2 problems: - It does not properly retrieve all dependencies. I.e. when building POS2, it includes all the modules in the natural tree of POS and POS2, but it does not automatically include all ancestor of modules that depend on those applications (see attached image MissingModule.png, where camerabarcodescanner would not be included because it is not part of the natural tree of POS. currently it is include by adding an artificial dependency from it to camerabarcodescanner.posterminal, thus making it part of the natural tree of POS). - It does not support including infrastructure modules that i.e. extend core2 but that are not part of the natural tree of any application. One example of this type of module is the module to support fast authentication. See attached image MissingModule2.png | |||||||
| Steps To Reproduce | - Create a POS2 environment - Remove the dependency from org.openbravo.retail.camerabarcodescanner to org.openbravo.retail.camerabarcodescanner.posterminal [1] - Run ant build in core2 to build the POS2 application. Note that the ob-init file of org.openbravo.retail.camerabarcodescanner is not included in web-jspack/org.openbravo.core2/src/generated/POS2-modules-init.js, and the application won't start [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.camerabarcodescanner/-/blob/master/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml?ref_type=heads#L17 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  MissingModule.png [^] (65,970 bytes) 2024-02-21 16:09
MissingModule2.png [^] (47,257 bytes) 2024-02-21 16:09
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0161069) hgbot (developer) 2024-02-22 08:20 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1150 [^] |
|
(0161070) hgbot (developer) 2024-02-22 08:20 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.camerabarcodescanner/-/merge_requests/16 [^] |
|
(0161071) hgbot (developer) 2024-02-22 08:21 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1381 [^] |
|
(0161174) hgbot (developer) 2024-02-23 09:05 |
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1150 [^] |
|
(0161276) hgbot (developer) 2024-02-26 19:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1381 [^] |
|
(0161277) hgbot (developer) 2024-02-26 19:13 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: fc364268b9dbb9766510cc4eacba2cf6ccb56a18 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 26-02-2024 19:12:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/fc364268b9dbb9766510cc4eacba2cf6ccb56a18 [^] Fixes ISSUE-54737: Adds support for standalone infrastructure modules Some modules can be flagged as being standalone infrastructure modules by including an ob-config file with the property "standaloneInfra" set to true. The ob-init file of those modules will be included in the -modules-init.js file, even if they are not part of the natural tree of the application module. Also its labels and lists will be included in *-labels-<language>.json and POS2-lists-<language>.json respectively. If the natural tree of infrastructure modules is included, we risk including modules that belong to other applications. I.e. when compiling POS2 we would be including SSMS, because org.openbravo.retail.camerabarcodescanner is an infrastructure module and SSMS is in its natural tree --- M src/org/openbravo/core2/Core2Constants.java M src/org/openbravo/core2/build/ModuleInfoGenerator.java M src/org/openbravo/core2/build/ReactBuildUtils.java --- |
|
(0161278) hgbot (developer) 2024-02-26 19:13 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.camerabarcodescanner [^] Changeset: 89a2a505f926156c9bd4ab2964dd0e7f05245949 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 21-02-2024 23:58:13 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.camerabarcodescanner/-/commit/89a2a505f926156c9bd4ab2964dd0e7f05245949 [^] Related to ISSUE-54737: Flags module as standalone infra, removes unneeded dependency to org.openbravo.retail.camerabarcodescanner.posterminal --- A web-jspack/org.openbravo.retail.camerabarcodescanner/ob-config.json M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml --- |
|
(0161279) hgbot (developer) 2024-02-26 19:13 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.camerabarcodescanner/-/merge_requests/16 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-02-21 16:09 | AugustoMauch | New Issue | |
| 2024-02-21 16:09 | AugustoMauch | Assigned To | => AugustoMauch |
| 2024-02-21 16:09 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2024-02-21 16:09 | AugustoMauch | File Added: MissingModule.png | |
| 2024-02-21 16:09 | AugustoMauch | File Added: MissingModule2.png | |
| 2024-02-22 08:20 | hgbot | Note Added: 0161069 | |
| 2024-02-22 08:20 | hgbot | Note Added: 0161070 | |
| 2024-02-22 08:21 | hgbot | Note Added: 0161071 | |
| 2024-02-23 09:05 | hgbot | Note Added: 0161174 | |
| 2024-02-23 10:26 | AugustoMauch | Status | new => scheduled |
| 2024-02-26 19:13 | hgbot | Note Added: 0161276 | |
| 2024-02-26 19:13 | hgbot | Resolution | open => fixed |
| 2024-02-26 19:13 | hgbot | Status | scheduled => closed |
| 2024-02-26 19:13 | hgbot | Fixed in Version | => 24Q2 |
| 2024-02-26 19:13 | hgbot | Note Added: 0161277 | |
| 2024-02-26 19:13 | hgbot | Note Added: 0161278 | |
| 2024-02-26 19:13 | hgbot | Note Added: 0161279 | |
| 2024-02-27 08:04 | caristu | Relationship added | has duplicate 0054632 |
| 2024-03-12 11:00 | caristu | Relationship added | related to 0054921 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |