Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054670 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Core | critical | have not tried | 2024-02-14 10:55 | 2024-02-14 23:33 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 24Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 24Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | Packaging and release | |||||||
| Regression date | 2023-11-06 | |||||||
| Regression introduced in release | main | |||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/f38f5a036d4dff9b3e9f5f7083a2c0d25ab6b0e6 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054670: Approvals of actions without inputs are not being persisted in the backend | |||||||
| Description | When doing an approval of an action that does not have any user action inputs, the approval is not being persisted in the backend | |||||||
| Steps To Reproduce | In any POS2 enviroment that contains the sampledata (i.e. livebuilds) 1- In the backoffice, update permissions to the VallBlancaUser role, so that it requires approval when executing the "Return Line" action. 2- In the backoffice, update permissions to the The White Valley Group Admin role, so that it can approve the "Return Line" action 3- Log in in the POS with the vallblanca user, make sure the VallBlancaUser role is active 4- Add a line and return it. A popup will be displayed asking for user inputs and approval. Add them (use Openbravo/openbravo in the approval), complete the ticket. 5- Go to the backend, open the Return from Customer window, check the record that was created and check that the Approval History subtab contains info related to the approval that just took place. So far, this is the expected behaviour. Now: 6- In the backoffice, deactivate all user inputs from the Return Line action in the User Action Input window. 7- Back in POS2, refresh the masterdata so that the changes done in the backoffice are applied. Repeat steps 4 and 5, and notice how in the new Return from Customer record there is no trace about the approval that took place when returning the line | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0160749) hgbot (developer) 2024-02-14 16:48 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1368 [^] |
|
(0160759) hgbot (developer) 2024-02-14 23:33 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1368 [^] |
|
(0160760) hgbot (developer) 2024-02-14 23:33 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 567f7a4778ff7ac1e8af04cd671f25d38fba2b15 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 14-02-2024 16:47:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/567f7a4778ff7ac1e8af04cd671f25d38fba2b15 [^] fixes BUG-54670: approval info not saved when no input is requested The approval information was not being persisted when requesting approval only, i.e., without requesting inputs. This happened because in that case the inputsAndApprovals is empty at the point where the approval information is added. So adding that information using map() has no effect. To fix it in that case we now return an array with a single object properly initialized together with the approval information. --- M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-02-14 12:45 | AugustoMauch | Type | defect => backport |
| 2024-02-14 12:45 | AugustoMauch | Target Version | => 24Q1 |
| 2024-02-14 16:48 | hgbot | Note Added: 0160749 | |
| 2024-02-14 23:33 | hgbot | Resolution | open => fixed |
| 2024-02-14 23:33 | hgbot | Status | scheduled => closed |
| 2024-02-14 23:33 | hgbot | Note Added: 0160759 | |
| 2024-02-14 23:33 | hgbot | Fixed in Version | => 24Q1 |
| 2024-02-14 23:33 | hgbot | Note Added: 0160760 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |