Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0054577
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Retail APImajoralways2024-02-05 14:582024-02-13 11:24
ReporterngarciaView Statuspublic 
Assigned ToRajesh_18 
PriorityurgentResolutionfixedFixed in VersionRR24Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054577: ExternalOrderLoader should also look by the search key when trying to find a tax rate

DescriptionExternalOrderLoader should also look by the search key when trying to find a tax rate. Currently it is looking for:

id
Name
Tax Search Key (hidden field of 5 char)
Steps To ReproduceChange the name of the Entregas IVA 21% tax rate, but leave the search key as it is (Entregas IVA 21%)
Import an order through the External Order Loader with the "Entregas IVA 21%" tax rate
Check the following error is returned:

"error": {
        "message": "Value Entregas IVA 21% does not resolve to an instance of FinancialMgmtTaxRate",
        "messageType": "Error",
        "title": ""
    },
    "totalRows": 0
}
Proposed SolutionIn transformTaxes function of ExternalOrderLoader, add the value as a property to look for. Something such as

      final String taxId = resolveJsonValue(TaxRate.ENTITY_NAME, name,
          new String[] { "id", "name", "taxSearchKey", "value" });
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0054654RR24Q1.1 closedRajesh_18 ExternalOrderLoader should also look by the search key when trying to find a tax rate 

-  Notes
(0160663)
hgbot (developer)
2024-02-13 06:52

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1469 [^]
(0160668)
hgbot (developer)
2024-02-13 08:04

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6152b9ef40682e66b7855180e8adf9eed9047a4e
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 13-02-2024 07:04:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6152b9ef40682e66b7855180e8adf9eed9047a4e [^]

Fixed ISSUE-54577: Added Tax searchKey property while finding taxes

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0160669)
hgbot (developer)
2024-02-13 08:04

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1469 [^]

- Issue History
Date Modified Username Field Change
2024-02-05 14:58 ngarcia New Issue
2024-02-05 14:58 ngarcia Assigned To => Triage Platform Conn
2024-02-05 14:58 ngarcia Triggers an Emergency Pack => No
2024-02-05 14:58 ngarcia Issue Monitored: networkb
2024-02-05 15:03 adrianromero Assigned To Triage Platform Conn => Retail
2024-02-08 14:01 Rajesh_18 Assigned To Retail => Rajesh_18
2024-02-08 14:01 Rajesh_18 Status new => scheduled
2024-02-13 06:52 hgbot Note Added: 0160663
2024-02-13 08:04 hgbot Resolution open => fixed
2024-02-13 08:04 hgbot Status scheduled => closed
2024-02-13 08:04 hgbot Fixed in Version => RR24Q2
2024-02-13 08:04 hgbot Note Added: 0160668
2024-02-13 08:04 hgbot Note Added: 0160669
2024-02-13 11:23 marvintm Status closed => new
2024-02-13 11:23 marvintm Resolution fixed => open
2024-02-13 11:23 marvintm Fixed in Version RR24Q2 =>
2024-02-13 11:23 marvintm Status new => scheduled
2024-02-13 11:24 marvintm Status scheduled => resolved
2024-02-13 11:24 marvintm Fixed in Version => RR24Q2
2024-02-13 11:24 marvintm Resolution open => fixed
2024-02-13 11:24 marvintm Review Assigned To => marvintm
2024-02-13 11:24 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker