0054577: ExternalOrderLoader should also look by the search key when trying to find a tax rate

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054577

Retail Modules

Retail API

public

2024-02-05 14:58

2024-02-13 11:24

Reporter

ngarcia

Assigned To

Rajesh_18

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR24Q2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0054577: ExternalOrderLoader should also look by the search key when trying to find a tax rate

Description

ExternalOrderLoader should also look by the search key when trying to find a tax rate. Currently it is looking for:

id
Name
Tax Search Key (hidden field of 5 char)

Steps To Reproduce

Change the name of the Entregas IVA 21% tax rate, but leave the search key as it is (Entregas IVA 21%)
Import an order through the External Order Loader with the "Entregas IVA 21%" tax rate
Check the following error is returned:

"error": {
        "message": "Value Entregas IVA 21% does not resolve to an instance of FinancialMgmtTaxRate",
        "messageType": "Error",
        "title": ""
    },
    "totalRows": 0
}

Proposed Solution

In transformTaxes function of ExternalOrderLoader, add the value as a property to look for. Something such as

final String taxId = resolveJsonValue(TaxRate.ENTITY_NAME, name,
new String[] { "id", "name", "taxSearchKey", "value" });

Additional Information