Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054568 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | always | 2024-02-02 15:42 | 2024-02-12 16:20 | |||
| Reporter | lorenzofidalgo | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 24Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | main | SCM revision | ||||||
| Review Assigned To | ||||||||
| Regression level | QA functional test | |||||||
| Regression date | 2023-10-17 | |||||||
| Regression introduced in release | main | |||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f35ca078047b33682c70833de0bf1f3d84463b49 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054568: [24Q1] Return Line Reason is set as "undefined" if no input is chosen | |||||||
| Description | At the moment of selecting values in a Return Line, if the POS2 user chooses to insert no input, "undefined" is shown as value inside the ticket instead of an empty value or other proper solution. This issue has been reproducible in 24Q1 (QA status) and it seems to come from the development that extends the Return Reason functionality. In older versions, the flows differ slightly but, now, the POS2 user receives a wrong value that was not shown previously. Issue not reproducible in livebuilds 23Q4.1. | |||||||
| Steps To Reproduce | Configuration: 0-Login POS2 backoffice and go to "User Action Input" window. 1-Deactive all records except the following one: "User Action": "Return Line" "User Input"": "Return Line Reason". 2-Enter the previous aforementioned (in Step 1) record and set "Mandatory" as False and Active as True. Save the modifications. POS2 flow: 1-Login POS2 using CMS-2 terminal and centralmountains as user. 2-Add 1x "Avalanche transceiver" to the ticket. 3-Click the just added product line and, in the overlay, click "Return Line" button. 4-Without choosing value, click OK button. DEFECT: Realise "undefined" is shown as value in the ticket line (check attached images to see current and old behaviour). | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  undefined.png [^] (53,731 bytes) 2024-02-02 15:42
NotOK.png [^] (52,125 bytes) 2024-02-02 15:42
OK.png [^] (58,674 bytes) 2024-02-02 15:42
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0160525) hgbot (developer) 2024-02-09 09:16 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2418 [^] |
|
(0160636) hgbot (developer) 2024-02-12 16:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 4930df9399739d391fa8157d45427ead9b685b03 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 12-02-2024 15:18:45 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4930df9399739d391fa8157d45427ead9b685b03 [^] fixes BUG-54568: inputs with undefined values are displayed in the UI The original TicketLineReturnReason component was not displaying any reason information if no reason was provided by the user. After refactoring the component (now TicketLineReturnInputs) to support displaying the information of multiple inputs, in this case the property to get the information is not directly null but an array with inputs whose values are undefined when the user does not provide them. Note that, of course, this problem only happened for those inputs defined as non mandatory. Now the component takes into account this case and skips rendering the information of those items in that array that has no value provided by the user. --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineReturnInputs.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLineReturnInputs.test.jsx --- |
|
(0160637) hgbot (developer) 2024-02-12 16:20 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2418 [^] |
|
(0160638) hgbot (developer) 2024-02-12 16:20 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 4342d795ab2a54163d0f3ecbbe2d7eff7d20d0c9 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 12-02-2024 15:20:33 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4342d795ab2a54163d0f3ecbbe2d7eff7d20d0c9 [^] fixes BUG-54568: inputs with undefined values are displayed in the UI --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineReturnInputs.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLineReturnInputs.test.jsx --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-02-02 15:42 | lorenzofidalgo | New Issue | |
| 2024-02-02 15:42 | lorenzofidalgo | Assigned To | => Retail |
| 2024-02-02 15:42 | lorenzofidalgo | File Added: undefined.png | |
| 2024-02-02 15:42 | lorenzofidalgo | Triggers an Emergency Pack | => No |
| 2024-02-02 15:42 | lorenzofidalgo | File Added: NotOK.png | |
| 2024-02-02 15:42 | lorenzofidalgo | File Added: OK.png | |
| 2024-02-02 15:43 | lorenzofidalgo | Regression level | => QA functional test |
| 2024-02-02 15:43 | lorenzofidalgo | Regression introduced in release | => main |
| 2024-02-02 15:46 | lorenzofidalgo | Description Updated | View Revisions |
| 2024-02-02 15:46 | lorenzofidalgo | Description Updated | View Revisions |
| 2024-02-08 10:19 | caristu | Assigned To | Retail => caristu |
| 2024-02-09 07:54 | caristu | Regression date | => 2023-10-17 |
| 2024-02-09 07:54 | caristu | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f35ca078047b33682c70833de0bf1f3d84463b49 [^] |
| 2024-02-09 07:54 | caristu | Relationship added | caused by 0053576 |
| 2024-02-09 07:55 | caristu | Status | new => scheduled |
| 2024-02-09 09:16 | hgbot | Note Added: 0160525 | |
| 2024-02-12 16:19 | hgbot | Resolution | open => fixed |
| 2024-02-12 16:19 | hgbot | Status | scheduled => closed |
| 2024-02-12 16:19 | hgbot | Fixed in Version | => 24Q1 |
| 2024-02-12 16:19 | hgbot | Note Added: 0160636 | |
| 2024-02-12 16:20 | hgbot | Note Added: 0160637 | |
| 2024-02-12 16:20 | hgbot | Fixed in Version | 24Q1 => 24Q2 |
| 2024-02-12 16:20 | hgbot | Note Added: 0160638 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |