Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0054513
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSminorhave not tried2024-01-16 14:492024-02-01 10:07
ReporterlmonrealView Statuspublic 
Assigned Tosreehari 
PrioritynormalResolutionfixedFixed in Version24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version24Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054513: Approvals are not working for "Apply Discretionary and Optional Discount" user action under some specific circumstances

DescriptionThe user action "Apply Discretionary and Optional Discount" whose internal code is "OBPOS2_SetLineDiscounts" is not managing approvals correctly
Steps To ReproduceThe user action "Apply Discretionary and Optional Discount" which internal code is "OBPOS2_SetLineDiscounts" is not working

PRE:
Configure POS2 to use vallblanca manual role using vallbalnca user

- Login to the office using Openbravo/openbravo and connect to "White valley"
- In backoffice go to user vallblanca and select "VallBlancaManual" as the default role to be used for POS2 (Header -> more information -> default POS Role)
- Go to the role "VallBlancaManual" and add the following user actions to allow to use POS2 normally
    - Finish Initial Count
    - Standard initial count
    - Validate Cashup count and advance to next step
    - SwitchToLineDiscountPanel
    - SetDefaultSchema

- Additionaly configure the user action "Apply Discretionary and Optional Discount" as:
  - Confirmation Required: False
  - Approval: Approval Required
  - Input Request Type: Never
  - Active: yes

- Go to the role "Group - Admin" (the one used by demouser) and add the user actions "Apply Discretionary and Optional Discount" to allow to approve the usage of it with below information.
  - Confirmation Required: False
  - Approval: Can Use and Approve
  - Input Request Type: Never
  - Active: yes


STEPS TO REPRODUCE
1 Login in pos
2 Add two items to the order
3 press in one item
4 In the popover press "Discounts"
5 Having selected one line
  - Select "disc_fixed_5_perc"
  - press apply
    Error 1 -> KO! Approval does not appear
6 Remove order
7 Add two items to the new order
8 press in one item
9 In the popover press "Discounts"
10 Having selected two lines
  - Select "disc_fixed_5_perc"
  - press apply
    error 2 -> KO! Approval does not appear



Note:
If in the back office the discount "disc_fixed_5_perc" is marked as "Approval Required = true" and we repeat the above steps (after login in pos2 and executing refresh master data)
 Error 1 is not reproducible -> approval is shown -> Can be approved by using "demouser/openbravo"

This is wrong because this scenario reveals that approval only works well when a discount with approval is being used.

  Error 2 becomes different: Now A first popup appears asking for data "Data required" and after pressing "next" the correct approval appears


Summary:
1. When a user action to apply a discretionary discount requires approval it should appear without depending on the discount that is applied
2. When user action to apply a discretionary discount does not require approval but we are using at least one discount that requires approval Approval should appear
3. The Data required popup which appears when several lines are selected should not appear
Proposed SolutionAccording to the spec of RM-4672 (https://docs.google.com/document/d/1LabC70jbdRc2fIxC_2ODDpzUazjphCyGv8AUalrf9nU/edit [^])
Approval only will be shown when
1. User action is configured to show approval
2. any discount involved is marked as "approval required"
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0054363 closedsreehari Approvals are not working for "Apply Discretionary and Optional Discount" user action under some specific circumstances 

-  Notes
(0160050)
hgbot (developer)
2024-02-01 08:12

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1352 [^]
(0160051)
hgbot (developer)
2024-02-01 08:15

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2388 [^]
(0160060)
hgbot (developer)
2024-02-01 10:07

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c8f1b6558bff951eec0a4e9d8e64d25affea66b3
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 01-02-2024 09:07:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c8f1b6558bff951eec0a4e9d8e64d25affea66b3 [^]

Fixes ISSUE-54513: Fix wrong data input/approvals requests when applying discounts

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/SetLineDiscounts.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/__test__/SetLineDiscountsUserAction.test.js
---
(0160061)
hgbot (developer)
2024-02-01 10:07

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2388 [^]
(0160062)
hgbot (developer)
2024-02-01 10:07

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 8eddd4541c4d35b0b51593e7d5aef56ec4cbaacf
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 01-02-2024 09:07:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/8eddd4541c4d35b0b51593e7d5aef56ec4cbaacf [^]

Related ISSUE-54513: Fixed case when input request is Never

---
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
---
(0160063)
hgbot (developer)
2024-02-01 10:07

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1352 [^]

- Issue History
Date Modified Username Field Change
2024-01-31 09:01 guilleaer Type defect => backport
2024-01-31 09:01 guilleaer Target Version => 24Q1
2024-02-01 08:12 hgbot Note Added: 0160050
2024-02-01 08:15 hgbot Note Added: 0160051
2024-02-01 10:07 hgbot Resolution open => fixed
2024-02-01 10:07 hgbot Status scheduled => closed
2024-02-01 10:07 hgbot Fixed in Version => 24Q1
2024-02-01 10:07 hgbot Note Added: 0160060
2024-02-01 10:07 hgbot Note Added: 0160061
2024-02-01 10:07 hgbot Note Added: 0160062
2024-02-01 10:07 hgbot Note Added: 0160063

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker