Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0054352
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Retail APImajoralways2024-01-16 08:392024-04-09 15:33
ReportervmromanosView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in VersionRR24Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelProduction - QA Approved
Regression date2023-07-04
Regression introduced in releaseRR23Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/commit/fb7f20945b879d9c51a84eb565d856803cb4ce07 [^]
Triggers an Emergency PackNo
Summary

0054352: Distribution Order API wrongly depends on AWO module - OBDOAPI_UpdateDOQuant is replaced by the OBDOAPI_UpdateDOQuantities event

DescriptionDistribution Order API module shouldn't depend on AWO, as a Distribution Order might work also outside AWO.

In 0052774 this dependency was wrongly entered to introduce a new event OBDOAPI_SendDOAfterGroupConfirmation, which doesn't actually tackle the root cause of 0052774.
Steps To ReproduceTry to install Distribution Order API without AWO.
A compilation error appears due to dependency to class PostConfirmGroupOfTasksHook
Proposed Solution1. Revert https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/commit/fb7f20945b879d9c51a84eb565d856803cb4ce07 [^]
This represents an API change, as we are removing the OBDOAPI_SendDOAfterGroupConfirmation event, but we should manage it right now.

2. Fix the code to make sure the "Update Distribution Order quantities through goods movement" is executed just one time per Distribution Order

3. Talk to the customer using the OBDOAPI_SendDOAfterGroupConfirmation event and coordinate it with him to use again the "Update Distribution Order quantities through goods movement" that should work fine after the fix
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by design defect 0052774 closedTriage Omni WMS [RM-7065] API event" Update Distribution Order quantities through goods movement" is sending the DO as many times as #lines 

-  Notes
(0159356)
vmromanos (developer)
2024-01-16 10:44

 Test plan:

Preconfiguration:
Create a event subscription to "Update Distribution Order quantities through goods movement" The external system can be https://webhook.site/ [^]


A) Group of Task confirmation
In AWO backend :
1. Create a DOi with two lines
2. Pick the lines
3. Confirm the picking list
4. Create the Issue
5. Confirm the Issue List as a group. Check the event is launched just one time.
6. Go to the DOr and create the Reception.
7. Confirm the Reception List as a group. Check the event is launched just one time.


B) Individual Task confirmation
In AWO backend :
1. Create a DOi with two lines
2. Pick the lines
3. Confirm the picking list
4. Create the Issue
5. Confirm the just one task. Check the event is launched just one time with the "issuedQuantity" modified
6. Go to the DOr and create the Reception.
7. Confirm the task. Check the event is launched just one time with the "receivedQuantity" modified
(0159357)
hgbot (developer)
2024-01-16 10:45

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/merge_requests/26 [^]
(0159358)
hgbot (developer)
2024-01-16 10:46

 Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/58 [^]
(0159359)
hgbot (developer)
2024-01-16 10:47

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/211 [^]
(0159360)
hgbot (developer)
2024-01-16 10:48

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/116 [^]
(0162735)
mtaal (manager)
2024-03-28 08:36

 Test plan for the module script:
1) Before installing/using the new MRs, create event subscription using the event which will be removed in this change set (is event: Update Distribution Order after Group Confirmation)
2) Install the fixes in all 4 modules
3) Check that the event subscription has been moved to the event: Update Distribution Order quantities through goods movement
(0162736)
hgbot (developer)
2024-03-28 08:50

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/merge_requests/26 [^]
(0162737)
hgbot (developer)
2024-03-28 08:50

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api [^]
Changeset: f63560b7932236d8a95db2a0f93464f0157373a0
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 28-03-2024 07:50:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/commit/f63560b7932236d8a95db2a0f93464f0157373a0 [^]

Fixed ISSUE-54352: Revert OBDOAPI_UpdateDOQuantitiesGroup event

---
A build/classes/org/openbravo/distributionorder/api/modulescript/ReplaceRemovedDOEvent.class
A src-util/modulescript/src/org/openbravo/distributionorder/api/modulescript/ReplaceRemovedDOEvent.java
M src-db/database/sourcedata/CNC_PUBLIC_EVENTS.xml
R src/org/openbravo/distributionorder/api/push/UpdateDOQuantitiesGroupOfTasksEvent.java
---
(0162738)
hgbot (developer)
2024-03-28 08:50

 Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/58 [^]
(0162739)
hgbot (developer)
2024-03-28 08:50

 Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^]
Changeset: 7e2693d89af7c012cd1937323af778e4e650e9b1
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 28-03-2024 07:50:37
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/7e2693d89af7c012cd1937323af778e4e650e9b1 [^]

Related to ISSUE-54352: afterUpdateDOFromGoodsMovement execution level

---
M src/org/openbravo/distributionorder/erpCommon/utility/DistributioOrderUtils.java
---
(0162740)
hgbot (developer)
2024-03-28 08:51

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/211 [^]
(0162741)
hgbot (developer)
2024-03-28 08:51

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: e578dc5f26505c292cbfb2628cf3957343d1731c
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 28-03-2024 07:51:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/e578dc5f26505c292cbfb2628cf3957343d1731c [^]

Related to ISSUE-54352: added function to allow logic to identify if confirmation happens for a grouped task

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/hooks/PostConfirmTaskHook.java
---
(0162742)
hgbot (developer)
2024-03-28 08:53

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders [^]
Changeset: e98f6214700186b343143c3b7a86dd5f2a639a72
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 28-03-2024 07:53:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/commit/e98f6214700186b343143c3b7a86dd5f2a639a72 [^]

Fixed ISSUE-54352: generate one header update event for a distribution orders even if confirmation happens for multiple tasks in the DO

---
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/DistributionOrderPostConfirmGroupOfTasksHook.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/taskhook/IssueAndReceiptDistributionOrderPostConfirmTaskHook.java
---
(0162743)
hgbot (developer)
2024-03-28 08:53

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/116 [^]
(0162744)
mtaal (manager)
2024-03-28 09:12

 Updated docs here:
https://wiki.openbravo.com/wiki/Push_API#Standard_Business_API_Events [^]

- Issue History
Date Modified Username Field Change
2024-01-16 08:39 vmromanos New Issue
2024-01-16 08:39 vmromanos Assigned To => vmromanos
2024-01-16 08:39 vmromanos Regression level => Production - QA Approved
2024-01-16 08:39 vmromanos Regression date => 2023-07-04
2024-01-16 08:39 vmromanos Regression introduced in release => RR23Q4
2024-01-16 08:39 vmromanos Triggers an Emergency Pack => No
2024-01-16 08:40 vmromanos Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/commit/fb7f20945b879d9c51a84eb565d856803cb4ce07 [^]
2024-01-16 08:40 vmromanos Relationship added caused by 0052774
2024-01-16 09:15 vmromanos Status new => scheduled
2024-01-16 10:44 vmromanos Note Added: 0159356
2024-01-16 10:45 hgbot Note Added: 0159357
2024-01-16 10:46 hgbot Note Added: 0159358
2024-01-16 10:47 hgbot Note Added: 0159359
2024-01-16 10:48 hgbot Note Added: 0159360
2024-01-23 22:33 axelmercado Issue Monitored: axelmercado
2024-03-28 08:36 mtaal Note Added: 0162735
2024-03-28 08:50 hgbot Note Added: 0162736
2024-03-28 08:50 hgbot Resolution open => fixed
2024-03-28 08:50 hgbot Status scheduled => closed
2024-03-28 08:50 hgbot Note Added: 0162737
2024-03-28 08:50 hgbot Note Added: 0162738
2024-03-28 08:50 hgbot Note Added: 0162739
2024-03-28 08:51 hgbot Note Added: 0162740
2024-03-28 08:51 hgbot Note Added: 0162741
2024-03-28 08:53 hgbot Note Added: 0162742
2024-03-28 08:53 hgbot Note Added: 0162743
2024-03-28 09:12 mtaal Note Added: 0162744
2024-04-09 15:32 mtaal Fixed in Version => RR24Q2
2024-04-09 15:33 mtaal Summary Distribution Order API wrongly depends on AWO module => Distribution Order API wrongly depends on AWO module - OBDOAPI_UpdateDOQuant is replaced by the OBDOAPI_UpdateDOQuantities event

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker