Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054337 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2024-01-12 15:13 | 2024-01-18 17:34 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | ablasco | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | PR24Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | 2023-10-17 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/openbravo/-/commit/276992c1ff21c2babfa16573c66be987965afdd2 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054337: Some computed column fields are displayed as editable for automatic roles | |||||||
| Description | Fields backed by computed columns and not explicitly marked as read only are displayed as editable for automatic roles. By definition, this kind of fields must always be displayed as read only. Note: this issue can be easily workarounded by explicitly marking the field as read only | |||||||
| Steps To Reproduce | 1) Create a computed column[1]. Leave the column definition as updateable. 2) Create a field for the new computed column. Do not explicitly mark it as read only, it should not be necessary 3) Access to the window with the new field, with an automatic role. Note that the computed column is displayed as non read only. [1] http://wiki.openbravo.com/wiki/How_to_create_a_Computed_Column [^] | |||||||
| Proposed Solution | The source of the problem is here[1]. Now that code is causing the getFieldLevelRoles method to be executed always when accessing to a window with an automatic role. This did not happen before. It must be checked if this is correct or not. If the previous is correct, one possible solution could be just to add here[2] this check: field.getColumn().getSqllogic() == null [1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java#L172 [^] [2] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java#L209 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0159345) hgbot (developer) 2024-01-16 08:47 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1104 [^] |
|
(0159490) hgbot (developer) 2024-01-18 17:34 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: f0d7953bcdea40fc73c91d3cfba5d8534e28381d Author: Adrián Blasco <adrian.blasco@openbravo.com> Date: 18-01-2024 16:34:13 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/f0d7953bcdea40fc73c91d3cfba5d8534e28381d [^] Fixes ISSUE-54337: Computed Column Fields are displayed as Editable for Auto Roles --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java --- |
|
(0159491) hgbot (developer) 2024-01-18 17:34 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1104 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-01-12 15:13 | caristu | New Issue | |
| 2024-01-12 15:13 | caristu | Assigned To | => Triage Platform Base |
| 2024-01-12 15:13 | caristu | Modules | => Core |
| 2024-01-12 15:13 | caristu | Triggers an Emergency Pack | => No |
| 2024-01-12 15:19 | caristu | Proposed Solution updated | |
| 2024-01-12 15:20 | caristu | Relationship added | caused by 0053408 |
| 2024-01-12 15:23 | caristu | Regression date | => 2023-10-17 |
| 2024-01-12 15:23 | caristu | Regression introduced by commit | => https://gitlab.com/openbravo/product/openbravo/-/commit/276992c1ff21c2babfa16573c66be987965afdd2 [^] |
| 2024-01-12 15:24 | caristu | Description Updated | View Revisions |
| 2024-01-12 15:34 | caristu | Steps to Reproduce Updated | View Revisions |
| 2024-01-16 08:47 | hgbot | Note Added: 0159345 | |
| 2024-01-16 10:00 | cberner | Status | new => scheduled |
| 2024-01-16 10:00 | cberner | Assigned To | Triage Platform Base => ablasco |
| 2024-01-18 17:34 | hgbot | Resolution | open => fixed |
| 2024-01-18 17:34 | hgbot | Status | scheduled => closed |
| 2024-01-18 17:34 | hgbot | Fixed in Version | => PR24Q2 |
| 2024-01-18 17:34 | hgbot | Note Added: 0159490 | |
| 2024-01-18 17:34 | hgbot | Note Added: 0159491 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |