Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0054243
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2024-01-02 17:292024-01-31 08:44
Reportercharlotte_vasseurView Statuspublic 
Assigned ToRajesh_18 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054243: Issue Invoice on a Gift Card Ticket is possible (and creates new gift card numbers on templates)

DescriptionAfter doing a sale with a customer assigned of gift card that uses automatic sequence, it is possible to issue invoice on the gift card ticket
On the new printed tickets, new gift card numbers are displayed even if they don't exist in BO
Steps To ReproduceAfter creating a product gift card that uses automatic sequence (see GC product BO.png)

In POS, create a sale with a customer assigned
Add several gift cards products
Finalize the sale
In HWM, one template is printed for each gift card with number assigned
(See Ticket sale 01.png and Tickets GC 01.png)

In POS, go to Orders
Click on the 3 dots on the previous sale
Select 'Issue Invoice'
=> It is possible to issue invoice on a gift card ticket, no error is displayed
Finalize the invoice
=> In HWM, one template is printed for each gift card but new numbers are assigned even if they don't exist in BO and are not usable
(See GC BO.png, Ticket invoice 02.png and Tickets GC 02.png)
Proposed SolutionIt should not be possible to issue invoice on gift card ticket
TagsNo tags attached.
Attached Filespng file icon GC product BO.png [^] (118,678 bytes) 2024-01-02 17:29


png file icon Ticket sale 01.png [^] (56,026 bytes) 2024-01-02 17:29


png file icon Tickets GC 01.png [^] (136,165 bytes) 2024-01-02 17:29


png file icon GC BO.png [^] (81,017 bytes) 2024-01-02 17:30


png file icon Ticket invoice 02.png [^] (53,311 bytes) 2024-01-02 17:30


png file icon Tickets GC 02.png [^] (137,804 bytes) 2024-01-02 17:30


png file icon Issue invoice GC.png [^] (113,226 bytes) 2024-01-05 16:41

- Relationships Relation Graph ] Dependency Graph ]
depends on defect 0053180 closedRajesh_18 'Issue Order' is disabled if view it from the 'Orders' 

-  Notes
(0158898)
charlotte_vasseur (reporter)
2024-01-05 16:40

FYI it is also possible to issue invoice directly when selling the gift card (see Issue invoice GC.png)
(0159877)
hgbot (developer)
2024-01-29 14:03

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/295 [^]
(0159878)
Rajesh_18 (developer)
2024-01-29 14:11

I have fixed creation of new gift card numbers.
The Issue Invoice is fixed in https://issues.openbravo.com/view.php?id=54266 [^]
(0159964)
hgbot (developer)
2024-01-31 08:44

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/295 [^]
(0159965)
hgbot (developer)
2024-01-31 08:44

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 8230034ceb7cc9a869f2a8b770659a3e1964fd91
Author: Rajesh Senthilkumar <rajesh.senthilkumar.ext@openbravo.com>
Date: 31-01-2024 07:44:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/8230034ceb7cc9a869f2a8b770659a3e1964fd91 [^]

Fixed ISSUE-54243: Reprint of Gift card with new sequence is prevented

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CalculateGiftCardSequenceCompleteTicketPreHook.js
---

- Issue History
Date Modified Username Field Change
2024-01-02 17:29 charlotte_vasseur New Issue
2024-01-02 17:29 charlotte_vasseur Assigned To => Retail
2024-01-02 17:29 charlotte_vasseur File Added: GC product BO.png
2024-01-02 17:29 charlotte_vasseur Triggers an Emergency Pack => No
2024-01-02 17:29 charlotte_vasseur File Added: Ticket sale 01.png
2024-01-02 17:29 charlotte_vasseur File Added: Tickets GC 01.png
2024-01-02 17:30 charlotte_vasseur File Added: GC BO.png
2024-01-02 17:30 charlotte_vasseur File Added: Ticket invoice 02.png
2024-01-02 17:30 charlotte_vasseur File Added: Tickets GC 02.png
2024-01-04 07:28 rafaroda Priority normal => high
2024-01-05 14:17 Rajesh_18 Assigned To Retail => Rajesh_18
2024-01-05 16:40 charlotte_vasseur Note Added: 0158898
2024-01-05 16:41 charlotte_vasseur File Added: Issue invoice GC.png
2024-01-09 13:41 Rajesh_18 Relationship added depends on 0053180
2024-01-10 12:31 Rajesh_18 Status new => scheduled
2024-01-29 14:03 hgbot Note Added: 0159877
2024-01-29 14:11 Rajesh_18 Note Added: 0159878
2024-01-31 08:44 hgbot Note Added: 0159964
2024-01-31 08:44 hgbot Resolution open => fixed
2024-01-31 08:44 hgbot Status scheduled => closed
2024-01-31 08:44 hgbot Note Added: 0159965


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker