Openbravo Issue Tracking System - POS2
View Issue Details
0054243POS2POSpublic2024-01-02 17:292024-01-31 08:44
charlotte_vasseur 
Rajesh_18 
highmajoralways
closedfixed 
5
 
 
No
0054243: Issue Invoice on a Gift Card Ticket is possible (and creates new gift card numbers on templates)
After doing a sale with a customer assigned of gift card that uses automatic sequence, it is possible to issue invoice on the gift card ticket
On the new printed tickets, new gift card numbers are displayed even if they don't exist in BO
After creating a product gift card that uses automatic sequence (see GC product BO.png)

In POS, create a sale with a customer assigned
Add several gift cards products
Finalize the sale
In HWM, one template is printed for each gift card with number assigned
(See Ticket sale 01.png and Tickets GC 01.png)

In POS, go to Orders
Click on the 3 dots on the previous sale
Select 'Issue Invoice'
=> It is possible to issue invoice on a gift card ticket, no error is displayed
Finalize the invoice
=> In HWM, one template is printed for each gift card but new numbers are assigned even if they don't exist in BO and are not usable
(See GC BO.png, Ticket invoice 02.png and Tickets GC 02.png)
It should not be possible to issue invoice on gift card ticket
No tags attached.
depends on defect 0053180 closed Rajesh_18 'Issue Order' is disabled if view it from the 'Orders' 
png GC product BO.png (118,678) 2024-01-02 17:29
https://issues.openbravo.com/file_download.php?file_id=19273&type=bug
png

png Ticket sale 01.png (56,026) 2024-01-02 17:29
https://issues.openbravo.com/file_download.php?file_id=19274&type=bug
png

png Tickets GC 01.png (136,165) 2024-01-02 17:29
https://issues.openbravo.com/file_download.php?file_id=19275&type=bug
png

png GC BO.png (81,017) 2024-01-02 17:30
https://issues.openbravo.com/file_download.php?file_id=19276&type=bug
png

png Ticket invoice 02.png (53,311) 2024-01-02 17:30
https://issues.openbravo.com/file_download.php?file_id=19277&type=bug
png

png Tickets GC 02.png (137,804) 2024-01-02 17:30
https://issues.openbravo.com/file_download.php?file_id=19278&type=bug
png

png Issue invoice GC.png (113,226) 2024-01-05 16:41
https://issues.openbravo.com/file_download.php?file_id=19284&type=bug
png
Issue History
2024-01-02 17:29charlotte_vasseurNew Issue
2024-01-02 17:29charlotte_vasseurAssigned To => Retail
2024-01-02 17:29charlotte_vasseurFile Added: GC product BO.png
2024-01-02 17:29charlotte_vasseurTriggers an Emergency Pack => No
2024-01-02 17:29charlotte_vasseurFile Added: Ticket sale 01.png
2024-01-02 17:29charlotte_vasseurFile Added: Tickets GC 01.png
2024-01-02 17:30charlotte_vasseurFile Added: GC BO.png
2024-01-02 17:30charlotte_vasseurFile Added: Ticket invoice 02.png
2024-01-02 17:30charlotte_vasseurFile Added: Tickets GC 02.png
2024-01-04 07:28rafarodaPrioritynormal => high
2024-01-05 14:17Rajesh_18Assigned ToRetail => Rajesh_18
2024-01-05 16:40charlotte_vasseurNote Added: 0158898
2024-01-05 16:41charlotte_vasseurFile Added: Issue invoice GC.png
2024-01-09 13:41Rajesh_18Relationship addeddepends on 0053180
2024-01-10 12:31Rajesh_18Statusnew => scheduled
2024-01-29 14:03hgbotNote Added: 0159877
2024-01-29 14:11Rajesh_18Note Added: 0159878
2024-01-31 08:44hgbotNote Added: 0159964
2024-01-31 08:44hgbotResolutionopen => fixed
2024-01-31 08:44hgbotStatusscheduled => closed
2024-01-31 08:44hgbotNote Added: 0159965

Notes
(0158898)
charlotte_vasseur   
2024-01-05 16:40   
FYI it is also possible to issue invoice directly when selling the gift card (see Issue invoice GC.png)
(0159877)
hgbot   
2024-01-29 14:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/295 [^]
(0159878)
Rajesh_18   
2024-01-29 14:11   
I have fixed creation of new gift card numbers.
The Issue Invoice is fixed in https://issues.openbravo.com/view.php?id=54266 [^]
(0159964)
hgbot   
2024-01-31 08:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/295 [^]
(0159965)
hgbot   
2024-01-31 08:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 8230034ceb7cc9a869f2a8b770659a3e1964fd91
Author: Rajesh Senthilkumar <rajesh.senthilkumar.ext@openbravo.com>
Date: 31-01-2024 07:44:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/8230034ceb7cc9a869f2a8b770659a3e1964fd91 [^]

Fixed ISSUE-54243: Reprint of Gift card with new sequence is prevented

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CalculateGiftCardSequenceCompleteTicketPreHook.js
---