Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0054177
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorN/A2023-12-20 11:562023-12-29 12:17
Reportergorka_gilView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054177: pos2 otf: review usage of ticket.businessPartner

Descriptionticket.businessPartner it should not be used in pos2,
it should be used ticket.externalBusinessPartner

in pos2 it will be always an external bp, it will be never a local bp,
the local bps are served in an internal crm that also fills the ticket.businessPartner but real crm will have it with the anonimous customer

at some moment ticket.businessPartner will dissapear from pos2
Steps To Reproducesearch in otf repos folders that ticket.businessPartner it is not used
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0053930 closedranjith_qualiantech_com Nominal coupons is not working because of the BP id. 

-  Notes
(0158710)
hgbot (developer)
2023-12-29 08:08

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/38 [^]
(0158711)
hgbot (developer)
2023-12-29 08:08

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/39 [^]
(0158724)
hgbot (developer)
2023-12-29 12:17

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: e54b1ef13e6e3433f509b41d5af3ed0feca100c2
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 28-12-2023 08:47:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/e54b1ef13e6e3433f509b41d5af3ed0feca100c2 [^]

Related to ISSUE-54177: Updated anonymous customer validation using externalBP

---
M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/CouponsPanelGrid.jsx
---
(0158725)
hgbot (developer)
2023-12-29 12:17

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/38 [^]
(0158726)
hgbot (developer)
2023-12-29 12:17

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 8a536dfc925e0e76f1b6113b946fec3394e13fe5
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 29-12-2023 12:37:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/8a536dfc925e0e76f1b6113b946fec3394e13fe5 [^]

Fixed ISSUE-54177: Updated anonymous customer validation using externalBP
* OTFRule businessPartner category should be validated with externalBP bpCategory

---
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/__test__/CreateCoupons.test.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/CreateCoupons.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/GetCouponsThatApplyToTicket.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/GetCouponsThatApplyToTicketDBHelper.js
---
(0158727)
hgbot (developer)
2023-12-29 12:17

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/39 [^]

- Issue History
Date Modified Username Field Change
2023-12-20 11:56 gorka_gil New Issue
2023-12-20 11:56 gorka_gil Assigned To => ranjith_qualiantech_com
2023-12-20 11:56 gorka_gil Triggers an Emergency Pack => No
2023-12-22 12:38 ranjith_qualiantech_com Status new => scheduled
2023-12-29 08:08 hgbot Note Added: 0158710
2023-12-29 08:08 hgbot Note Added: 0158711
2023-12-29 12:17 hgbot Note Added: 0158724
2023-12-29 12:17 hgbot Note Added: 0158725
2023-12-29 12:17 hgbot Resolution open => fixed
2023-12-29 12:17 hgbot Status scheduled => closed
2023-12-29 12:17 hgbot Note Added: 0158726
2023-12-29 12:17 hgbot Note Added: 0158727
2024-01-10 14:58 rafaroda Relationship added related to 0053930


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker