Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0054133

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2023-12-14 11:01

2024-01-10 15:07

Reporter

gorkaion

View Status

public

Assigned To

sreehari

Priority

high

Resolution

fixed

Fixed in Version

RR24Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0054133: Process to deactivate expired promotions deactivates promotions ending today

Description

The ‘Deactivate Expired Discounts and Promotions’ background process is deactivating the promotions that ends in the same date than the process is executed.

The end date of the promotion is stored with no time part (2023-12-14 00:00:00)

When the process is executed the filter is defined as WHERE p.endingDate < :currentDate"

Since "new Date()" is set that means that we are filtering "2023-12-14 00:00:00 < 2023-12-14 11:00:00" so it deactivates promotions ending today when it shouldn't

Steps To Reproduce

Create a new promotion with ending date today.
Execute the deactivate promotions process
Check the promotion is wrongly deactivated.

Proposed Solution

change the date set on the filter to be current date with no time part.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	feature request	0053596		closed	jose12L	Process to deactivate expired promotions
has duplicate	defect	0054341		closed	Retail	[PROMO] Deactivate Promotions process deactivate promotion that expires today

Notes
(0158241) hgbot (developer) 2023-12-15 06:47	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1429 [^]

(0159056) hgbot (developer) 2024-01-10 15:07	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: a85fc65b4db71bc4b2268727f7d1a9988364dff0 Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com> Date: 10-01-2024 14:45:49 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a85fc65b4db71bc4b2268727f7d1a9988364dff0 [^] Fixes ISSUE-54133: Used DateUtils to truncate Date and Filter Discounts --- M src/org/openbravo/retail/posterminal/process/DeactivateExpiredDiscounts.java ---

(0159057) hgbot (developer) 2024-01-10 15:07	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1429 [^]

Issue History
Date Modified	Username	Field	Change
2023-12-14 11:01	gorkaion	New Issue
2023-12-14 11:01	gorkaion	Assigned To	=> jose12L
2023-12-14 11:01	gorkaion	Triggers an Emergency Pack	=> No
2023-12-14 11:01	gorkaion	Issue generated from	0053596
2023-12-14 11:01	gorkaion	Relationship added	related to 0053596
2023-12-14 11:36	marvintm	Type	feature request => defect
2023-12-14 11:38	sreehari	Assigned To	jose12L => sreehari
2023-12-15 06:41	sreehari	Status	new => scheduled
2023-12-15 06:47	hgbot	Note Added: 0158241
2024-01-10 15:07	hgbot	Resolution	open => fixed
2024-01-10 15:07	hgbot	Status	scheduled => closed
2024-01-10 15:07	hgbot	Fixed in Version	=> RR24Q2
2024-01-10 15:07	hgbot	Note Added: 0159056
2024-01-10 15:07	hgbot	Note Added: 0159057
2024-01-30 17:52	aaroncalero	Relationship added	has duplicate 0054341

Copyright © 2000 - 2009 MantisBT Group