Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0054081
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2023-12-07 09:332023-12-15 08:32
ReportershuehnerView Statuspublic 
Assigned ToTriage Platform Base 
PriorityimmediateResolutionfixedFixed in VersionPR24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelCoding ( Testing )
Regression date2023-11-30
Regression introduced in releasepi
Regression introduced by commit https://gitlab.com/openbravo/product/openbravo/-/commit/2432bd6c0d739d88b0068ae4dff44eff1846cef2 [^]
Triggers an Emergency PackNo
Summary

0054081: Regression: Number of database connection kept open in idle tomcat went up by +10

DescriptionNumber of database connection kept in pool (in status idle) went up by ca. +10 recently.

Problem was discovered on 1st of December (livebuilds outage) via hitting indirectly maximum number of allowed db connection.

Looking at number of connection per context it only affects ones based on git master (but not any release)

Connection details of those +10 connection (same for all):
- status idle
- Last query executed:
   SET Updated = NOW(), UpdatedBy = $1, Status = $2, End_Time = NOW(), Runtime = $3, Log = $4 WHERE AD_Process_Run_ID = $5
Steps To ReproduceVisible in livebuilds
Likely reproducible by just starting tomcat and:
- check connections after quartz started
- or wait until each of the 10 default quartz threads picked up 1 job
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0054029 closedAugustoMauch Connection leak when using scheduling process requests based on process groups 
related to defect 0054090 closedalostale connection leak on Tomcat start if a process is missfired 

-  Notes
(0157994)
shuehner (administrator)
2023-12-07 09:34

 Candidate change for causing this:
- Issue https://issues.openbravo.com/view.php?id=54029 [^]
(0158194)
hgbot (developer)
2023-12-14 10:17

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1076 [^]
(0158248)
hgbot (developer)
2023-12-15 08:32

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1076 [^]
(0158249)
hgbot (developer)
2023-12-15 08:32

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 53bf50ede6704f25851da724e1e8a9040b1b827c
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 15-12-2023 07:31:39
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/53bf50ede6704f25851da724e1e8a9040b1b827c [^]

fixes BUG-54081: one DB connection leaked per each background thread

Each thread in charge of executing background processes leaked a DB connection
which was not returned to the pool on finalization. Commit 2432bd6c0d
(BUG-54029) prevents leaking connections handled by DAL, but it removed the code
in charge of returning non-DAL ConnectionProvider connections.

This code has now been recovered keeping also the one dealing with DAL
connections.

---
M src/org/openbravo/scheduling/ProcessMonitor.java
---

- Issue History
Date Modified Username Field Change
2023-12-07 09:33 shuehner New Issue
2023-12-07 09:33 shuehner Assigned To => Triage Platform Base
2023-12-07 09:33 shuehner Modules => Core
2023-12-07 09:33 shuehner Regression level => Coding ( Testing )
2023-12-07 09:33 shuehner Triggers an Emergency Pack => No
2023-12-07 09:34 shuehner Note Added: 0157994
2023-12-07 11:40 alostale Priority normal => immediate
2023-12-08 04:24 priyam Issue Monitored: priyam
2023-12-11 09:25 alostale Relationship added caused by 0054029
2023-12-11 09:26 alostale Regression date => 2023-11-30
2023-12-11 09:26 alostale Regression introduced in release => pi
2023-12-11 09:26 alostale Regression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/2432bd6c0d739d88b0068ae4dff44eff1846cef2 [^]
2023-12-11 09:36 alostale Relationship added related to 0054090
2023-12-14 10:17 hgbot Note Added: 0158194
2023-12-15 08:32 hgbot Resolution open => fixed
2023-12-15 08:32 hgbot Status new => closed
2023-12-15 08:32 hgbot Note Added: 0158248
2023-12-15 08:32 hgbot Fixed in Version => PR24Q1
2023-12-15 08:32 hgbot Note Added: 0158249

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker