Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054081Openbravo ERPA. Platformpublic2023-12-07 09:332023-12-15 08:32
Reportershuehner 
Assigned ToTriage Platform Base 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelCoding ( Testing )
Regression date2023-11-30
Regression introduced in releasepi
Regression introduced by commit https://gitlab.com/openbravo/product/openbravo/-/commit/2432bd6c0d739d88b0068ae4dff44eff1846cef2 [^]
Triggers an Emergency PackNo
Summary0054081: Regression: Number of database connection kept open in idle tomcat went up by +10
DescriptionNumber of database connection kept in pool (in status idle) went up by ca. +10 recently.

Problem was discovered on 1st of December (livebuilds outage) via hitting indirectly maximum number of allowed db connection.

Looking at number of connection per context it only affects ones based on git master (but not any release)

Connection details of those +10 connection (same for all):
- status idle
- Last query executed:
   SET Updated = NOW(), UpdatedBy = $1, Status = $2, End_Time = NOW(), Runtime = $3, Log = $4 WHERE AD_Process_Run_ID = $5
Steps To ReproduceVisible in livebuilds
Likely reproducible by just starting tomcat and:
- check connections after quartz started
- or wait until each of the 10 default quartz threads picked up 1 job
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0054029 closed AugustoMauch Connection leak when using scheduling process requests based on process groups 
related to defect 0054090 closed alostale connection leak on Tomcat start if a process is missfired 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-12-07 09:33shuehnerNew Issue
2023-12-07 09:33shuehnerAssigned To => Triage Platform Base
2023-12-07 09:33shuehnerOBNetwork customer => No
2023-12-07 09:33shuehnerModules => Core
2023-12-07 09:33shuehnerRegression level => Coding ( Testing )
2023-12-07 09:33shuehnerTriggers an Emergency Pack => No
2023-12-07 09:34shuehnerNote Added: 0157994
2023-12-07 11:40alostalePrioritynormal => immediate
2023-12-08 04:24priyamIssue Monitored: priyam
2023-12-11 09:25alostaleRelationship addedcaused by 0054029
2023-12-11 09:26alostaleRegression date => 2023-11-30
2023-12-11 09:26alostaleRegression introduced in release => pi
2023-12-11 09:26alostaleRegression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/2432bd6c0d739d88b0068ae4dff44eff1846cef2 [^]
2023-12-11 09:36alostaleRelationship addedrelated to 0054090
2023-12-14 10:17hgbotMerge Request Status => open
2023-12-14 10:17hgbotNote Added: 0158194
2023-12-15 08:31hgbotMerge Request Statusopen => approved
2023-12-15 08:32hgbotResolutionopen => fixed
2023-12-15 08:32hgbotStatusnew => closed
2023-12-15 08:32hgbotNote Added: 0158248
2023-12-15 08:32hgbotFixed in Version => PR24Q1
2023-12-15 08:32hgbotNote Added: 0158249

Notes
(0157994)
shuehner   
2023-12-07 09:34   
Candidate change for causing this:
- Issue https://issues.openbravo.com/view.php?id=54029 [^]
(0158194)
hgbot   
2023-12-14 10:17   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1076 [^]
(0158248)
hgbot   
2023-12-15 08:32   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1076 [^]
(0158249)
hgbot   
2023-12-15 08:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 53bf50ede6704f25851da724e1e8a9040b1b827c
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 15-12-2023 07:31:39
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/53bf50ede6704f25851da724e1e8a9040b1b827c [^]

fixes BUG-54081: one DB connection leaked per each background thread

Each thread in charge of executing background processes leaked a DB connection
which was not returned to the pool on finalization. Commit 2432bd6c0d
(BUG-54029) prevents leaking connections handled by DAL, but it removed the code
in charge of returning non-DAL ConnectionProvider connections.

This code has now been recovered keeping also the one dealing with DAL
connections.

---
M src/org/openbravo/scheduling/ProcessMonitor.java
---