Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054063 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | always | 2023-11-30 17:22 | 2023-12-20 16:29 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | inaki_luque | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054063: [Coupons] Hard-coded error popup titles in discounts.coupons module | |||||||
| Description | Some of the error popups that are raised when a coupon is not valid include a hard-coded title, which makes it impossible to translate. | |||||||
| Steps To Reproduce | Check the popups raised from the actionPreparation https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/blob/master/web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js?ref_type=heads [^] Most of them include a 'Not Applicable Coupon' fixed text. | |||||||
| Proposed Solution | Create a new message for the error title and replace all occurrences. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0157953) hgbot (developer) 2023-12-05 10:12 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/35 [^] |
|
(0158432) hgbot (developer) 2023-12-20 16:29 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^] Changeset: 44d5108fe0eb1be5001914a49ed0be0a38c74e67 Author: Iñaki <inaki.luque@openbravo.com> Date: 20-12-2023 15:29:17 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/44d5108fe0eb1be5001914a49ed0be0a38c74e67 [^] Fixed ISSUE-54063: Creating a new message for the error title and replace all occurrences --- M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js --- |
|
(0158433) hgbot (developer) 2023-12-20 16:29 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/35 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-11-30 17:22 | aaroncalero | New Issue | |
| 2023-11-30 17:22 | aaroncalero | Assigned To | => inaki_luque |
| 2023-11-30 17:22 | aaroncalero | OBNetwork customer | => No |
| 2023-11-30 17:22 | aaroncalero | Triggers an Emergency Pack | => No |
| 2023-12-05 10:12 | hgbot | Merge Request Status | => open |
| 2023-12-05 10:12 | hgbot | Note Added: 0157953 | |
| 2023-12-20 16:29 | hgbot | Merge Request Status | open => approved |
| 2023-12-20 16:29 | hgbot | Resolution | open => fixed |
| 2023-12-20 16:29 | hgbot | Status | new => closed |
| 2023-12-20 16:29 | hgbot | Note Added: 0158432 | |
| 2023-12-20 16:29 | hgbot | Note Added: 0158433 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |