Openbravo Issue Tracking System - POS2
View Issue Details
0054063POS2POSpublic2023-11-30 17:222023-12-20 16:29
aaroncalero 
inaki_luque 
normalminoralways
closedfixed 
5
 
 
approved
No
No
0054063: [Coupons] Hard-coded error popup titles in discounts.coupons module
Some of the error popups that are raised when a coupon is not valid include a hard-coded title, which makes it impossible to translate.
Check the popups raised from the actionPreparation https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/blob/master/web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js?ref_type=heads [^]

Most of them include a 'Not Applicable Coupon' fixed text.
Create a new message for the error title and replace all occurrences.
No tags attached.
Issue History
2023-11-30 17:22aaroncaleroNew Issue
2023-11-30 17:22aaroncaleroAssigned To => inaki_luque
2023-11-30 17:22aaroncaleroOBNetwork customer => No
2023-11-30 17:22aaroncaleroTriggers an Emergency Pack => No
2023-12-05 10:12hgbotMerge Request Status => open
2023-12-05 10:12hgbotNote Added: 0157953
2023-12-20 16:29hgbotMerge Request Statusopen => approved
2023-12-20 16:29hgbotResolutionopen => fixed
2023-12-20 16:29hgbotStatusnew => closed
2023-12-20 16:29hgbotNote Added: 0158432
2023-12-20 16:29hgbotNote Added: 0158433

Notes
(0157953)
hgbot   
2023-12-05 10:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/35 [^]
(0158432)
hgbot   
2023-12-20 16:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: 44d5108fe0eb1be5001914a49ed0be0a38c74e67
Author: IƱaki <inaki.luque@openbravo.com>
Date: 20-12-2023 15:29:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/44d5108fe0eb1be5001914a49ed0be0a38c74e67 [^]

Fixed ISSUE-54063: Creating a new message for the error title and
replace all occurrences

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js
---
(0158433)
hgbot   
2023-12-20 16:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/35 [^]