Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053930 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | critical | always | 2023-11-14 12:52 | 2024-01-10 14:58 | |||
| Reporter | nicolasuriz | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053930: Nominal coupons is not working because of the BP id. | |||||||
| Description | When creating the nominal coupon, if you select and add the Business partner ID but you leave empty the external business partner reference, the addition of the nominal coupon it is not working in WebPOS. I add a photo where the fields cbPartnerId and externalBusinessPartnerReference have the same value and thats why we cannot select a Discount coupon from POS and it is set as invalid coupon avoiding the use of nominal coupons from now on. | |||||||
| Steps To Reproduce | 1. Login Backoffice 2. Create a valid discount Coupon with a business partner associated to it but leaving empty the External business partner reference. 3. Login POS 4. Associate the same BP as it was configured on the discount coupon. 5. Enter on Coupons section to check the available coupons. 6. Select the one created previously and check that it is not possible to add it to the ticket. | |||||||
| Proposed Solution | We have to search the coupons by the filled nominal way of identifying the customer in backoffice, meaning that if the discount coupon has used the Business partner and not the external reference in the configuration, we have to use only the business partner field to search in order to make it work in POS. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Nominal coupons.png [^] (88,322 bytes) 2023-11-14 12:52
image (7).png [^] (98,518 bytes) 2023-12-12 17:52
image (8).png [^] (113,719 bytes) 2023-12-12 17:53
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0157514) hgbot (developer) 2023-11-23 05:14 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/33 [^] |
|
(0157917) hgbot (developer) 2023-12-01 14:28 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/33 [^] |
|
(0157918) hgbot (developer) 2023-12-01 14:28 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^] Changeset: a17ff43b54992e8c70b33130decba4382a152dae Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com> Date: 01-12-2023 13:28:41 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/a17ff43b54992e8c70b33130decba4382a152dae [^] Fixed ISSUE-53930: Ticket info should be used to check the coupon availability --- M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/AvailableCouponsList/AvailableCouponsList.jsx --- |
|
(0158113) kchoperena (developer) 2023-12-12 17:51 |
Still the same problem in livebuilds |
|
(0158127) hgbot (developer) 2023-12-13 09:08 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/37 [^] |
|
(0158207) hgbot (developer) 2023-12-14 12:29 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^] Changeset: 6b85dcc4b97908b4f3669c549dcf7cf7e33dc1d0 Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com> Date: 14-12-2023 11:29:32 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/6b85dcc4b97908b4f3669c549dcf7cf7e33dc1d0 [^] Fixed ISSUE-53930: Coupon should be filtered by External BP Reference --- M src/org/openbravo/retail/discounts/coupons/DISCPUtils.java M src/org/openbravo/retail/discounts/coupons/GetCoupons.java M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/AvailableCouponsList/AvailableCouponsList.jsx M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/CouponsPanelGrid.jsx M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/coupons/user-actions/AddCoupon.js M web-jspack/org.openbravo.retail.discounts.coupons/src/services/scan/handlers/CouponScanEventHandler.js --- |
|
(0158208) hgbot (developer) 2023-12-14 12:29 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/37 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-11-14 12:52 | nicolasuriz | New Issue | |
| 2023-11-14 12:52 | nicolasuriz | Assigned To | => Retail |
| 2023-11-14 12:52 | nicolasuriz | File Added: Nominal coupons.png | |
| 2023-11-14 12:52 | nicolasuriz | Triggers an Emergency Pack | => No |
| 2023-11-22 08:29 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2023-11-22 19:34 | ranjith_qualiantech_com | Status | new => scheduled |
| 2023-11-23 05:14 | hgbot | Note Added: 0157514 | |
| 2023-12-01 14:28 | hgbot | Note Added: 0157917 | |
| 2023-12-01 14:28 | hgbot | Resolution | open => fixed |
| 2023-12-01 14:28 | hgbot | Status | scheduled => closed |
| 2023-12-01 14:28 | hgbot | Note Added: 0157918 | |
| 2023-12-12 17:51 | kchoperena | Note Added: 0158113 | |
| 2023-12-12 17:51 | kchoperena | Status | closed => new |
| 2023-12-12 17:51 | kchoperena | Resolution | fixed => open |
| 2023-12-12 17:52 | kchoperena | File Added: image (7).png | |
| 2023-12-12 17:53 | kchoperena | File Added: image (8).png | |
| 2023-12-13 09:08 | hgbot | Note Added: 0158127 | |
| 2023-12-13 11:48 | ranjith_qualiantech_com | Status | new => scheduled |
| 2023-12-14 12:29 | hgbot | Resolution | open => fixed |
| 2023-12-14 12:29 | hgbot | Status | scheduled => closed |
| 2023-12-14 12:29 | hgbot | Note Added: 0158207 | |
| 2023-12-14 12:29 | hgbot | Note Added: 0158208 | |
| 2024-01-10 14:58 | rafaroda | Relationship added | related to 0054177 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |