Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0053908 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
backport | [Modules] External Data Integration | major | always | 2023-10-31 13:32 | 2023-11-13 08:35 | |||
Reporter | malsasua | View Status | public | |||||
Assigned To | caristu | |||||||
Priority | high | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Regression date | ||||||||
Regression introduced by commit | ||||||||
Regression level | ||||||||
Review Assigned To | cberner | |||||||
Support ticket | ||||||||
OBNetwork customer | No | |||||||
Regression introduced in release | ||||||||
Summary | 0053908: EDL process is duplicating request lines | |||||||
Description | In EDL process, when there are several item ids by line, the process of one item raises an error, and after that, the export of the items raise another error, the first item ID is added in a new request line, but it is not removed from the original request line. | |||||||
Steps To Reproduce | . install edl example module: https://gitlab.com/openbravo/demo/org.openbravo.externaldata.integration.examples [^] . apply patch1 (attached) to force errors in some lines in the Import UOM Asynchronously process: it forces a processing error in one individual item and a general error when executing the OutputDataProcessor. . execute Import UOM Asynchronously process. The generated EDL request have: --> One line in error with the item whose processing failed. This is correct. --> Another line in error (because the OutputDataProcessor failed) with the correctly processed items plus the item whose processing failed. This is wrong, the item whose processing failed should not be present in this line | |||||||
Proposed Solution | attached possible fix (patch2) | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
||||||||
|
![]() |
|
(0157008) hgbot (developer) 2023-11-10 09:05 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/37 [^] |
(0157010) caristu (viewer) 2023-11-10 09:06 |
Note that this backport contains two commits: 1- One commit to fix some parts of the error management that were not working in the same way as it was before the changes introduced with 0052614. This is the part that can be considered a regression. 2- The specific fix for the issue, which is not a regression but we think it is worth to backport it (it is not very risky) to have it also fixed in 23Q4 release. |
(0157060) hgbot (developer) 2023-11-13 08:34 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^] Changeset: 28792adc64e3ab97b921430c4124b0971643c0f5 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 10-11-2023 08:58:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/28792adc64e3ab97b921430c4124b0971643c0f5 [^] related to BUG-53908: improve request line process error management --- M src/org/openbravo/externaldata/integration/process/ProcessRequest.java --- |
(0157061) hgbot (developer) 2023-11-13 08:34 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^] Changeset: 01919d7f4c83c58e54b79519c73a8eb8e3f5b7c8 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 10-11-2023 08:58:23 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/01919d7f4c83c58e54b79519c73a8eb8e3f5b7c8 [^] related to BUG-53908: duplicated error items that may appear in different error lines --- M src/org/openbravo/externaldata/integration/process/ProcessRequest.java --- |
(0157062) hgbot (developer) 2023-11-13 08:34 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/37 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2023-11-10 08:49 | caristu | Type | defect => backport |
2023-11-10 08:49 | caristu | Target Version | => PR23Q4 |
2023-11-10 08:50 | caristu | Project | Openbravo ERP => Modules |
2023-11-10 08:51 | caristu | Support ticket | 77193 => |
2023-11-10 08:51 | caristu | OBNetwork customer | Gold => No |
2023-11-10 08:51 | caristu | Target Version | PR23Q4 => |
2023-11-10 09:05 | hgbot | Note Added: 0157008 | |
2023-11-10 09:06 | caristu | Note Added: 0157010 | |
2023-11-10 13:44 | hgbot | Merge Request Status | open => approved |
2023-11-13 08:34 | hgbot | Note Added: 0157060 | |
2023-11-13 08:34 | hgbot | Note Added: 0157061 | |
2023-11-13 08:34 | hgbot | Note Added: 0157062 | |
2023-11-13 08:35 | caristu | Status | scheduled => resolved |
2023-11-13 08:35 | caristu | Resolution | open => fixed |
2023-11-13 08:35 | caristu | Review Assigned To | => cberner |
2023-11-13 08:35 | caristu | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |