Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0053813

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] POS

minor

have not tried

2023-10-31 10:57

2023-11-03 11:03

Reporter

guilleaer

View Status

public

Assigned To

guilleaer

Priority

normal

Resolution

fixed

Fixed in Version

24Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0053813: CRM Conector - Fields to be shown only for create/edit but not in view are not correctly defaulted

Description

CRM Connector - Fields to be shown only for create/edit mode but not in view mode are not correctly defaulted

Steps To Reproduce

Configure a CRM property as follows:
-> Display in view: False
-> Display in edit: True
-> Display in create: True

Build a CRM integration which returns a value for the property in the "createForNew" method

In POS2 open the create customer dialog -> Default value does not appear filled

Tags

No tags attached.

diffLoadingMode.diff [^] (1,622 bytes) 2023-10-31 11:06 [Show Content] [Hide Content]

diff --git a/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerAddressForm/CustomerAddressFormHandler.js b/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerAddressForm/CustomerAddressFormHandler.js
index 432d74ca2..6a9b0f018 100644
--- a/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerAddressForm/CustomerAddressFormHandler.js
+++ b/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerAddressForm/CustomerAddressFormHandler.js
@@ -120,7 +120,8 @@ class ExternalBpAddressFormHandler extends CustomerFormHandler {
       newState = {
         ...newState,
         customerAddress,
-        externalBusinessPartner
+        externalBusinessPartner,
+        mode: customerAddressToManage.mode
       };
       newState = getComponentsFormFields(customerAddress, newState);
       newState = setValueFormFields(customerAddress, newState);
diff --git a/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js b/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
index 940c5ce9a..95834c7d5 100644
--- a/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
+++ b/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
@@ -66,7 +66,8 @@ class CustomerFormHandler extends FormHandler {
 
       newState = {
         ...newState,
-        customer
+        customer,
+        mode: customerToManage.mode
       };
       newState = getComponentsFormFields(customer, newState);
       newState = setValueFormFields(customer, newState);

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

23Q4

closed

CRM Conector - Fields to be shown only for create/edit but not in view are not correctly defaulted

Notes
(0156648) hgbot (developer) 2023-11-02 22:18	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2218 [^]

(0156676) hgbot (developer) 2023-11-03 11:03	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2218 [^]

(0156677) hgbot (developer) 2023-11-03 11:03	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0432058b1bc83d24be9bb0bfc3af6a7a4624ada4 Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com> Date: 03-11-2023 10:03:45 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0432058b1bc83d24be9bb0bfc3af6a7a4624ada4 [^] fixed ISSUE-53813: Form mode is always set in the CRM form internal state --- M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerAddressForm/CustomerAddressFormHandler.js M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js ---

Issue History
Date Modified	Username	Field	Change
2023-10-31 10:57	guilleaer	New Issue
2023-10-31 10:57	guilleaer	Assigned To	=> guilleaer
2023-10-31 10:57	guilleaer	Triggers an Emergency Pack	=> No
2023-10-31 11:05	guilleaer	Status	new => scheduled
2023-10-31 11:06	guilleaer	File Added: diffLoadingMode.diff
2023-11-02 22:18	hgbot	Note Added: 0156648
2023-11-03 11:03	hgbot	Note Added: 0156676
2023-11-03 11:03	hgbot	Resolution	open => fixed
2023-11-03 11:03	hgbot	Status	scheduled => closed
2023-11-03 11:03	hgbot	Fixed in Version	=> 24Q1
2023-11-03 11:03	hgbot	Note Added: 0156677

Copyright © 2000 - 2009 MantisBT Group