Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053750 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | have not tried | 2023-10-23 20:48 | 2023-10-27 11:42 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR23Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2023-06-14 | |||||||
| Regression introduced in release | PR23Q3 | |||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3814f42dd715096570c6d519a63e77fb9ebb2738 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053750: NullPointerException thrown in EDL in unhandled exception cases | |||||||
| Description | A NullPointerException is thrown when an exception is not properly handled by the EDL infrastructure. This is due to a block where we have an CompletableFuture#exceptionally call, it should properly return an error object instead of null: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/ProcessRequest.java#L607 [^] | |||||||
| Steps To Reproduce | ## These steps are not complete, they require some addition, to be done 1. Setup an EDL Process to be launched, like for example Push API 2. Add an exception at the end of nonBlockingEDLCompleted function: 2.1. To add just before this return line: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/ProcessRequest.java#L702 [^] if (1 == 1) { throw new OBException("ERROR"); } 3. Execute what is required for the EDL to be launched. Check that a NullPointerException is thrown just at this line: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java#L206 [^] | |||||||
| Proposed Solution | Return a proper JSONObject error instead of null in this exceptionally block: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/ProcessRequest.java#L607 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0156245) hgbot (developer) 2023-10-24 17:26 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/32 [^] |
|
(0156250) hgbot (developer) 2023-10-24 23:46 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^] Changeset: 8c2ce2a261604f3f3b9ab2a833e79e5141e7431d Author: Cristian Berner <cristian.berner@openbravo.com> Date: 24-10-2023 17:26:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/8c2ce2a261604f3f3b9ab2a833e79e5141e7431d [^] Fixes ISSUE-53750: NullPointerException thrown in EDL on unhandled exception cases A NullPointerException was thrown due to missing returning an error object in the exceptionally block of a CompletableFuture. --- M src/org/openbravo/externaldata/integration/process/ProcessRequest.java --- |
|
(0156251) hgbot (developer) 2023-10-24 23:46 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/32 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-10-24 16:41 | cberner | Type | defect => backport |
| 2023-10-24 16:41 | cberner | Target Version | => PR23Q4 |
| 2023-10-24 17:26 | hgbot | Note Added: 0156245 | |
| 2023-10-24 23:46 | hgbot | Resolution | open => fixed |
| 2023-10-24 23:46 | hgbot | Status | scheduled => closed |
| 2023-10-24 23:46 | hgbot | Note Added: 0156250 | |
| 2023-10-24 23:46 | hgbot | Note Added: 0156251 | |
| 2023-10-27 11:42 | ivancaceres | Issue Monitored: ivancaceres | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |