Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053742
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2023-10-23 20:482023-10-27 11:44
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision8c6a5c8c55b2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2023-06-14
Regression introduced in releasePR23Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3814f42dd715096570c6d519a63e77fb9ebb2738 [^]
Triggers an Emergency PackNo
Summary

0053742: NullPointerException thrown in EDL in unhandled exception cases

DescriptionA NullPointerException is thrown when an exception is not properly handled by the EDL infrastructure.

This is due to a block where we have an CompletableFuture#exceptionally call, it should properly return an error object instead of null: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/ProcessRequest.java#L607 [^]
Steps To Reproduce## These steps are not complete, they require some addition, to be done
1. Setup an EDL Process to be launched, like for example Push API
2. Add an exception at the end of nonBlockingEDLCompleted function:
  2.1. To add just before this return line: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/ProcessRequest.java#L702 [^]
    if (1 == 1) {
      throw new OBException("ERROR");
    }
3. Execute what is required for the EDL to be launched.

Check that a NullPointerException is thrown just at this line: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java#L206 [^]
Proposed SolutionReturn a proper JSONObject error instead of null in this exceptionally block: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/blob/master/src/org/openbravo/externaldata/integration/process/ProcessRequest.java#L607 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0053750PR23Q4 closedcberner NullPointerException thrown in EDL in unhandled exception cases 
caused by feature request 0052614 closedcberner There should be a mechanism to have non-blocking async EDL Requests 

-  Notes
(0156213)
hgbot (developer)
2023-10-23 20:50

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/30 [^]
(0156237)
hgbot (developer)
2023-10-24 16:27

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 8c6a5c8c55b2de0f68e237dcb2e758b5f00154aa
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 23-10-2023 20:49:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/8c6a5c8c55b2de0f68e237dcb2e758b5f00154aa [^]

Fixes ISSUE-53742: NullPointerException thrown in EDL on unhandled exception cases

A NullPointerException was thrown due to missing returning an error
object in the exceptionally block of a CompletableFuture.

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0156238)
hgbot (developer)
2023-10-24 16:27

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/30 [^]

- Issue History
Date Modified Username Field Change
2023-10-23 20:48 cberner New Issue
2023-10-23 20:48 cberner Assigned To => Triage Platform Base
2023-10-23 20:48 cberner OBNetwork customer => No
2023-10-23 20:48 cberner Modules => Core
2023-10-23 20:48 cberner Regression level => Production - QA Approved
2023-10-23 20:48 cberner Regression date => 2023-06-14
2023-10-23 20:48 cberner Regression introduced in release => PR23Q3
2023-10-23 20:48 cberner Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3814f42dd715096570c6d519a63e77fb9ebb2738 [^]
2023-10-23 20:48 cberner Triggers an Emergency Pack => No
2023-10-23 20:48 cberner Assigned To Triage Platform Base => cberner
2023-10-23 20:48 cberner Status new => acknowledged
2023-10-23 20:50 hgbot Merge Request Status => open
2023-10-23 20:50 hgbot Note Added: 0156213
2023-10-24 16:14 cberner Relationship added caused by 0052614
2023-10-24 16:26 hgbot Merge Request Status open => approved
2023-10-24 16:27 hgbot Resolution open => fixed
2023-10-24 16:27 hgbot Status acknowledged => closed
2023-10-24 16:27 hgbot Note Added: 0156237
2023-10-24 16:27 hgbot Note Added: 0156238
2023-10-24 16:41 cberner Status closed => new
2023-10-24 16:41 cberner Resolution fixed => open
2023-10-24 16:41 cberner Status new => scheduled
2023-10-24 16:42 cberner Status scheduled => resolved
2023-10-24 16:42 cberner Fixed in SCM revision => 8c6a5c8c55b2de0f68e237dcb2e758b5f00154aa
2023-10-24 16:42 cberner Resolution open => fixed
2023-10-24 16:42 cberner Review Assigned To => AugustoMauch
2023-10-24 16:42 cberner Status resolved => closed
2023-10-27 11:44 ivancaceres Issue Monitored: ivancaceres

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker