Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053708
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Corecriticalhave not tried2023-10-18 23:132023-11-22 08:26
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053708: Updating the sources in a terminal may result in duplicated document numbers

DescriptionA terminal that was loaded a new version of the POS2 sources is likely to create ticket with duplicated numbers right after the update.

This happens because when sources are updated, the state of the application is reset (see [1] and [2]. Part of the reset state would have contained the document number sequences. If they are not available in the state, the POS will initialize them from the terminal. Since the terminal is not updated on every login but only right after each master data refresh, it could be that the document numbers read from the terminal are outdated, and as a consequence the POS would create tickets with duplicated document numbers.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/registerServiceWorker.js#L71 [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/StatePersistence.js#L361 [^]
Steps To Reproduce- Open POS in livebuilds: https://livebuilds.openbravo.com/context/retail_pos2_pgsql/web/pos/?terminal=VBS-2 [^]
- Create a few tickets. Check their document number in the backoffice
- Logout in the POS
- Execute this in the debugger console to simulate a source upgrade, then refresh the browser and log in again: OB.UTIL.localStorage.removeItem('stateIsConsistentWithLocalStorage')
- Create some more tickets. Check in the backoffice that the latest tickets were created with document numbers that had already been used.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 005399423Q4.1 closedAugustoMauch Updating the sources in a terminal may result in duplicated document numbers 

-  Notes
(0156122)
hgbot (developer)
2023-10-20 12:48

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/628 [^]
(0156146)
hgbot (developer)
2023-10-23 08:17

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1266 [^]
(0156202)
hgbot (developer)
2023-10-23 16:33

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1266 [^]
(0156203)
hgbot (developer)
2023-10-23 16:33

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 82892404196700145bac85ccbafb61d45f3e83e4
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-10-2023 16:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/82892404196700145bac85ccbafb61d45f3e83e4 [^]

Fixes ISSUE-53708: Force an incremental refresh after updating sources to update the terminal info

When sources are updated, the state of the application is reset. Some properties of the state are then initialized using information
from the terminal object, so the terminal must be updated to ensure the initialization is done with updated information

---
M web-jspack/org.openbravo.core2/src/registerServiceWorker.js
M web-jspack/org.openbravo.core2/src/serviceWorkerRegistration.js
---
(0156204)
hgbot (developer)
2023-10-23 16:33

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: e04f55cd6c0fdc7e27e1fb961b9d414213bb803c
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 20-10-2023 09:36:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/e04f55cd6c0fdc7e27e1fb961b9d414213bb803c [^]

Related to ISSUE-53708: Add a new condition to incremental refresh so it can be forced after updating the sources

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0156205)
hgbot (developer)
2023-10-23 16:33

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/628 [^]
(0157442)
AugustoMauch (manager)
2023-11-22 08:26

 Reopened to create backport

- Issue History
Date Modified Username Field Change
2023-10-18 23:13 AugustoMauch New Issue
2023-10-18 23:13 AugustoMauch Assigned To => AugustoMauch
2023-10-18 23:13 AugustoMauch Triggers an Emergency Pack => No
2023-10-18 23:14 AugustoMauch Status new => scheduled
2023-10-19 11:37 cberner Steps to Reproduce Updated View Revisions
2023-10-20 10:15 rafademiguel Issue Monitored: rafademiguel
2023-10-20 12:48 hgbot Note Added: 0156122
2023-10-23 08:17 hgbot Note Added: 0156146
2023-10-23 16:33 hgbot Note Added: 0156202
2023-10-23 16:33 hgbot Resolution open => fixed
2023-10-23 16:33 hgbot Status scheduled => closed
2023-10-23 16:33 hgbot Fixed in Version => 24Q1
2023-10-23 16:33 hgbot Note Added: 0156203
2023-10-23 16:33 hgbot Note Added: 0156204
2023-10-23 16:33 hgbot Note Added: 0156205
2023-11-22 08:26 AugustoMauch Note Added: 0157442
2023-11-22 08:26 AugustoMauch Status closed => new
2023-11-22 08:26 AugustoMauch Resolution fixed => open
2023-11-22 08:26 AugustoMauch Fixed in Version 24Q1 =>
2023-11-22 08:26 AugustoMauch Status new => scheduled
2023-11-22 08:26 AugustoMauch Status scheduled => resolved
2023-11-22 08:26 AugustoMauch Resolution open => fixed
2023-11-22 08:26 AugustoMauch Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker