Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053616
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POScriticalhave not tried2023-10-09 08:542023-10-11 18:15
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelQA functional test
Regression date2023-10-04
Regression introduced in releasepi
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a94be8f770a3b503b25d75ab848c85a01275b607 [^]
Triggers an Emergency PackNo
Summary

0053616: POS2 is not using the default language defined for the user

DescriptionTo fix this issue [1], some changes were done to ensure the proper language was shown in the login page of EnyoPOS and ReactPOS. The problem was that it introduced this regression, and now the language defined at user level is not being used after a user logs in

[1] https://issues.openbravo.com/view.php?id=53450 [^]
Steps To ReproduceIn any pos2 environment:
1- Set English as the language for the client that you will use for the tests
2- Set French as the default language for the user that you will use for the tests
3- Open the Login page of POS2. It should be displayed in English.
4- Login with the user configured in step #2. The application should be displayed in French, but it is displayed in English
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0053450 closedmeriem_azaf POS Login Page Language 

-  Notes
(0155655)
hgbot (developer)
2023-10-09 09:02

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2160 [^]
(0155724)
hgbot (developer)
2023-10-10 10:24

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1380 [^]
(0155766)
hgbot (developer)
2023-10-11 09:39

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 532844ba9f274cc84b64e4e89628d708b1eda628
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 11-10-2023 07:38:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/532844ba9f274cc84b64e4e89628d708b1eda628 [^]

Fixes ISSUE-53616: User default language is taken into account after login

UpdatesLoginUtilsServlet so that if the logic to show the proper language on the login screen (see [1])
is only triggered on the login screen (user in context has 0 as id). Otherwise, the business logic that
used to work, that took into account default language at user, role or terminal level, will be used.

[1] https://issues.openbravo.com/view.php\?id\=53450 [^]

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0155767)
hgbot (developer)
2023-10-11 09:39

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1380 [^]
(0155768)
hgbot (developer)
2023-10-11 09:39

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2160 [^]
(0155769)
hgbot (developer)
2023-10-11 09:39

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ef194aa03215cb3e2e69b611235c4ac511581f9d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 11-10-2023 07:38:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ef194aa03215cb3e2e69b611235c4ac511581f9d [^]

Fixes ISSUE-53616: User default language is taken into account after login

Updates POS2LoginUtilsServlet so that if a user is logged in, its language is used. The logic defined in issue [1]
to determine the language of the login page should only be applied when there is no user logged in yet (that is,
the system user is present in the context

[1] https://issues.openbravo.com/view.php\?id\=53450 [^]

---
M src/org/openbravo/pos2/login/POS2LoginUtilsServlet.java
---

- Issue History
Date Modified Username Field Change
2023-10-09 08:54 AugustoMauch New Issue
2023-10-09 08:54 AugustoMauch Assigned To => AugustoMauch
2023-10-09 08:54 AugustoMauch Regression level => QA functional test
2023-10-09 08:54 AugustoMauch Regression date => 2023-10-04
2023-10-09 08:54 AugustoMauch Regression introduced in release => pi
2023-10-09 08:54 AugustoMauch Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a94be8f770a3b503b25d75ab848c85a01275b607 [^]
2023-10-09 08:54 AugustoMauch Triggers an Emergency Pack => No
2023-10-09 08:54 AugustoMauch Status new => scheduled
2023-10-09 09:02 hgbot Note Added: 0155655
2023-10-10 10:24 hgbot Note Added: 0155724
2023-10-11 09:39 hgbot Resolution open => fixed
2023-10-11 09:39 hgbot Status scheduled => closed
2023-10-11 09:39 hgbot Fixed in Version => RR24Q1
2023-10-11 09:39 hgbot Note Added: 0155766
2023-10-11 09:39 hgbot Note Added: 0155767
2023-10-11 09:39 hgbot Note Added: 0155768
2023-10-11 09:39 hgbot Fixed in Version RR24Q1 => 24Q1
2023-10-11 09:39 hgbot Note Added: 0155769
2023-10-11 18:15 rafaroda Relationship added related to 0053450
2023-11-21 16:45 AugustoMauch Relationship replaced caused by 0053450

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker