Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053601 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] Core | minor | have not tried | 2023-10-05 10:36 | 2023-10-20 08:47 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 24Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053601: Request user action approval separately from reasons | |||||||
| Description | Currently both approval and reasons are requested together, in the same dialog, per reason item. This forces the supervisor to enter the approval per reason item. It would be nice to separate the approval request so it is asked once, right after the reason for each of the reason items has been provided. | |||||||
| Steps To Reproduce | . | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0155556) hgbot (developer) 2023-10-05 10:42 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1258 [^] |
|
(0155726) hgbot (developer) 2023-10-10 10:58 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2164 [^] |
|
(0156042) hgbot (developer) 2023-10-19 11:42 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 7a7835ad560cc129128f19fb6147dc25ba3949f2 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 19-10-2023 11:41:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/7a7835ad560cc129128f19fb6147dc25ba3949f2 [^] fixes FR-53601: Request user action approval separately from reasons --- A web-jspack/org.openbravo.core2/src/components/List/TextList.jsx A web-jspack/org.openbravo.core2/src/components/List/TextList.scss A web-jspack/org.openbravo.core2/src/components/List/TextListGroup.jsx A web-jspack/org.openbravo.core2/src/components/List/TextListGroup.scss A web-jspack/org.openbravo.core2/src/components/List/__test__/TextListGroup.test.jsx A web-jspack/org.openbravo.core2/src/components/List/index.js A web-jspack/org.openbravo.core2/src/components/List/stories/TextListGroup.stories.jsx A web-jspack/org.openbravo.core2/src/components/List/stories/TextListGroup.stories.scss A web-jspack/org.openbravo.core2/src/components/List/stories/TextListGroupStoryHolder.jsx M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.scss M web-jspack/org.openbravo.core2/src/components/Form/BaseFormContent.jsx M web-jspack/org.openbravo.core2/src/components/InputDataDialog/InputDataDialog.jsx M web-jspack/org.openbravo.core2/src/components/ReasonAndApprovalDialog/ReasonAndApprovalDialog.scss M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/StandardInputDataDialog.jsx M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/__test__/StandardInputDataDialog.test.jsx M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.jsx M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialogStoryHolder.jsx M web-jspack/org.openbravo.core2/src/core/security/ApprovalChecker.js M web-jspack/org.openbravo.core2/src/core/security/__test__/ApprovalChecker.test.js M web-jspack/org.openbravo.core2/src/core/security/requestReasonAndApproval.js M web-jspack/org.openbravo.core2/src/core/terminal/Security.js M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js M web-jspack/org.openbravo.core2/src/ob-init.js --- |
|
(0156043) hgbot (developer) 2023-10-19 11:42 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1258 [^] |
|
(0156044) hgbot (developer) 2023-10-19 11:43 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: bf2e0a6ae189415b41691578fe01d8d7892ee9fc Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 19-10-2023 11:42:54 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bf2e0a6ae189415b41691578fe01d8d7892ee9fc [^] related to FR-53601: Request user action approval separately from reasons --- A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/TicketLineUserAction.js A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/TicketLineUserAction.test.js M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/DeleteLine.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SetLinePrice.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/SetLineReturnReason.test.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/SetLineDiscounts.js --- |
|
(0156045) hgbot (developer) 2023-10-19 11:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2164 [^] |
|
(0156071) hgbot (developer) 2023-10-19 14:24 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: ef6dfc6fdfae3490e967207a8164704cf092b2da Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 19-10-2023 14:24:09 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ef6dfc6fdfae3490e967207a8164704cf092b2da [^] related to FR-53601: prevent max-width just for combo fields --- M web-jspack/org.openbravo.core2/src/components/ReasonAndApprovalDialog/ReasonAndApprovalDialog.scss --- |
|
(0156093) hgbot (developer) 2023-10-19 17:09 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 3036a4c0fa8aa8df9c42e8fa9b01b788cf1f75fa Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 19-10-2023 17:09:03 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3036a4c0fa8aa8df9c42e8fa9b01b788cf1f75fa [^] related to FR-53601: fix reason/approval message for return line --- M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/TicketLineUserAction.js --- |
|
(0156106) hgbot (developer) 2023-10-20 08:47 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: ba8c2b6dc094a64f9e76c4731be5046de181c46e Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 20-10-2023 08:47:35 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ba8c2b6dc094a64f9e76c4731be5046de181c46e [^] related to FR-53601: fix test --- M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/TicketLineUserAction.test.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-10-05 10:36 | caristu | New Issue | |
| 2023-10-05 10:36 | caristu | Assigned To | => caristu |
| 2023-10-05 10:36 | caristu | Triggers an Emergency Pack | => No |
| 2023-10-05 10:37 | caristu | Relationship added | blocks 0053576 |
| 2023-10-05 10:42 | hgbot | Note Added: 0155556 | |
| 2023-10-10 10:58 | hgbot | Note Added: 0155726 | |
| 2023-10-19 11:42 | hgbot | Resolution | open => fixed |
| 2023-10-19 11:42 | hgbot | Status | new => closed |
| 2023-10-19 11:42 | hgbot | Fixed in Version | => 24Q1 |
| 2023-10-19 11:42 | hgbot | Note Added: 0156042 | |
| 2023-10-19 11:42 | hgbot | Note Added: 0156043 | |
| 2023-10-19 11:43 | hgbot | Note Added: 0156044 | |
| 2023-10-19 11:43 | hgbot | Note Added: 0156045 | |
| 2023-10-19 14:24 | hgbot | Note Added: 0156071 | |
| 2023-10-19 17:09 | hgbot | Note Added: 0156093 | |
| 2023-10-20 08:47 | hgbot | Note Added: 0156106 | |
| 2024-01-19 13:15 | caristu | Relationship added | related to 0054363 |
| 2024-02-12 07:40 | caristu | Relationship deleted | related to 0054363 |
| 2024-02-12 07:41 | caristu | Relationship added | causes 0054363 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |