0053578: Filter in P&E windows having relevant characteristics and filtering having records selected

org.openbravo.base.exception.OBException: Exception when creating query select e from Product as e left outer join e.productCharacteristicValueList as join_0 left outer join join_0.characteristicValue as join_1 left outer join join_1.id as join_2 where ( (( e.id = :alias_1 or e.id = :alias_2 or e.id = :alias_3 or upper(e.name) like upper(:alias_4) escape '|' )) and e.organization in ('102D0E6D37DA46C3BABA6DFF3708F341','14B1927026BE471E9B85FE699BCA61C2','4399136852B145BD96CC2A6CE0800C68','D270A5AC50874F8BA67A88EE977F8E3B','0','3B187EC130A549A7A9388F8060EF156D','65C1C46FB1D04CBD98CBD4167CCFE600','687AD71263F94A31B85A3CC9942FF7ED','67839EEFA49E44AC969BD60093FCC899','B5DE96143D6642228E3B9DEC69886A47','CCAAD77DA7994401A9657F04AEB6342E','DF86640764AA4492AB6D4CA2D432B8D4','01AD882EFC8545ACA6455E2F6FD51EE9','BF129721D9FB4EB0819509934153E972','E2A8087A81F54203969C6AED1AABBC72') ) and e.client.id in (:_dal_readableClients_dal_) and e.active='Y' order by e.searchKey,e.id at org.openbravo.dal.service.OBQuery.createQuery(OBQuery.java:289) ~[classes/:?] at org.openbravo.dal.service.OBQuery.createQuery(OBQuery.java:259) ~[classes/:?] at org.openbravo.dal.service.OBQuery.list(OBQuery.java:123) ~[classes/:?] at org.openbravo.service.json.DataEntityQueryService.list(DataEntityQueryService.java:108) ~[classes/:?] at org.openbravo.service.json.DefaultJsonDataService.fetch(DefaultJsonDataService.java:260) [classes/:?] at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:91) [classes/:?] at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:82) [classes/:?] at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:270) [classes/:?] at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:323) [classes/:?] at javax.servlet.http.HttpServlet.service(HttpServlet.java:661) [servlet-api.jar:?] at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:200) [openbravo-core.jar:?] at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:459) [classes/:?] at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:89) [classes/:?] at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:60) [classes/:?] at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:132) [classes/:?] at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) [servlet-api.jar:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) [catalina.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [catalina.jar:8.5.38] at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-websocket.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [catalina.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [catalina.jar:8.5.38] at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66) [openbravo-core.jar:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [catalina.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [catalina.jar:8.5.38] at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:38) [openbravo-core.jar:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [catalina.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [catalina.jar:8.5.38] at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:65) [classes/:?] at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:47) [classes/:?] at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:74) [classes/:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [catalina.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [catalina.jar:8.5.38] at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:96) [classes/:?] at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:47) [classes/:?] at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:118) [classes/:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [catalina.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [catalina.jar:8.5.38] at org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71) [log4j-web-2.17.1.jar:2.17.1] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [catalina.jar:8.5.38] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [catalina.jar:8.5.38] at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199) [catalina.jar:8.5.38] at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) [catalina.jar:8.5.38] at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:493) [catalina.jar:8.5.38] at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) [catalina.jar:8.5.38] at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) [catalina.jar:8.5.38] at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650) [catalina.jar:8.5.38] at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [catalina.jar:8.5.38] at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342) [catalina.jar:8.5.38] at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:800) [tomcat-coyote.jar:8.5.38] at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat-coyote.jar:8.5.38] at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:806) [tomcat-coyote.jar:8.5.38] at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1498) [tomcat-coyote.jar:8.5.38] at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-coyote.jar:8.5.38] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?] at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-util.jar:8.5.38] at java.lang.Thread.run(Thread.java:829) [?:?] Caused by: java.lang.NullPointerException at org.hibernate.hql.internal.ast.HqlSqlWalker.createFromJoinElement(HqlSqlWalker.java:432) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.joinElement(HqlSqlBaseWalker.java:4007) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.fromElement(HqlSqlBaseWalker.java:3793) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.fromElementList(HqlSqlBaseWalker.java:3671) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.fromClause(HqlSqlBaseWalker.java:746) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.query(HqlSqlBaseWalker.java:602) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.selectStatement(HqlSqlBaseWalker.java:339) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.antlr.HqlSqlBaseWalker.statement(HqlSqlBaseWalker.java:287) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.ast.QueryTranslatorImpl.analyze(QueryTranslatorImpl.java:276) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.ast.QueryTranslatorImpl.doCompile(QueryTranslatorImpl.java:192) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.hql.internal.ast.QueryTranslatorImpl.compile(QueryTranslatorImpl.java:144) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.engine.query.spi.HQLQueryPlan.<init>(HQLQueryPlan.java:112) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.engine.query.spi.HQLQueryPlan.<init>(HQLQueryPlan.java:73) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.engine.query.spi.QueryPlanCache.getHQLQueryPlan(QueryPlanCache.java:162) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.internal.AbstractSharedSessionContract.getQueryPlan(AbstractSharedSessionContract.java:636) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:748) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:848) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:114) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final] at org.openbravo.dal.service.OBQuery.createQuery(OBQuery.java:275) ~[classes/:?] ... 56 more

Issue History
Date Modified	Username	Field	Change
2023-10-03 11:58	ignacio_deandres	New Issue
2023-10-03 11:58	ignacio_deandres	Assigned To	=> Triage Platform Base
2023-10-03 11:58	ignacio_deandres	OBNetwork customer	=> No
2023-10-03 11:58	ignacio_deandres	Triggers an Emergency Pack	=> No
2023-10-03 12:21	caristu	Project	POS2 => Openbravo ERP
2023-10-03 12:21	caristu	Modules	=> Core
2023-10-03 12:21	caristu	Category	Core => A. Platform
2023-10-03 12:29	hgbot	Merge Request Status	=> open
2023-10-03 12:29	hgbot	Note Added: 0155423
2023-10-03 12:35	caristu	Summary	Error in the Discounts and Promotions 'add product' functionality when choosing records and filtering. => Filter in P&E windows having relevant characteristics and filtering having records selected
2023-10-03 12:35	caristu	Description Updated	View Revisions
2023-10-03 12:35	caristu	Steps to Reproduce Updated	View Revisions
2023-10-03 12:37	caristu	File Added: exception.txt
2023-10-03 12:37	caristu	File Added: failingQuery.txt
2023-10-03 12:37	caristu	Assigned To	Triage Platform Base => ignacio_deandres
2023-10-16 10:16	hgbot	Merge Request Status	open => approved
2023-10-16 10:44	hgbot	Note Added: 0155867
2023-10-16 10:44	hgbot	Resolution	open => fixed
2023-10-16 10:44	hgbot	Status	new => closed
2023-10-16 10:44	hgbot	Fixed in Version	=> PR24Q1
2023-10-16 10:44	hgbot	Note Added: 0155868

Notes
(0155423) hgbot (developer) 2023-10-03 12:29	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1011 [^]

(0155867) hgbot (developer) 2023-10-16 10:44	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1011 [^]

(0155868) hgbot (developer) 2023-10-16 10:44	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: b93ddd3b6412681e5802152a5ef593ef0d4c71c3 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 16-10-2023 08:44:23 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/b93ddd3b6412681e5802152a5ef593ef0d4c71c3 [^] fixes BUG-53578: wrong query with relevant charact and record selection in P&E A query with relevant characteristics and an or criteria in the where clause was being wrongly build, causing a NPE when it was executed. This was reproducible having a P&E window showing a relevant characteristics and after trying to filter having at least one record selected. Now this is fixed by ensuring that the join definition is properly built also in this case. --- M modules/org.openbravo.service.json/src/org/openbravo/service/json/JoinDefinition.java ---

Relationships [ Relation Graph ] [ Dependency Graph ]