Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053535
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2023-09-25 09:562023-10-04 08:17
ReporterebecerraView Statuspublic 
Assigned Tocaristu 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053535: Fails to update records that have a reference to an external system

DescriptionFails to update records that have a reference to an external system if it is left empty (this is possible if the external system is not mandatory)
Steps To Reproduce0- Apply the attached path which adds a field that references to an external system from the [CRM Connector Configuration] window.
1- Go to the [External System] window and create at least one external system
2- Go to the [CRM Connector Configuration] window and fill the new "External System" field. Save the record.
3- Leave the "External System" field empty and try to save. The saving operation fails due to a NullPointerException:

java.lang.NullPointerException: null
    at org.openbravo.service.externalsystem.ExternalSystemDataEventHandler.clearCachedExternalSystemInstance(ExternalSystemDataEventHandler.java:94) ~[classes/:?]
    at org.openbravo.service.externalsystem.ExternalSystemDataEventHandler.onUpdate(ExternalSystemDataEventHandler.java:80) ~[classes/:?]
TagsNo tags attached.
Attached Filesdiff file icon field.diff [^] (10,730 bytes) 2023-09-25 16:29 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0048579 closedcaristu Openbravo ERP Push API 

-  Notes
(0155215)
hgbot (developer)
2023-09-25 16:43

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1006 [^]
(0155457)
hgbot (developer)
2023-10-04 08:13

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2f1ac48598f0b58d1d99fe411e982125d3c6bc81
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 04-10-2023 06:13:32
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2f1ac48598f0b58d1d99fe411e982125d3c6bc81 [^]

fixes BUG-53535: error updating records referencing external system

The ExternalSystemDataEventHandler was intended to invalidate cached
configurations that may have changed. For example, for HTTP based
external systems, these are changes done in the HTTP subtab.

But this event handler should not be fired when changing records of
other entities that has a reference to an external system. For this
reason we have added the isParent check because the configuration
entities are represented as children of the ExternalSystemData entity
and the rest of entities should not.

This changeset also renames the constant as EXTERNAL_SYSTEM_PROPERTY
to follow the standard convention.

---
M src/org/openbravo/service/externalsystem/ExternalSystemDataEventHandler.java
---
(0155458)
hgbot (developer)
2023-10-04 08:13

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1006 [^]

- Issue History
Date Modified Username Field Change
2023-09-25 09:56 ebecerra New Issue
2023-09-25 09:56 ebecerra Assigned To => Retail
2023-09-25 09:56 ebecerra Triggers an Emergency Pack => No
2023-09-25 09:57 ebecerra Assigned To Retail => caristu
2023-09-25 16:29 caristu Steps to Reproduce Updated View Revisions
2023-09-25 16:29 caristu File Added: field.diff
2023-09-25 16:43 hgbot Note Added: 0155215
2023-10-04 08:13 hgbot Resolution open => fixed
2023-10-04 08:13 hgbot Status new => closed
2023-10-04 08:13 hgbot Fixed in Version => PR24Q1
2023-10-04 08:13 hgbot Note Added: 0155457
2023-10-04 08:13 hgbot Note Added: 0155458
2023-10-04 08:17 caristu Relationship added related to 0048579

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker