Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053490 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | always | 2023-09-19 12:57 | 2023-10-20 14:14 | |||
| Reporter | guillermogil | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053490: User defined percentage raises an error when applied | |||||||
| Description | User defined percentage raises an error when applied. When applying it raises the following error message: POS2.js:108 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'scale') at e.toBigDecimal (POS2.js:108:13) at e.div (POS2.js:128:19) at POS2.js:43282:23 at Array.forEach (<anonymous>) at e.executeDiscountCalculation (POS2.js:43279:24) at e.calculateDiscounts (POS2.js:39390:12) at POS2.js:38741:11 at Array.forEach (<anonymous>) at OB.Discounts.applyDiscounts (POS2.js:38735:19) at OB.Discounts.Pos.applyDiscounts (POS2.js:37927:36) | |||||||
| Steps To Reproduce | - Create a User Defined Percentage discount in the backoffice - Login on POS - Add a product - Select the line - Go to Discounts - Click on your newly created discount Error is raised | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Screenshot from 2023-09-19 12-53-54.png [^] (182,679 bytes) 2023-09-19 12:57
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0155438) hgbot (developer) 2023-10-04 08:01 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/120 [^] |
|
(0156129) hgbot (developer) 2023-10-20 14:14 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: ba80e9ceb8ce0a933b2d8ed604d8bb957a6e2d3e Author: Ranjith S R <ranjith@qualiantech.com> Date: 03-10-2023 15:15:13 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/ba80e9ceb8ce0a933b2d8ed604d8bb957a6e2d3e [^] Fixed ISSUE-53490: Discount amount should be 0 by default for manual discounts * If manual discount amount is not configured, then default value "0" should be used for discount calculation --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-amount-promotions-discount.js M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-linefinalprice-promotions-discount.js M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-percentage-promotions-discount.js --- |
|
(0156130) hgbot (developer) 2023-10-20 14:14 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/120 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-09-19 12:57 | guillermogil | New Issue | |
| 2023-09-19 12:57 | guillermogil | Assigned To | => Retail |
| 2023-09-19 12:57 | guillermogil | File Added: Screenshot from 2023-09-19 12-53-54.png | |
| 2023-09-19 12:57 | guillermogil | OBNetwork customer | => Gold |
| 2023-09-19 12:57 | guillermogil | Triggers an Emergency Pack | => No |
| 2023-09-19 12:59 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2023-09-25 07:38 | ranjith_qualiantech_com | Status | new => scheduled |
| 2023-10-04 08:01 | hgbot | Merge Request Status | => open |
| 2023-10-04 08:01 | hgbot | Note Added: 0155438 | |
| 2023-10-20 14:14 | hgbot | Merge Request Status | open => approved |
| 2023-10-20 14:14 | hgbot | Resolution | open => fixed |
| 2023-10-20 14:14 | hgbot | Status | scheduled => closed |
| 2023-10-20 14:14 | hgbot | Fixed in Version | => RR24Q1 |
| 2023-10-20 14:14 | hgbot | Note Added: 0156129 | |
| 2023-10-20 14:14 | hgbot | Note Added: 0156130 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |